tipc: simplify bearer level broadcast

Until now, we have been keeping track of the exact set of broadcast
destinations though the help structure tipc_node_map. This leads us to
have to maintain a whole infrastructure for supporting this, including
a pseudo-bearer and a number of functions to manipulate both the bearers
and the node map correctly. Apart from the complexity, this approach is
also limiting, as struct tipc_node_map only can support cluster local
broadcast if we want to avoid it becoming excessively large. We want to
eliminate this limitation, in order to enable introduction of scoped
multicast in the future.

A closer analysis reveals that it is unnecessary maintaining this "full
set" overview; it is sufficient to keep a counter per bearer, indicating
how many nodes can be reached via this bearer at the moment. The protocol
is now robust enough to handle transitional discrepancies between the
nominal number of reachable destinations, as expected by the broadcast
protocol itself, and the number which is actually reachable at the
moment. The initial broadcast synchronization, in conjunction with the
retransmission mechanism, ensures that all packets will eventually be
acknowledged by the correct set of destinations.

This commit introduces these changes.

Signed-off-by: Jon Maloy <jon.maloy@ericsson.com>
Reviewed-by: Ying Xue <ying.xue@windriver.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

1 files changed, 5 insertions, 2 deletions

diff --git a/net/tipc/node.c b/net/tipc/node.c
index cd924552244b..b27439097d6c 100644
--- a/net/tipc/node.c
+++ b/net/tipc/node.c
@@ -346,6 +346,7 @@ static void __tipc_node_link_up(struct tipc_node *n, int bearer_id,
         n->links[bearer_id].mtu = nl->mtu - INT_H_SIZE;
 
         tipc_bearer_add_dest(n->net, bearer_id, n->addr);
+        tipc_bcast_inc_bearer_dst_cnt(n->net, bearer_id);
 
         pr_debug("Established link <%s> on network plane %c\n",
                  nl->name, nl->net_plane);
@@ -356,7 +357,7 @@ static void __tipc_node_link_up(struct tipc_node *n, int bearer_id,
                 *slot1 = bearer_id;
                 tipc_node_fsm_evt(n, SELF_ESTABL_CONTACT_EVT);
                 n->action_flags |= TIPC_NOTIFY_NODE_UP;
-                tipc_bcast_add_peer(n->net, n->addr, nl, xmitq);
+                tipc_bcast_add_peer(n->net, nl, xmitq);
                 return;
         }
 
@@ -443,8 +444,10 @@ static void __tipc_node_link_down(struct tipc_node *n, int *bearer_id,
                 tipc_link_build_reset_msg(l, xmitq);
                 *maddr = &n->links[*bearer_id].maddr;
                 node_lost_contact(n, &le->inputq);
+                tipc_bcast_dec_bearer_dst_cnt(n->net, *bearer_id);
                 return;
         }
+        tipc_bcast_dec_bearer_dst_cnt(n->net, *bearer_id);
 
         /* There is still a working link => initiate failover */
         tnl = node_active_link(n, 0);
@@ -860,7 +863,7 @@ static void node_lost_contact(struct tipc_node *n,
                  tipc_addr_string_fill(addr_string, n->addr));
 
         /* Clean up broadcast state */
-        tipc_bcast_remove_peer(n->net, n->addr, n->bc_entry.link);
+        tipc_bcast_remove_peer(n->net, n->bc_entry.link);
 
         /* Abort any ongoing link failover */
         for (i = 0; i < MAX_BEARERS; i++) {