diff options
author | Paul Gortmaker <paul.gortmaker@windriver.com> | 2011-09-02 13:45:34 -0400 |
---|---|---|
committer | Paul Gortmaker <paul.gortmaker@windriver.com> | 2011-09-17 22:55:09 -0400 |
commit | 1c553bb52eb4c58333a843c0a5888d2329909f62 (patch) | |
tree | 37f3a2273aad72ba7a7704b0af46a22fe14b5dd6 /net/tipc/name_distr.c | |
parent | 149ce37c8de72c64fc4f66c1b4cf7a0fb66b7ee9 (diff) |
tipc: relocate/coalesce node cast in tipc_named_node_up
Functions like this are called using unsigned longs from
function pointers. In this case, the function is passed in
a node which is normally internally treated as a u32 by TIPC.
Rather than add more casts into this function in the future
for each added use of node within, move the cast to a single
place on a local.
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
Diffstat (limited to 'net/tipc/name_distr.c')
-rw-r--r-- | net/tipc/name_distr.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/net/tipc/name_distr.c b/net/tipc/name_distr.c index 21bc0281ec89..97546f07938c 100644 --- a/net/tipc/name_distr.c +++ b/net/tipc/name_distr.c | |||
@@ -173,13 +173,14 @@ void tipc_named_withdraw(struct publication *publ) | |||
173 | * tipc_named_node_up - tell specified node about all publications by this node | 173 | * tipc_named_node_up - tell specified node about all publications by this node |
174 | */ | 174 | */ |
175 | 175 | ||
176 | void tipc_named_node_up(unsigned long node) | 176 | void tipc_named_node_up(unsigned long nodearg) |
177 | { | 177 | { |
178 | struct tipc_node *n_ptr; | 178 | struct tipc_node *n_ptr; |
179 | struct link *l_ptr; | 179 | struct link *l_ptr; |
180 | struct publication *publ; | 180 | struct publication *publ; |
181 | struct distr_item *item = NULL; | 181 | struct distr_item *item = NULL; |
182 | struct sk_buff *buf = NULL; | 182 | struct sk_buff *buf = NULL; |
183 | u32 node = (u32)nodearg; | ||
183 | u32 left = 0; | 184 | u32 left = 0; |
184 | u32 rest; | 185 | u32 rest; |
185 | u32 max_item_buf = 0; | 186 | u32 max_item_buf = 0; |
@@ -187,7 +188,7 @@ void tipc_named_node_up(unsigned long node) | |||
187 | /* compute maximum amount of publication data to send per message */ | 188 | /* compute maximum amount of publication data to send per message */ |
188 | 189 | ||
189 | read_lock_bh(&tipc_net_lock); | 190 | read_lock_bh(&tipc_net_lock); |
190 | n_ptr = tipc_node_find((u32)node); | 191 | n_ptr = tipc_node_find(node); |
191 | if (n_ptr) { | 192 | if (n_ptr) { |
192 | tipc_node_lock(n_ptr); | 193 | tipc_node_lock(n_ptr); |
193 | l_ptr = n_ptr->active_links[0]; | 194 | l_ptr = n_ptr->active_links[0]; |