net: add phys ID compare helper to test if two IDs are the same

Signed-off-by: Scott Feldman <sfeldma@gmail.com>
Acked-by: Jiri Pirko <jiri@resnulli.us>
Signed-off-by: David S. Miller <davem@davemloft.net>

1 files changed, 2 insertions, 6 deletions

diff --git a/net/switchdev/switchdev.c b/net/switchdev/switchdev.c
index 9f2add3cba26..4e5bba50ccff 100644
--- a/net/switchdev/switchdev.c
+++ b/net/switchdev/switchdev.c
@@ -910,13 +910,9 @@ static struct net_device *switchdev_get_dev_by_nhs(struct fib_info *fi)
                 if (switchdev_port_attr_get(dev, &attr))
                         return NULL;
 
-                if (nhsel > 0) {
-                        if (prev_attr.u.ppid.id_len != attr.u.ppid.id_len)
+                if (nhsel > 0 &&
+                    !netdev_phys_item_id_same(&prev_attr.u.ppid, &attr.u.ppid))
                                 return NULL;
-                        if (memcmp(prev_attr.u.ppid.id, attr.u.ppid.id,
-                                   attr.u.ppid.id_len))
-                                return NULL;
-                }
 
                 prev_attr = attr;
         }