diff options
| author | Arnd Bergmann <arnd@arndb.de> | 2018-08-13 18:12:45 -0400 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2018-08-13 23:45:49 -0400 |
| commit | 1bbf3aed25e0fc256e825da1f5c45d7b4daa828e (patch) | |
| tree | 785d4d7d59822490c0709d379954e3dba35729f1 /net/socket.c | |
| parent | cf87615d15f37182b2a3a4cd722288d3d5956900 (diff) | |
bnxt_en: take coredump_record structure off stack
The bnxt_coredump_record structure is very long, causing a warning
about possible stack overflow on 32-bit architectures:
drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c: In function 'bnxt_get_coredump':
drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c:2989:1: error: the frame size of 1188 bytes is larger than 1024 bytes [-Werror=frame-larger-than=]
I could not see any reason to operate on an on-stack copy of the
structure before copying it back into the caller-provided buffer, which
also simplifies the code here.
Fixes: 6c5657d085ae ("bnxt_en: Add support for ethtool get dump.")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/socket.c')
0 files changed, 0 insertions, 0 deletions