diff options
author | Xin Long <lucien.xin@gmail.com> | 2016-02-27 21:03:51 -0500 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2016-03-01 17:25:12 -0500 |
commit | 40b4f0fd74e46c017814618d67ec9127ff20f157 (patch) | |
tree | adcea5b2aceecbcfa9478e67652b166053dec08f /net/sctp | |
parent | f0da74bc8140001c6afd2a176e397c3c3aaca37a (diff) |
sctp: lack the check for ports in sctp_v6_cmp_addr
As the member .cmp_addr of sctp_af_inet6, sctp_v6_cmp_addr should also check
the port of addresses, just like sctp_v4_cmp_addr, cause it's invoked by
sctp_cmp_addr_exact().
Now sctp_v6_cmp_addr just check the port when two addresses have different
family, and lack the port check for two ipv6 addresses. that will make
sctp_hash_cmp() cannot work well.
so fix it by adding ports comparison in sctp_v6_cmp_addr().
Signed-off-by: Xin Long <lucien.xin@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/sctp')
-rw-r--r-- | net/sctp/ipv6.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/net/sctp/ipv6.c b/net/sctp/ipv6.c index ec529121f38a..ce46f1c7f133 100644 --- a/net/sctp/ipv6.c +++ b/net/sctp/ipv6.c | |||
@@ -526,6 +526,8 @@ static int sctp_v6_cmp_addr(const union sctp_addr *addr1, | |||
526 | } | 526 | } |
527 | return 0; | 527 | return 0; |
528 | } | 528 | } |
529 | if (addr1->v6.sin6_port != addr2->v6.sin6_port) | ||
530 | return 0; | ||
529 | if (!ipv6_addr_equal(&addr1->v6.sin6_addr, &addr2->v6.sin6_addr)) | 531 | if (!ipv6_addr_equal(&addr1->v6.sin6_addr, &addr2->v6.sin6_addr)) |
530 | return 0; | 532 | return 0; |
531 | /* If this is a linklocal address, compare the scope_id. */ | 533 | /* If this is a linklocal address, compare the scope_id. */ |