diff options
author | Marcelo Ricardo Leitner <marcelo.leitner@gmail.com> | 2018-05-14 13:35:20 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2018-05-14 23:15:27 -0400 |
commit | 5884f35f0d8924a1937c040e420255800c45ef0e (patch) | |
tree | df6722edf2d4fd6b1c238a5d605f651f86c6e2cd /net/sctp/outqueue.c | |
parent | e136e965df596d8e4fffa4ae0b202fd4c388568f (diff) |
sctp: checkpatch fixups
A collection of fixups from previous patches, left for later to not
introduce unnecessary changes while moving code around.
Signed-off-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/sctp/outqueue.c')
-rw-r--r-- | net/sctp/outqueue.c | 20 |
1 files changed, 7 insertions, 13 deletions
diff --git a/net/sctp/outqueue.c b/net/sctp/outqueue.c index 68b7baea3fea..d68aa33485a9 100644 --- a/net/sctp/outqueue.c +++ b/net/sctp/outqueue.c | |||
@@ -812,8 +812,7 @@ static void sctp_outq_select_transport(struct sctp_flush_ctx *ctx, | |||
812 | 812 | ||
813 | if (!new_transport) { | 813 | if (!new_transport) { |
814 | if (!sctp_chunk_is_data(chunk)) { | 814 | if (!sctp_chunk_is_data(chunk)) { |
815 | /* | 815 | /* If we have a prior transport pointer, see if |
816 | * If we have a prior transport pointer, see if | ||
817 | * the destination address of the chunk | 816 | * the destination address of the chunk |
818 | * matches the destination address of the | 817 | * matches the destination address of the |
819 | * current transport. If not a match, then | 818 | * current transport. If not a match, then |
@@ -912,8 +911,7 @@ static void sctp_outq_flush_ctrl(struct sctp_flush_ctx *ctx) | |||
912 | sctp_outq_select_transport(ctx, chunk); | 911 | sctp_outq_select_transport(ctx, chunk); |
913 | 912 | ||
914 | switch (chunk->chunk_hdr->type) { | 913 | switch (chunk->chunk_hdr->type) { |
915 | /* | 914 | /* 6.10 Bundling |
916 | * 6.10 Bundling | ||
917 | * ... | 915 | * ... |
918 | * An endpoint MUST NOT bundle INIT, INIT ACK or SHUTDOWN | 916 | * An endpoint MUST NOT bundle INIT, INIT ACK or SHUTDOWN |
919 | * COMPLETE with any other chunks. [Send them immediately.] | 917 | * COMPLETE with any other chunks. [Send them immediately.] |
@@ -1061,8 +1059,7 @@ static void sctp_outq_flush_data(struct sctp_flush_ctx *ctx, | |||
1061 | return; | 1059 | return; |
1062 | } | 1060 | } |
1063 | 1061 | ||
1064 | /* | 1062 | /* RFC 2960 6.1 Transmission of DATA Chunks |
1065 | * RFC 2960 6.1 Transmission of DATA Chunks | ||
1066 | * | 1063 | * |
1067 | * C) When the time comes for the sender to transmit, | 1064 | * C) When the time comes for the sender to transmit, |
1068 | * before sending new DATA chunks, the sender MUST | 1065 | * before sending new DATA chunks, the sender MUST |
@@ -1101,8 +1098,7 @@ static void sctp_outq_flush_data(struct sctp_flush_ctx *ctx, | |||
1101 | 1098 | ||
1102 | sctp_outq_select_transport(ctx, chunk); | 1099 | sctp_outq_select_transport(ctx, chunk); |
1103 | 1100 | ||
1104 | pr_debug("%s: outq:%p, chunk:%p[%s], tx-tsn:0x%x skb->head:%p " | 1101 | pr_debug("%s: outq:%p, chunk:%p[%s], tx-tsn:0x%x skb->head:%p skb->users:%d\n", |
1105 | "skb->users:%d\n", | ||
1106 | __func__, ctx->q, chunk, chunk && chunk->chunk_hdr ? | 1102 | __func__, ctx->q, chunk, chunk && chunk->chunk_hdr ? |
1107 | sctp_cname(SCTP_ST_CHUNK(chunk->chunk_hdr->type)) : | 1103 | sctp_cname(SCTP_ST_CHUNK(chunk->chunk_hdr->type)) : |
1108 | "illegal chunk", ntohl(chunk->subh.data_hdr->tsn), | 1104 | "illegal chunk", ntohl(chunk->subh.data_hdr->tsn), |
@@ -1175,8 +1171,7 @@ static void sctp_outq_flush_transports(struct sctp_flush_ctx *ctx) | |||
1175 | } | 1171 | } |
1176 | } | 1172 | } |
1177 | 1173 | ||
1178 | /* | 1174 | /* Try to flush an outqueue. |
1179 | * Try to flush an outqueue. | ||
1180 | * | 1175 | * |
1181 | * Description: Send everything in q which we legally can, subject to | 1176 | * Description: Send everything in q which we legally can, subject to |
1182 | * congestion limitations. | 1177 | * congestion limitations. |
@@ -1196,8 +1191,7 @@ static void sctp_outq_flush(struct sctp_outq *q, int rtx_timeout, gfp_t gfp) | |||
1196 | .gfp = gfp, | 1191 | .gfp = gfp, |
1197 | }; | 1192 | }; |
1198 | 1193 | ||
1199 | /* | 1194 | /* 6.10 Bundling |
1200 | * 6.10 Bundling | ||
1201 | * ... | 1195 | * ... |
1202 | * When bundling control chunks with DATA chunks, an | 1196 | * When bundling control chunks with DATA chunks, an |
1203 | * endpoint MUST place control chunks first in the outbound | 1197 | * endpoint MUST place control chunks first in the outbound |
@@ -1768,7 +1762,7 @@ static int sctp_acked(struct sctp_sackhdr *sack, __u32 tsn) | |||
1768 | if (TSN_lte(tsn, ctsn)) | 1762 | if (TSN_lte(tsn, ctsn)) |
1769 | goto pass; | 1763 | goto pass; |
1770 | 1764 | ||
1771 | /* 3.3.4 Selective Acknowledgement (SACK) (3): | 1765 | /* 3.3.4 Selective Acknowledgment (SACK) (3): |
1772 | * | 1766 | * |
1773 | * Gap Ack Blocks: | 1767 | * Gap Ack Blocks: |
1774 | * These fields contain the Gap Ack Blocks. They are repeated | 1768 | * These fields contain the Gap Ack Blocks. They are repeated |