diff options
author | Jiri Pirko <jiri@mellanox.com> | 2017-08-04 08:28:57 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2017-08-04 14:21:23 -0400 |
commit | 4ebc1e3cfcd8778e2150bdb799b19e85348b8efa (patch) | |
tree | 1f62e37970989aaf7e5ededdd81404d34cb05dd7 /net/sched/cls_basic.c | |
parent | f7ebdff7575c3a5c099c8b1d661b0a65f4c6f10f (diff) |
net: sched: remove unneeded tcf_em_tree_change
Since tcf_em_tree_validate could be always called on a newly created
filter, there is no need for this change function.
Signed-off-by: Jiri Pirko <jiri@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/sched/cls_basic.c')
-rw-r--r-- | net/sched/cls_basic.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/net/sched/cls_basic.c b/net/sched/cls_basic.c index c4fd63a068f9..979cd2683b46 100644 --- a/net/sched/cls_basic.c +++ b/net/sched/cls_basic.c | |||
@@ -130,7 +130,6 @@ static int basic_set_parms(struct net *net, struct tcf_proto *tp, | |||
130 | { | 130 | { |
131 | int err; | 131 | int err; |
132 | struct tcf_exts e; | 132 | struct tcf_exts e; |
133 | struct tcf_ematch_tree t; | ||
134 | 133 | ||
135 | err = tcf_exts_init(&e, TCA_BASIC_ACT, TCA_BASIC_POLICE); | 134 | err = tcf_exts_init(&e, TCA_BASIC_ACT, TCA_BASIC_POLICE); |
136 | if (err < 0) | 135 | if (err < 0) |
@@ -139,7 +138,7 @@ static int basic_set_parms(struct net *net, struct tcf_proto *tp, | |||
139 | if (err < 0) | 138 | if (err < 0) |
140 | goto errout; | 139 | goto errout; |
141 | 140 | ||
142 | err = tcf_em_tree_validate(tp, tb[TCA_BASIC_EMATCHES], &t); | 141 | err = tcf_em_tree_validate(tp, tb[TCA_BASIC_EMATCHES], &f->ematches); |
143 | if (err < 0) | 142 | if (err < 0) |
144 | goto errout; | 143 | goto errout; |
145 | 144 | ||
@@ -149,7 +148,6 @@ static int basic_set_parms(struct net *net, struct tcf_proto *tp, | |||
149 | } | 148 | } |
150 | 149 | ||
151 | tcf_exts_change(tp, &f->exts, &e); | 150 | tcf_exts_change(tp, &f->exts, &e); |
152 | tcf_em_tree_change(tp, &f->ematches, &t); | ||
153 | f->tp = tp; | 151 | f->tp = tp; |
154 | 152 | ||
155 | return 0; | 153 | return 0; |