aboutsummaryrefslogtreecommitdiffstats
path: root/net/rxrpc/ar-ack.c
diff options
context:
space:
mode:
authorDavid Howells <dhowells@redhat.com>2016-03-04 10:53:46 -0500
committerDavid Howells <dhowells@redhat.com>2016-03-04 10:53:46 -0500
commit4c198ad17a7253cc8ef3ff39bfe73d6b5e65ceef (patch)
tree50e0727cfa2de837b9a97400b6988b6a97abd944 /net/rxrpc/ar-ack.c
parent5b8848d14912d5e9974d5d83d71ed6cba2b49345 (diff)
rxrpc: Rename call events to begin RXRPC_CALL_EV_
Rename call event names to begin RXRPC_CALL_EV_ to distinguish them from the flags. Signed-off-by: David Howells <dhowells@redhat.com>
Diffstat (limited to 'net/rxrpc/ar-ack.c')
-rw-r--r--net/rxrpc/ar-ack.c102
1 files changed, 51 insertions, 51 deletions
diff --git a/net/rxrpc/ar-ack.c b/net/rxrpc/ar-ack.c
index 7cb7e45c8bad..9183da740600 100644
--- a/net/rxrpc/ar-ack.c
+++ b/net/rxrpc/ar-ack.c
@@ -161,7 +161,7 @@ cancel_timer:
161 try_to_del_timer_sync(&call->ack_timer); 161 try_to_del_timer_sync(&call->ack_timer);
162 read_lock_bh(&call->state_lock); 162 read_lock_bh(&call->state_lock);
163 if (call->state <= RXRPC_CALL_COMPLETE && 163 if (call->state <= RXRPC_CALL_COMPLETE &&
164 !test_and_set_bit(RXRPC_CALL_ACK, &call->events)) 164 !test_and_set_bit(RXRPC_CALL_EV_ACK, &call->events))
165 rxrpc_queue_call(call); 165 rxrpc_queue_call(call);
166 read_unlock_bh(&call->state_lock); 166 read_unlock_bh(&call->state_lock);
167} 167}
@@ -193,7 +193,7 @@ static void rxrpc_set_resend(struct rxrpc_call *call, u8 resend,
193 193
194 if (resend & 1) { 194 if (resend & 1) {
195 _debug("SET RESEND"); 195 _debug("SET RESEND");
196 set_bit(RXRPC_CALL_RESEND, &call->events); 196 set_bit(RXRPC_CALL_EV_RESEND, &call->events);
197 } 197 }
198 198
199 if (resend & 2) { 199 if (resend & 2) {
@@ -203,7 +203,7 @@ static void rxrpc_set_resend(struct rxrpc_call *call, u8 resend,
203 } else { 203 } else {
204 _debug("KILL RESEND TIMER"); 204 _debug("KILL RESEND TIMER");
205 del_timer_sync(&call->resend_timer); 205 del_timer_sync(&call->resend_timer);
206 clear_bit(RXRPC_CALL_RESEND_TIMER, &call->events); 206 clear_bit(RXRPC_CALL_EV_RESEND_TIMER, &call->events);
207 clear_bit(RXRPC_CALL_RUN_RTIMER, &call->flags); 207 clear_bit(RXRPC_CALL_RUN_RTIMER, &call->flags);
208 } 208 }
209 read_unlock_bh(&call->state_lock); 209 read_unlock_bh(&call->state_lock);
@@ -555,7 +555,7 @@ inserted:
555 if (call->state < RXRPC_CALL_COMPLETE && 555 if (call->state < RXRPC_CALL_COMPLETE &&
556 call->rx_data_post == call->rx_first_oos) { 556 call->rx_data_post == call->rx_first_oos) {
557 _debug("drain rx oos now"); 557 _debug("drain rx oos now");
558 set_bit(RXRPC_CALL_DRAIN_RX_OOS, &call->events); 558 set_bit(RXRPC_CALL_EV_DRAIN_RX_OOS, &call->events);
559 } 559 }
560 read_unlock(&call->state_lock); 560 read_unlock(&call->state_lock);
561 561
@@ -793,7 +793,7 @@ all_acked:
793 793
794 del_timer_sync(&call->resend_timer); 794 del_timer_sync(&call->resend_timer);
795 clear_bit(RXRPC_CALL_RUN_RTIMER, &call->flags); 795 clear_bit(RXRPC_CALL_RUN_RTIMER, &call->flags);
796 clear_bit(RXRPC_CALL_RESEND_TIMER, &call->events); 796 clear_bit(RXRPC_CALL_EV_RESEND_TIMER, &call->events);
797 797
798 if (call->acks_window) 798 if (call->acks_window)
799 rxrpc_zap_tx_window(call); 799 rxrpc_zap_tx_window(call);
@@ -928,17 +928,17 @@ void rxrpc_process_call(struct work_struct *work)
928 iov[0].iov_len = sizeof(hdr); 928 iov[0].iov_len = sizeof(hdr);
929 929
930 /* deal with events of a final nature */ 930 /* deal with events of a final nature */
931 if (test_bit(RXRPC_CALL_RELEASE, &call->events)) { 931 if (test_bit(RXRPC_CALL_EV_RELEASE, &call->events)) {
932 rxrpc_release_call(call); 932 rxrpc_release_call(call);
933 clear_bit(RXRPC_CALL_RELEASE, &call->events); 933 clear_bit(RXRPC_CALL_EV_RELEASE, &call->events);
934 } 934 }
935 935
936 if (test_bit(RXRPC_CALL_RCVD_ERROR, &call->events)) { 936 if (test_bit(RXRPC_CALL_EV_RCVD_ERROR, &call->events)) {
937 int error; 937 int error;
938 938
939 clear_bit(RXRPC_CALL_CONN_ABORT, &call->events); 939 clear_bit(RXRPC_CALL_EV_CONN_ABORT, &call->events);
940 clear_bit(RXRPC_CALL_REJECT_BUSY, &call->events); 940 clear_bit(RXRPC_CALL_EV_REJECT_BUSY, &call->events);
941 clear_bit(RXRPC_CALL_ABORT, &call->events); 941 clear_bit(RXRPC_CALL_EV_ABORT, &call->events);
942 942
943 error = call->conn->trans->peer->net_error; 943 error = call->conn->trans->peer->net_error;
944 _debug("post net error %d", error); 944 _debug("post net error %d", error);
@@ -946,32 +946,32 @@ void rxrpc_process_call(struct work_struct *work)
946 if (rxrpc_post_message(call, RXRPC_SKB_MARK_NET_ERROR, 946 if (rxrpc_post_message(call, RXRPC_SKB_MARK_NET_ERROR,
947 error, true) < 0) 947 error, true) < 0)
948 goto no_mem; 948 goto no_mem;
949 clear_bit(RXRPC_CALL_RCVD_ERROR, &call->events); 949 clear_bit(RXRPC_CALL_EV_RCVD_ERROR, &call->events);
950 goto kill_ACKs; 950 goto kill_ACKs;
951 } 951 }
952 952
953 if (test_bit(RXRPC_CALL_CONN_ABORT, &call->events)) { 953 if (test_bit(RXRPC_CALL_EV_CONN_ABORT, &call->events)) {
954 ASSERTCMP(call->state, >, RXRPC_CALL_COMPLETE); 954 ASSERTCMP(call->state, >, RXRPC_CALL_COMPLETE);
955 955
956 clear_bit(RXRPC_CALL_REJECT_BUSY, &call->events); 956 clear_bit(RXRPC_CALL_EV_REJECT_BUSY, &call->events);
957 clear_bit(RXRPC_CALL_ABORT, &call->events); 957 clear_bit(RXRPC_CALL_EV_ABORT, &call->events);
958 958
959 _debug("post conn abort"); 959 _debug("post conn abort");
960 960
961 if (rxrpc_post_message(call, RXRPC_SKB_MARK_LOCAL_ERROR, 961 if (rxrpc_post_message(call, RXRPC_SKB_MARK_LOCAL_ERROR,
962 call->conn->error, true) < 0) 962 call->conn->error, true) < 0)
963 goto no_mem; 963 goto no_mem;
964 clear_bit(RXRPC_CALL_CONN_ABORT, &call->events); 964 clear_bit(RXRPC_CALL_EV_CONN_ABORT, &call->events);
965 goto kill_ACKs; 965 goto kill_ACKs;
966 } 966 }
967 967
968 if (test_bit(RXRPC_CALL_REJECT_BUSY, &call->events)) { 968 if (test_bit(RXRPC_CALL_EV_REJECT_BUSY, &call->events)) {
969 hdr.type = RXRPC_PACKET_TYPE_BUSY; 969 hdr.type = RXRPC_PACKET_TYPE_BUSY;
970 genbit = RXRPC_CALL_REJECT_BUSY; 970 genbit = RXRPC_CALL_EV_REJECT_BUSY;
971 goto send_message; 971 goto send_message;
972 } 972 }
973 973
974 if (test_bit(RXRPC_CALL_ABORT, &call->events)) { 974 if (test_bit(RXRPC_CALL_EV_ABORT, &call->events)) {
975 ASSERTCMP(call->state, >, RXRPC_CALL_COMPLETE); 975 ASSERTCMP(call->state, >, RXRPC_CALL_COMPLETE);
976 976
977 if (rxrpc_post_message(call, RXRPC_SKB_MARK_LOCAL_ERROR, 977 if (rxrpc_post_message(call, RXRPC_SKB_MARK_LOCAL_ERROR,
@@ -981,12 +981,12 @@ void rxrpc_process_call(struct work_struct *work)
981 data = htonl(call->abort_code); 981 data = htonl(call->abort_code);
982 iov[1].iov_base = &data; 982 iov[1].iov_base = &data;
983 iov[1].iov_len = sizeof(data); 983 iov[1].iov_len = sizeof(data);
984 genbit = RXRPC_CALL_ABORT; 984 genbit = RXRPC_CALL_EV_ABORT;
985 goto send_message; 985 goto send_message;
986 } 986 }
987 987
988 if (test_bit(RXRPC_CALL_ACK_FINAL, &call->events)) { 988 if (test_bit(RXRPC_CALL_EV_ACK_FINAL, &call->events)) {
989 genbit = RXRPC_CALL_ACK_FINAL; 989 genbit = RXRPC_CALL_EV_ACK_FINAL;
990 990
991 ack.bufferSpace = htons(8); 991 ack.bufferSpace = htons(8);
992 ack.maxSkew = 0; 992 ack.maxSkew = 0;
@@ -1012,12 +1012,12 @@ void rxrpc_process_call(struct work_struct *work)
1012 goto send_ACK; 1012 goto send_ACK;
1013 } 1013 }
1014 1014
1015 if (call->events & ((1 << RXRPC_CALL_RCVD_BUSY) | 1015 if (call->events & ((1 << RXRPC_CALL_EV_RCVD_BUSY) |
1016 (1 << RXRPC_CALL_RCVD_ABORT)) 1016 (1 << RXRPC_CALL_EV_RCVD_ABORT))
1017 ) { 1017 ) {
1018 u32 mark; 1018 u32 mark;
1019 1019
1020 if (test_bit(RXRPC_CALL_RCVD_ABORT, &call->events)) 1020 if (test_bit(RXRPC_CALL_EV_RCVD_ABORT, &call->events))
1021 mark = RXRPC_SKB_MARK_REMOTE_ABORT; 1021 mark = RXRPC_SKB_MARK_REMOTE_ABORT;
1022 else 1022 else
1023 mark = RXRPC_SKB_MARK_BUSY; 1023 mark = RXRPC_SKB_MARK_BUSY;
@@ -1027,22 +1027,22 @@ void rxrpc_process_call(struct work_struct *work)
1027 if (rxrpc_post_message(call, mark, ECONNABORTED, true) < 0) 1027 if (rxrpc_post_message(call, mark, ECONNABORTED, true) < 0)
1028 goto no_mem; 1028 goto no_mem;
1029 1029
1030 clear_bit(RXRPC_CALL_RCVD_BUSY, &call->events); 1030 clear_bit(RXRPC_CALL_EV_RCVD_BUSY, &call->events);
1031 clear_bit(RXRPC_CALL_RCVD_ABORT, &call->events); 1031 clear_bit(RXRPC_CALL_EV_RCVD_ABORT, &call->events);
1032 goto kill_ACKs; 1032 goto kill_ACKs;
1033 } 1033 }
1034 1034
1035 if (test_and_clear_bit(RXRPC_CALL_RCVD_ACKALL, &call->events)) { 1035 if (test_and_clear_bit(RXRPC_CALL_EV_RCVD_ACKALL, &call->events)) {
1036 _debug("do implicit ackall"); 1036 _debug("do implicit ackall");
1037 rxrpc_clear_tx_window(call); 1037 rxrpc_clear_tx_window(call);
1038 } 1038 }
1039 1039
1040 if (test_bit(RXRPC_CALL_LIFE_TIMER, &call->events)) { 1040 if (test_bit(RXRPC_CALL_EV_LIFE_TIMER, &call->events)) {
1041 write_lock_bh(&call->state_lock); 1041 write_lock_bh(&call->state_lock);
1042 if (call->state <= RXRPC_CALL_COMPLETE) { 1042 if (call->state <= RXRPC_CALL_COMPLETE) {
1043 call->state = RXRPC_CALL_LOCALLY_ABORTED; 1043 call->state = RXRPC_CALL_LOCALLY_ABORTED;
1044 call->abort_code = RX_CALL_TIMEOUT; 1044 call->abort_code = RX_CALL_TIMEOUT;
1045 set_bit(RXRPC_CALL_ABORT, &call->events); 1045 set_bit(RXRPC_CALL_EV_ABORT, &call->events);
1046 } 1046 }
1047 write_unlock_bh(&call->state_lock); 1047 write_unlock_bh(&call->state_lock);
1048 1048
@@ -1051,7 +1051,7 @@ void rxrpc_process_call(struct work_struct *work)
1051 ETIME, true) < 0) 1051 ETIME, true) < 0)
1052 goto no_mem; 1052 goto no_mem;
1053 1053
1054 clear_bit(RXRPC_CALL_LIFE_TIMER, &call->events); 1054 clear_bit(RXRPC_CALL_EV_LIFE_TIMER, &call->events);
1055 goto kill_ACKs; 1055 goto kill_ACKs;
1056 } 1056 }
1057 1057
@@ -1072,13 +1072,13 @@ void rxrpc_process_call(struct work_struct *work)
1072 } 1072 }
1073 1073
1074 /* handle resending */ 1074 /* handle resending */
1075 if (test_and_clear_bit(RXRPC_CALL_RESEND_TIMER, &call->events)) 1075 if (test_and_clear_bit(RXRPC_CALL_EV_RESEND_TIMER, &call->events))
1076 rxrpc_resend_timer(call); 1076 rxrpc_resend_timer(call);
1077 if (test_and_clear_bit(RXRPC_CALL_RESEND, &call->events)) 1077 if (test_and_clear_bit(RXRPC_CALL_EV_RESEND, &call->events))
1078 rxrpc_resend(call); 1078 rxrpc_resend(call);
1079 1079
1080 /* consider sending an ordinary ACK */ 1080 /* consider sending an ordinary ACK */
1081 if (test_bit(RXRPC_CALL_ACK, &call->events)) { 1081 if (test_bit(RXRPC_CALL_EV_ACK, &call->events)) {
1082 _debug("send ACK: window: %d - %d { %lx }", 1082 _debug("send ACK: window: %d - %d { %lx }",
1083 call->rx_data_eaten, call->ackr_win_top, 1083 call->rx_data_eaten, call->ackr_win_top,
1084 call->ackr_window[0]); 1084 call->ackr_window[0]);
@@ -1086,11 +1086,11 @@ void rxrpc_process_call(struct work_struct *work)
1086 if (call->state > RXRPC_CALL_SERVER_ACK_REQUEST && 1086 if (call->state > RXRPC_CALL_SERVER_ACK_REQUEST &&
1087 call->ackr_reason != RXRPC_ACK_PING_RESPONSE) { 1087 call->ackr_reason != RXRPC_ACK_PING_RESPONSE) {
1088 /* ACK by sending reply DATA packet in this state */ 1088 /* ACK by sending reply DATA packet in this state */
1089 clear_bit(RXRPC_CALL_ACK, &call->events); 1089 clear_bit(RXRPC_CALL_EV_ACK, &call->events);
1090 goto maybe_reschedule; 1090 goto maybe_reschedule;
1091 } 1091 }
1092 1092
1093 genbit = RXRPC_CALL_ACK; 1093 genbit = RXRPC_CALL_EV_ACK;
1094 1094
1095 acks = kzalloc(call->ackr_win_top - call->rx_data_eaten, 1095 acks = kzalloc(call->ackr_win_top - call->rx_data_eaten,
1096 GFP_NOFS); 1096 GFP_NOFS);
@@ -1153,7 +1153,7 @@ void rxrpc_process_call(struct work_struct *work)
1153 1153
1154 /* handle completion of security negotiations on an incoming 1154 /* handle completion of security negotiations on an incoming
1155 * connection */ 1155 * connection */
1156 if (test_and_clear_bit(RXRPC_CALL_SECURED, &call->events)) { 1156 if (test_and_clear_bit(RXRPC_CALL_EV_SECURED, &call->events)) {
1157 _debug("secured"); 1157 _debug("secured");
1158 spin_lock_bh(&call->lock); 1158 spin_lock_bh(&call->lock);
1159 1159
@@ -1161,7 +1161,7 @@ void rxrpc_process_call(struct work_struct *work)
1161 _debug("securing"); 1161 _debug("securing");
1162 write_lock(&call->conn->lock); 1162 write_lock(&call->conn->lock);
1163 if (!test_bit(RXRPC_CALL_RELEASED, &call->flags) && 1163 if (!test_bit(RXRPC_CALL_RELEASED, &call->flags) &&
1164 !test_bit(RXRPC_CALL_RELEASE, &call->events)) { 1164 !test_bit(RXRPC_CALL_EV_RELEASE, &call->events)) {
1165 _debug("not released"); 1165 _debug("not released");
1166 call->state = RXRPC_CALL_SERVER_ACCEPTING; 1166 call->state = RXRPC_CALL_SERVER_ACCEPTING;
1167 list_move_tail(&call->accept_link, 1167 list_move_tail(&call->accept_link,
@@ -1170,39 +1170,39 @@ void rxrpc_process_call(struct work_struct *work)
1170 write_unlock(&call->conn->lock); 1170 write_unlock(&call->conn->lock);
1171 read_lock(&call->state_lock); 1171 read_lock(&call->state_lock);
1172 if (call->state < RXRPC_CALL_COMPLETE) 1172 if (call->state < RXRPC_CALL_COMPLETE)
1173 set_bit(RXRPC_CALL_POST_ACCEPT, &call->events); 1173 set_bit(RXRPC_CALL_EV_POST_ACCEPT, &call->events);
1174 read_unlock(&call->state_lock); 1174 read_unlock(&call->state_lock);
1175 } 1175 }
1176 1176
1177 spin_unlock_bh(&call->lock); 1177 spin_unlock_bh(&call->lock);
1178 if (!test_bit(RXRPC_CALL_POST_ACCEPT, &call->events)) 1178 if (!test_bit(RXRPC_CALL_EV_POST_ACCEPT, &call->events))
1179 goto maybe_reschedule; 1179 goto maybe_reschedule;
1180 } 1180 }
1181 1181
1182 /* post a notification of an acceptable connection to the app */ 1182 /* post a notification of an acceptable connection to the app */
1183 if (test_bit(RXRPC_CALL_POST_ACCEPT, &call->events)) { 1183 if (test_bit(RXRPC_CALL_EV_POST_ACCEPT, &call->events)) {
1184 _debug("post accept"); 1184 _debug("post accept");
1185 if (rxrpc_post_message(call, RXRPC_SKB_MARK_NEW_CALL, 1185 if (rxrpc_post_message(call, RXRPC_SKB_MARK_NEW_CALL,
1186 0, false) < 0) 1186 0, false) < 0)
1187 goto no_mem; 1187 goto no_mem;
1188 clear_bit(RXRPC_CALL_POST_ACCEPT, &call->events); 1188 clear_bit(RXRPC_CALL_EV_POST_ACCEPT, &call->events);
1189 goto maybe_reschedule; 1189 goto maybe_reschedule;
1190 } 1190 }
1191 1191
1192 /* handle incoming call acceptance */ 1192 /* handle incoming call acceptance */
1193 if (test_and_clear_bit(RXRPC_CALL_ACCEPTED, &call->events)) { 1193 if (test_and_clear_bit(RXRPC_CALL_EV_ACCEPTED, &call->events)) {
1194 _debug("accepted"); 1194 _debug("accepted");
1195 ASSERTCMP(call->rx_data_post, ==, 0); 1195 ASSERTCMP(call->rx_data_post, ==, 0);
1196 call->rx_data_post = 1; 1196 call->rx_data_post = 1;
1197 read_lock_bh(&call->state_lock); 1197 read_lock_bh(&call->state_lock);
1198 if (call->state < RXRPC_CALL_COMPLETE) 1198 if (call->state < RXRPC_CALL_COMPLETE)
1199 set_bit(RXRPC_CALL_DRAIN_RX_OOS, &call->events); 1199 set_bit(RXRPC_CALL_EV_DRAIN_RX_OOS, &call->events);
1200 read_unlock_bh(&call->state_lock); 1200 read_unlock_bh(&call->state_lock);
1201 } 1201 }
1202 1202
1203 /* drain the out of sequence received packet queue into the packet Rx 1203 /* drain the out of sequence received packet queue into the packet Rx
1204 * queue */ 1204 * queue */
1205 if (test_and_clear_bit(RXRPC_CALL_DRAIN_RX_OOS, &call->events)) { 1205 if (test_and_clear_bit(RXRPC_CALL_EV_DRAIN_RX_OOS, &call->events)) {
1206 while (call->rx_data_post == call->rx_first_oos) 1206 while (call->rx_data_post == call->rx_first_oos)
1207 if (rxrpc_drain_rx_oos_queue(call) < 0) 1207 if (rxrpc_drain_rx_oos_queue(call) < 0)
1208 break; 1208 break;
@@ -1281,12 +1281,12 @@ send_message_2:
1281 } 1281 }
1282 1282
1283 switch (genbit) { 1283 switch (genbit) {
1284 case RXRPC_CALL_ABORT: 1284 case RXRPC_CALL_EV_ABORT:
1285 clear_bit(genbit, &call->events); 1285 clear_bit(genbit, &call->events);
1286 clear_bit(RXRPC_CALL_RCVD_ABORT, &call->events); 1286 clear_bit(RXRPC_CALL_EV_RCVD_ABORT, &call->events);
1287 goto kill_ACKs; 1287 goto kill_ACKs;
1288 1288
1289 case RXRPC_CALL_ACK_FINAL: 1289 case RXRPC_CALL_EV_ACK_FINAL:
1290 write_lock_bh(&call->state_lock); 1290 write_lock_bh(&call->state_lock);
1291 if (call->state == RXRPC_CALL_CLIENT_FINAL_ACK) 1291 if (call->state == RXRPC_CALL_CLIENT_FINAL_ACK)
1292 call->state = RXRPC_CALL_COMPLETE; 1292 call->state = RXRPC_CALL_COMPLETE;
@@ -1311,9 +1311,9 @@ send_message_2:
1311 1311
1312kill_ACKs: 1312kill_ACKs:
1313 del_timer_sync(&call->ack_timer); 1313 del_timer_sync(&call->ack_timer);
1314 if (test_and_clear_bit(RXRPC_CALL_ACK_FINAL, &call->events)) 1314 if (test_and_clear_bit(RXRPC_CALL_EV_ACK_FINAL, &call->events))
1315 rxrpc_put_call(call); 1315 rxrpc_put_call(call);
1316 clear_bit(RXRPC_CALL_ACK, &call->events); 1316 clear_bit(RXRPC_CALL_EV_ACK, &call->events);
1317 1317
1318maybe_reschedule: 1318maybe_reschedule:
1319 if (call->events || !skb_queue_empty(&call->rx_queue)) { 1319 if (call->events || !skb_queue_empty(&call->rx_queue)) {
@@ -1332,7 +1332,7 @@ maybe_reschedule:
1332 1332
1333 read_lock_bh(&call->state_lock); 1333 read_lock_bh(&call->state_lock);
1334 if (!test_bit(RXRPC_CALL_RELEASED, &call->flags) && 1334 if (!test_bit(RXRPC_CALL_RELEASED, &call->flags) &&
1335 !test_and_set_bit(RXRPC_CALL_RELEASE, &call->events)) 1335 !test_and_set_bit(RXRPC_CALL_EV_RELEASE, &call->events))
1336 rxrpc_queue_call(call); 1336 rxrpc_queue_call(call);
1337 read_unlock_bh(&call->state_lock); 1337 read_unlock_bh(&call->state_lock);
1338 } 1338 }