diff options
author | Nicolas Iooss <nicolas.iooss_linux@m4x.org> | 2016-08-05 16:11:12 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2016-08-08 19:16:21 -0400 |
commit | 6cdaf03f8c23fcbfe7d4fa6876e114193bb6b632 (patch) | |
tree | 956f741fa95545c0ef508a1162227e46e523665a /net/rds | |
parent | d50736a853b8633ed8c9c64a2a1487e6081b739c (diff) |
RDS: add __printf format attribute to error reporting functions
This is helpful to detect at compile-time errors related to format
strings.
Signed-off-by: Nicolas Iooss <nicolas.iooss_linux@m4x.org>
Acked-by: Santosh Shilimkar <santosh.shilimkar@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/rds')
-rw-r--r-- | net/rds/ib.h | 1 | ||||
-rw-r--r-- | net/rds/rds.h | 1 |
2 files changed, 2 insertions, 0 deletions
diff --git a/net/rds/ib.h b/net/rds/ib.h index 046f7508c06b..45ac8e8e58f4 100644 --- a/net/rds/ib.h +++ b/net/rds/ib.h | |||
@@ -333,6 +333,7 @@ void rds_ib_conn_path_shutdown(struct rds_conn_path *cp); | |||
333 | void rds_ib_state_change(struct sock *sk); | 333 | void rds_ib_state_change(struct sock *sk); |
334 | int rds_ib_listen_init(void); | 334 | int rds_ib_listen_init(void); |
335 | void rds_ib_listen_stop(void); | 335 | void rds_ib_listen_stop(void); |
336 | __printf(2, 3) | ||
336 | void __rds_ib_conn_error(struct rds_connection *conn, const char *, ...); | 337 | void __rds_ib_conn_error(struct rds_connection *conn, const char *, ...); |
337 | int rds_ib_cm_handle_connect(struct rdma_cm_id *cm_id, | 338 | int rds_ib_cm_handle_connect(struct rdma_cm_id *cm_id, |
338 | struct rdma_cm_event *event); | 339 | struct rdma_cm_event *event); |
diff --git a/net/rds/rds.h b/net/rds/rds.h index b2d17f0fafa8..fd0bccb2f9f9 100644 --- a/net/rds/rds.h +++ b/net/rds/rds.h | |||
@@ -688,6 +688,7 @@ void __rds_conn_error(struct rds_connection *conn, const char *, ...); | |||
688 | #define rds_conn_error(conn, fmt...) \ | 688 | #define rds_conn_error(conn, fmt...) \ |
689 | __rds_conn_error(conn, KERN_WARNING "RDS: " fmt) | 689 | __rds_conn_error(conn, KERN_WARNING "RDS: " fmt) |
690 | 690 | ||
691 | __printf(2, 3) | ||
691 | void __rds_conn_path_error(struct rds_conn_path *cp, const char *, ...); | 692 | void __rds_conn_path_error(struct rds_conn_path *cp, const char *, ...); |
692 | #define rds_conn_path_error(cp, fmt...) \ | 693 | #define rds_conn_path_error(cp, fmt...) \ |
693 | __rds_conn_path_error(cp, KERN_WARNING "RDS: " fmt) | 694 | __rds_conn_path_error(cp, KERN_WARNING "RDS: " fmt) |