diff options
author | David Ahern <dsahern@gmail.com> | 2017-08-28 18:14:20 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2017-08-28 18:17:29 -0400 |
commit | a8e3bb347d8c32c25830af55466e08979df4e2be (patch) | |
tree | f9e285520f67cb9a7295a20c4da65798e098bb06 /net/ipv6/tcp_ipv6.c | |
parent | cc8737a5fe9051b7fa052b08c57ddb9f539c389a (diff) |
net: Add comment that early_demux can change via sysctl
Twice patches trying to constify inet{6}_protocol have been reverted:
39294c3df2a8 ("Revert "ipv6: constify inet6_protocol structures"") to
revert 3a3a4e3054137 and then 03157937fe0b5 ("Revert "ipv4: make
net_protocol const"") to revert aa8db499ea67.
Add a comment that the structures can not be const because the
early_demux field can change based on a sysctl.
Signed-off-by: David Ahern <dsahern@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ipv6/tcp_ipv6.c')
-rw-r--r-- | net/ipv6/tcp_ipv6.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/net/ipv6/tcp_ipv6.c b/net/ipv6/tcp_ipv6.c index abba3bc2a3d9..38f76d8b231e 100644 --- a/net/ipv6/tcp_ipv6.c +++ b/net/ipv6/tcp_ipv6.c | |||
@@ -1949,6 +1949,9 @@ struct proto tcpv6_prot = { | |||
1949 | .diag_destroy = tcp_abort, | 1949 | .diag_destroy = tcp_abort, |
1950 | }; | 1950 | }; |
1951 | 1951 | ||
1952 | /* thinking of making this const? Don't. | ||
1953 | * early_demux can change based on sysctl. | ||
1954 | */ | ||
1952 | static struct inet6_protocol tcpv6_protocol = { | 1955 | static struct inet6_protocol tcpv6_protocol = { |
1953 | .early_demux = tcp_v6_early_demux, | 1956 | .early_demux = tcp_v6_early_demux, |
1954 | .early_demux_handler = tcp_v6_early_demux, | 1957 | .early_demux_handler = tcp_v6_early_demux, |