diff options
author | Eric Dumazet <edumazet@google.com> | 2018-09-21 11:51:50 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2018-09-21 22:37:59 -0400 |
commit | d3edd06ea8ea9e03de6567fda80b8be57e21a537 (patch) | |
tree | 090196833fede243080048ee8d143b3cc83fecd4 /net/ipv4/tcp_output.c | |
parent | 9799ccb0e984a5c1311b22a212e7ff96e8b736de (diff) |
tcp: provide earliest departure time in skb->tstamp
Switch internal TCP skb->skb_mstamp to skb->skb_mstamp_ns,
from usec units to nsec units.
Do not clear skb->tstamp before entering IP stacks in TX,
so that qdisc or devices can implement pacing based on the
earliest departure time instead of socket sk->sk_pacing_rate
Packets are fed with tcp_wstamp_ns, and following patch
will update tcp_wstamp_ns when both TCP and sch_fq switch to
the earliest departure time mechanism.
Signed-off-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ipv4/tcp_output.c')
-rw-r--r-- | net/ipv4/tcp_output.c | 13 |
1 files changed, 6 insertions, 7 deletions
diff --git a/net/ipv4/tcp_output.c b/net/ipv4/tcp_output.c index 5a8105e84f7c..957f7a0e21c0 100644 --- a/net/ipv4/tcp_output.c +++ b/net/ipv4/tcp_output.c | |||
@@ -1014,7 +1014,7 @@ static void tcp_internal_pacing(struct sock *sk, const struct sk_buff *skb) | |||
1014 | 1014 | ||
1015 | static void tcp_update_skb_after_send(struct tcp_sock *tp, struct sk_buff *skb) | 1015 | static void tcp_update_skb_after_send(struct tcp_sock *tp, struct sk_buff *skb) |
1016 | { | 1016 | { |
1017 | skb->skb_mstamp = tp->tcp_mstamp; | 1017 | skb->skb_mstamp_ns = tp->tcp_wstamp_ns; |
1018 | list_move_tail(&skb->tcp_tsorted_anchor, &tp->tsorted_sent_queue); | 1018 | list_move_tail(&skb->tcp_tsorted_anchor, &tp->tsorted_sent_queue); |
1019 | } | 1019 | } |
1020 | 1020 | ||
@@ -1061,7 +1061,7 @@ static int __tcp_transmit_skb(struct sock *sk, struct sk_buff *skb, | |||
1061 | if (unlikely(!skb)) | 1061 | if (unlikely(!skb)) |
1062 | return -ENOBUFS; | 1062 | return -ENOBUFS; |
1063 | } | 1063 | } |
1064 | skb->skb_mstamp = tp->tcp_mstamp; | 1064 | skb->skb_mstamp_ns = tp->tcp_wstamp_ns; |
1065 | 1065 | ||
1066 | inet = inet_sk(sk); | 1066 | inet = inet_sk(sk); |
1067 | tcb = TCP_SKB_CB(skb); | 1067 | tcb = TCP_SKB_CB(skb); |
@@ -1165,8 +1165,7 @@ static int __tcp_transmit_skb(struct sock *sk, struct sk_buff *skb, | |||
1165 | skb_shinfo(skb)->gso_segs = tcp_skb_pcount(skb); | 1165 | skb_shinfo(skb)->gso_segs = tcp_skb_pcount(skb); |
1166 | skb_shinfo(skb)->gso_size = tcp_skb_mss(skb); | 1166 | skb_shinfo(skb)->gso_size = tcp_skb_mss(skb); |
1167 | 1167 | ||
1168 | /* Our usage of tstamp should remain private */ | 1168 | /* Leave earliest departure time in skb->tstamp (skb->skb_mstamp_ns) */ |
1169 | skb->tstamp = 0; | ||
1170 | 1169 | ||
1171 | /* Cleanup our debris for IP stacks */ | 1170 | /* Cleanup our debris for IP stacks */ |
1172 | memset(skb->cb, 0, max(sizeof(struct inet_skb_parm), | 1171 | memset(skb->cb, 0, max(sizeof(struct inet_skb_parm), |
@@ -3221,10 +3220,10 @@ struct sk_buff *tcp_make_synack(const struct sock *sk, struct dst_entry *dst, | |||
3221 | memset(&opts, 0, sizeof(opts)); | 3220 | memset(&opts, 0, sizeof(opts)); |
3222 | #ifdef CONFIG_SYN_COOKIES | 3221 | #ifdef CONFIG_SYN_COOKIES |
3223 | if (unlikely(req->cookie_ts)) | 3222 | if (unlikely(req->cookie_ts)) |
3224 | skb->skb_mstamp = cookie_init_timestamp(req); | 3223 | skb->skb_mstamp_ns = cookie_init_timestamp(req); |
3225 | else | 3224 | else |
3226 | #endif | 3225 | #endif |
3227 | skb->skb_mstamp = tcp_clock_us(); | 3226 | skb->skb_mstamp_ns = tcp_clock_ns(); |
3228 | 3227 | ||
3229 | #ifdef CONFIG_TCP_MD5SIG | 3228 | #ifdef CONFIG_TCP_MD5SIG |
3230 | rcu_read_lock(); | 3229 | rcu_read_lock(); |
@@ -3440,7 +3439,7 @@ static int tcp_send_syn_data(struct sock *sk, struct sk_buff *syn) | |||
3440 | 3439 | ||
3441 | err = tcp_transmit_skb(sk, syn_data, 1, sk->sk_allocation); | 3440 | err = tcp_transmit_skb(sk, syn_data, 1, sk->sk_allocation); |
3442 | 3441 | ||
3443 | syn->skb_mstamp = syn_data->skb_mstamp; | 3442 | syn->skb_mstamp_ns = syn_data->skb_mstamp_ns; |
3444 | 3443 | ||
3445 | /* Now full SYN+DATA was cloned and sent (or not), | 3444 | /* Now full SYN+DATA was cloned and sent (or not), |
3446 | * remove the SYN from the original skb (syn_data) | 3445 | * remove the SYN from the original skb (syn_data) |