diff options
author | Eric Dumazet <edumazet@google.com> | 2015-07-08 17:28:30 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2015-07-09 18:12:20 -0400 |
commit | dbe7faa4045ea83a37b691b12bb02a8f86c2d2e9 (patch) | |
tree | 4c7b8918dbe2c4caacd120deffe2e8a8235d9561 /net/ipv4/tcp_minisocks.c | |
parent | fc01538f9fb75572c969ca9988176ffc2a8741d6 (diff) |
inet: inet_twsk_deschedule factorization
inet_twsk_deschedule() calls are followed by inet_twsk_put().
Only particular case is in inet_twsk_purge() but there is no point
to defer the inet_twsk_put() after re-enabling BH.
Lets rename inet_twsk_deschedule() to inet_twsk_deschedule_put()
and move the inet_twsk_put() inside.
Signed-off-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ipv4/tcp_minisocks.c')
-rw-r--r-- | net/ipv4/tcp_minisocks.c | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/net/ipv4/tcp_minisocks.c b/net/ipv4/tcp_minisocks.c index 4bc00cb79e60..6d8795b066ac 100644 --- a/net/ipv4/tcp_minisocks.c +++ b/net/ipv4/tcp_minisocks.c | |||
@@ -147,8 +147,7 @@ tcp_timewait_state_process(struct inet_timewait_sock *tw, struct sk_buff *skb, | |||
147 | if (!th->fin || | 147 | if (!th->fin || |
148 | TCP_SKB_CB(skb)->end_seq != tcptw->tw_rcv_nxt + 1) { | 148 | TCP_SKB_CB(skb)->end_seq != tcptw->tw_rcv_nxt + 1) { |
149 | kill_with_rst: | 149 | kill_with_rst: |
150 | inet_twsk_deschedule(tw); | 150 | inet_twsk_deschedule_put(tw); |
151 | inet_twsk_put(tw); | ||
152 | return TCP_TW_RST; | 151 | return TCP_TW_RST; |
153 | } | 152 | } |
154 | 153 | ||
@@ -198,8 +197,7 @@ kill_with_rst: | |||
198 | */ | 197 | */ |
199 | if (sysctl_tcp_rfc1337 == 0) { | 198 | if (sysctl_tcp_rfc1337 == 0) { |
200 | kill: | 199 | kill: |
201 | inet_twsk_deschedule(tw); | 200 | inet_twsk_deschedule_put(tw); |
202 | inet_twsk_put(tw); | ||
203 | return TCP_TW_SUCCESS; | 201 | return TCP_TW_SUCCESS; |
204 | } | 202 | } |
205 | } | 203 | } |