aboutsummaryrefslogtreecommitdiffstats
path: root/net/ipv4/tcp_ipv4.c
diff options
context:
space:
mode:
authorYafang Shao <laoar.shao@gmail.com>2018-09-01 08:21:05 -0400
committerDavid S. Miller <davem@davemloft.net>2018-09-02 19:12:41 -0400
commit743e481580b4646cde416dd549e2ecb0f16848d2 (patch)
tree00361e1606ba513c5f8059cc13d9312abd2d7b50 /net/ipv4/tcp_ipv4.c
parent1914104fc6f84c1fa9947f3f304a34816d1fabee (diff)
tcp: remove useless add operation when init sysctl_max_tw_buckets
cp_hashinfo.ehash_mask is always an odd number, which is set in function alloc_large_system_hash(). See bellow, if (_hash_mask) *_hash_mask = (1 << log2qty) - 1; <<< always odd number Hence the local variable 'cnt' is a even number, as a result of that it is no difference to do the incrementation here. Signed-off-by: Yafang Shao <laoar.shao@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ipv4/tcp_ipv4.c')
-rw-r--r--net/ipv4/tcp_ipv4.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/net/ipv4/tcp_ipv4.c b/net/ipv4/tcp_ipv4.c
index 44c09eddbb78..09547ef9c4c6 100644
--- a/net/ipv4/tcp_ipv4.c
+++ b/net/ipv4/tcp_ipv4.c
@@ -2549,7 +2549,7 @@ static int __net_init tcp_sk_init(struct net *net)
2549 net->ipv4.sysctl_tcp_tw_reuse = 2; 2549 net->ipv4.sysctl_tcp_tw_reuse = 2;
2550 2550
2551 cnt = tcp_hashinfo.ehash_mask + 1; 2551 cnt = tcp_hashinfo.ehash_mask + 1;
2552 net->ipv4.tcp_death_row.sysctl_max_tw_buckets = (cnt + 1) / 2; 2552 net->ipv4.tcp_death_row.sysctl_max_tw_buckets = cnt / 2;
2553 net->ipv4.tcp_death_row.hashinfo = &tcp_hashinfo; 2553 net->ipv4.tcp_death_row.hashinfo = &tcp_hashinfo;
2554 2554
2555 net->ipv4.sysctl_max_syn_backlog = max(128, cnt / 256); 2555 net->ipv4.sysctl_max_syn_backlog = max(128, cnt / 256);