diff options
author | Gustavo A. R. Silva <garsilva@embeddedor.com> | 2017-10-16 16:48:55 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2017-10-18 09:10:29 -0400 |
commit | fcfd6dfab97006d44c7db5d6c908eac383af6649 (patch) | |
tree | 4d959ed7720b96140dbdb04bcf94d571e73865d8 /net/ipv4/tcp_input.c | |
parent | 86e58cce939cefd806105922e4a0840e9a04a88f (diff) |
ipv4: mark expected switch fall-throughs
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.
Notice that in some cases I placed the "fall through" comment
on its own line, which is what GCC is expecting to find.
Addresses-Coverity-ID: 115108
Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ipv4/tcp_input.c')
-rw-r--r-- | net/ipv4/tcp_input.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/net/ipv4/tcp_input.c b/net/ipv4/tcp_input.c index d0682ce2a5d6..b2390bfdc68f 100644 --- a/net/ipv4/tcp_input.c +++ b/net/ipv4/tcp_input.c | |||
@@ -2885,6 +2885,7 @@ static void tcp_fastretrans_alert(struct sock *sk, const int acked, | |||
2885 | (*ack_flag & FLAG_LOST_RETRANS))) | 2885 | (*ack_flag & FLAG_LOST_RETRANS))) |
2886 | return; | 2886 | return; |
2887 | /* Change state if cwnd is undone or retransmits are lost */ | 2887 | /* Change state if cwnd is undone or retransmits are lost */ |
2888 | /* fall through */ | ||
2888 | default: | 2889 | default: |
2889 | if (tcp_is_reno(tp)) { | 2890 | if (tcp_is_reno(tp)) { |
2890 | if (flag & FLAG_SND_UNA_ADVANCED) | 2891 | if (flag & FLAG_SND_UNA_ADVANCED) |
@@ -6044,6 +6045,7 @@ int tcp_rcv_state_process(struct sock *sk, struct sk_buff *skb) | |||
6044 | case TCP_LAST_ACK: | 6045 | case TCP_LAST_ACK: |
6045 | if (!before(TCP_SKB_CB(skb)->seq, tp->rcv_nxt)) | 6046 | if (!before(TCP_SKB_CB(skb)->seq, tp->rcv_nxt)) |
6046 | break; | 6047 | break; |
6048 | /* fall through */ | ||
6047 | case TCP_FIN_WAIT1: | 6049 | case TCP_FIN_WAIT1: |
6048 | case TCP_FIN_WAIT2: | 6050 | case TCP_FIN_WAIT2: |
6049 | /* RFC 793 says to queue data in these states, | 6051 | /* RFC 793 says to queue data in these states, |