aboutsummaryrefslogtreecommitdiffstats
path: root/net/ipv4/tcp_input.c
diff options
context:
space:
mode:
authorWei Wang <weiwan@google.com>2018-07-31 20:46:24 -0400
committerDavid S. Miller <davem@davemloft.net>2018-08-01 12:56:10 -0400
commit7ec65372ca534217b53fd208500cf7aac223a383 (patch)
tree5debcce08aca141b24d1a5c9875d73cae07f3394 /net/ipv4/tcp_input.c
parent7e10b6554ff2ce7f86d5d3eec3af5db8db482caa (diff)
tcp: add stat of data packet reordering events
Introduce a new TCP stats to record the number of reordering events seen and expose it in both tcp_info (TCP_INFO) and opt_stats (SOF_TIMESTAMPING_OPT_STATS). Application can use this stats to track the frequency of the reordering events in addition to the existing reordering stats which tracks the magnitude of the latest reordering event. Note: this new stats tracks reordering events triggered by ACKs, which could often be fewer than the actual number of packets being delivered out-of-order. Signed-off-by: Wei Wang <weiwan@google.com> Signed-off-by: Eric Dumazet <edumazet@google.com> Acked-by: Neal Cardwell <ncardwell@google.com> Acked-by: Soheil Hassas Yeganeh <soheil@google.com> Acked-by: Yuchung Cheng <ycheng@google.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ipv4/tcp_input.c')
-rw-r--r--net/ipv4/tcp_input.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/net/ipv4/tcp_input.c b/net/ipv4/tcp_input.c
index fbc85ff7d71d..3d6156f07a8d 100644
--- a/net/ipv4/tcp_input.c
+++ b/net/ipv4/tcp_input.c
@@ -906,8 +906,8 @@ static void tcp_check_sack_reordering(struct sock *sk, const u32 low_seq,
906 sock_net(sk)->ipv4.sysctl_tcp_max_reordering); 906 sock_net(sk)->ipv4.sysctl_tcp_max_reordering);
907 } 907 }
908 908
909 tp->rack.reord = 1;
910 /* This exciting event is worth to be remembered. 8) */ 909 /* This exciting event is worth to be remembered. 8) */
910 tp->reord_seen++;
911 NET_INC_STATS(sock_net(sk), 911 NET_INC_STATS(sock_net(sk),
912 ts ? LINUX_MIB_TCPTSREORDER : LINUX_MIB_TCPSACKREORDER); 912 ts ? LINUX_MIB_TCPTSREORDER : LINUX_MIB_TCPSACKREORDER);
913} 913}
@@ -1871,6 +1871,7 @@ static void tcp_check_reno_reordering(struct sock *sk, const int addend)
1871 1871
1872 tp->reordering = min_t(u32, tp->packets_out + addend, 1872 tp->reordering = min_t(u32, tp->packets_out + addend,
1873 sock_net(sk)->ipv4.sysctl_tcp_max_reordering); 1873 sock_net(sk)->ipv4.sysctl_tcp_max_reordering);
1874 tp->reord_seen++;
1874 NET_INC_STATS(sock_net(sk), LINUX_MIB_TCPRENOREORDER); 1875 NET_INC_STATS(sock_net(sk), LINUX_MIB_TCPRENOREORDER);
1875} 1876}
1876 1877