diff options
author | Eric Dumazet <edumazet@google.com> | 2017-04-25 13:15:36 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2017-04-26 14:44:38 -0400 |
commit | 1317a9d69f5fa0f5417237772f55a4aac49f7921 (patch) | |
tree | 798e9bb5976cbe479e84fb3b2410e07b6626b462 /net/ipv4/tcp_input.c | |
parent | efab8f85826afbbfe4b0ca9208e006aabbd2df3a (diff) |
tcp: do not pass timestamp to tcp_fastretrans_alert()
Not used anymore now tp->tcp_mstamp holds the information.
This is needed to remove sack_state.ack_time in a following patch.
Signed-off-by: Eric Dumazet <edumazet@google.com>
Acked-by: Soheil Hassas Yeganeh <soheil@google.com>
Acked-by: Neal Cardwell <ncardwell@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ipv4/tcp_input.c')
-rw-r--r-- | net/ipv4/tcp_input.c | 12 |
1 files changed, 4 insertions, 8 deletions
diff --git a/net/ipv4/tcp_input.c b/net/ipv4/tcp_input.c index 99b0d65de169..68094aa8cfb2 100644 --- a/net/ipv4/tcp_input.c +++ b/net/ipv4/tcp_input.c | |||
@@ -2787,8 +2787,7 @@ static void tcp_rack_identify_loss(struct sock *sk, int *ack_flag) | |||
2787 | * tcp_xmit_retransmit_queue(). | 2787 | * tcp_xmit_retransmit_queue(). |
2788 | */ | 2788 | */ |
2789 | static void tcp_fastretrans_alert(struct sock *sk, const int acked, | 2789 | static void tcp_fastretrans_alert(struct sock *sk, const int acked, |
2790 | bool is_dupack, int *ack_flag, int *rexmit, | 2790 | bool is_dupack, int *ack_flag, int *rexmit) |
2791 | const struct skb_mstamp *ack_time) | ||
2792 | { | 2791 | { |
2793 | struct inet_connection_sock *icsk = inet_csk(sk); | 2792 | struct inet_connection_sock *icsk = inet_csk(sk); |
2794 | struct tcp_sock *tp = tcp_sk(sk); | 2793 | struct tcp_sock *tp = tcp_sk(sk); |
@@ -3646,8 +3645,7 @@ static int tcp_ack(struct sock *sk, const struct sk_buff *skb, int flag) | |||
3646 | 3645 | ||
3647 | if (tcp_ack_is_dubious(sk, flag)) { | 3646 | if (tcp_ack_is_dubious(sk, flag)) { |
3648 | is_dupack = !(flag & (FLAG_SND_UNA_ADVANCED | FLAG_NOT_DUP)); | 3647 | is_dupack = !(flag & (FLAG_SND_UNA_ADVANCED | FLAG_NOT_DUP)); |
3649 | tcp_fastretrans_alert(sk, acked, is_dupack, &flag, &rexmit, | 3648 | tcp_fastretrans_alert(sk, acked, is_dupack, &flag, &rexmit); |
3650 | &sack_state.ack_time); | ||
3651 | } | 3649 | } |
3652 | if (tp->tlp_high_seq) | 3650 | if (tp->tlp_high_seq) |
3653 | tcp_process_tlp_ack(sk, ack, flag); | 3651 | tcp_process_tlp_ack(sk, ack, flag); |
@@ -3668,8 +3666,7 @@ static int tcp_ack(struct sock *sk, const struct sk_buff *skb, int flag) | |||
3668 | no_queue: | 3666 | no_queue: |
3669 | /* If data was DSACKed, see if we can undo a cwnd reduction. */ | 3667 | /* If data was DSACKed, see if we can undo a cwnd reduction. */ |
3670 | if (flag & FLAG_DSACKING_ACK) | 3668 | if (flag & FLAG_DSACKING_ACK) |
3671 | tcp_fastretrans_alert(sk, acked, is_dupack, &flag, &rexmit, | 3669 | tcp_fastretrans_alert(sk, acked, is_dupack, &flag, &rexmit); |
3672 | &sack_state.ack_time); | ||
3673 | /* If this ack opens up a zero window, clear backoff. It was | 3670 | /* If this ack opens up a zero window, clear backoff. It was |
3674 | * being used to time the probes, and is probably far higher than | 3671 | * being used to time the probes, and is probably far higher than |
3675 | * it needs to be for normal retransmission. | 3672 | * it needs to be for normal retransmission. |
@@ -3693,8 +3690,7 @@ old_ack: | |||
3693 | skb_mstamp_get(&sack_state.ack_time); | 3690 | skb_mstamp_get(&sack_state.ack_time); |
3694 | flag |= tcp_sacktag_write_queue(sk, skb, prior_snd_una, | 3691 | flag |= tcp_sacktag_write_queue(sk, skb, prior_snd_una, |
3695 | &sack_state); | 3692 | &sack_state); |
3696 | tcp_fastretrans_alert(sk, acked, is_dupack, &flag, &rexmit, | 3693 | tcp_fastretrans_alert(sk, acked, is_dupack, &flag, &rexmit); |
3697 | &sack_state.ack_time); | ||
3698 | tcp_xmit_recovery(sk, rexmit); | 3694 | tcp_xmit_recovery(sk, rexmit); |
3699 | } | 3695 | } |
3700 | 3696 | ||