diff options
| author | Vivien Didelot <vivien.didelot@savoirfairelinux.com> | 2017-11-03 19:05:26 -0400 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2017-11-05 08:31:39 -0500 |
| commit | 0eefe2c1730020c6207bc9695fd466e558301dbb (patch) | |
| tree | f0265eff96eadade960cb7fd4d27f7863f538d18 /net/dsa | |
| parent | 6da2a940ac6a0680e50b3aaf945e409cea03c346 (diff) | |
net: dsa: get tree before parsing ports
We will need a reference to the dsa_switch_tree when parsing a CPU port,
so fetch it right after parsing the member and before parsing ports.
Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/dsa')
| -rw-r--r-- | net/dsa/dsa2.c | 18 |
1 files changed, 10 insertions, 8 deletions
diff --git a/net/dsa/dsa2.c b/net/dsa/dsa2.c index 5b6a3dad8015..5918fbddb0ab 100644 --- a/net/dsa/dsa2.c +++ b/net/dsa/dsa2.c | |||
| @@ -751,18 +751,10 @@ static int _dsa_register_switch(struct dsa_switch *ds) | |||
| 751 | err = dsa_parse_member_dn(np, &tree, &index); | 751 | err = dsa_parse_member_dn(np, &tree, &index); |
| 752 | if (err) | 752 | if (err) |
| 753 | return err; | 753 | return err; |
| 754 | |||
| 755 | err = dsa_parse_ports_of(np, ds); | ||
| 756 | if (err) | ||
| 757 | return err; | ||
| 758 | } else { | 754 | } else { |
| 759 | err = dsa_parse_member(pdata, &tree, &index); | 755 | err = dsa_parse_member(pdata, &tree, &index); |
| 760 | if (err) | 756 | if (err) |
| 761 | return err; | 757 | return err; |
| 762 | |||
| 763 | err = dsa_parse_ports(pdata, ds); | ||
| 764 | if (err) | ||
| 765 | return err; | ||
| 766 | } | 758 | } |
| 767 | 759 | ||
| 768 | dst = dsa_tree_touch(tree); | 760 | dst = dsa_tree_touch(tree); |
| @@ -773,6 +765,16 @@ static int _dsa_register_switch(struct dsa_switch *ds) | |||
| 773 | ds->index = index; | 765 | ds->index = index; |
| 774 | ds->cd = pdata; | 766 | ds->cd = pdata; |
| 775 | 767 | ||
| 768 | if (np) { | ||
| 769 | err = dsa_parse_ports_of(np, ds); | ||
| 770 | if (err) | ||
| 771 | return err; | ||
| 772 | } else { | ||
| 773 | err = dsa_parse_ports(pdata, ds); | ||
| 774 | if (err) | ||
| 775 | return err; | ||
| 776 | } | ||
| 777 | |||
| 776 | /* Initialize the routing table */ | 778 | /* Initialize the routing table */ |
| 777 | for (i = 0; i < DSA_MAX_SWITCHES; ++i) | 779 | for (i = 0; i < DSA_MAX_SWITCHES; ++i) |
| 778 | ds->rtable[i] = DSA_RTABLE_NONE; | 780 | ds->rtable[i] = DSA_RTABLE_NONE; |
