Update setapp/getapp prototypes in dcbnl_rtnl_ops to return int instead of u8

v2: fixed issue with checking return of dcbnl_rtnl_ops->getapp()

Signed-off-by: Anish Bhatt <anish@chelsio.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

1 files changed, 7 insertions, 1 deletions

diff --git a/net/dcb/dcbnl.c b/net/dcb/dcbnl.c
index f8b98d89c285..c34af7a1d2d4 100644
--- a/net/dcb/dcbnl.c
+++ b/net/dcb/dcbnl.c
@@ -471,7 +471,11 @@ static int dcbnl_getapp(struct net_device *netdev, struct nlmsghdr *nlh,
         id = nla_get_u16(app_tb[DCB_APP_ATTR_ID]);
 
         if (netdev->dcbnl_ops->getapp) {
-                up = netdev->dcbnl_ops->getapp(netdev, idtype, id);
+                ret = netdev->dcbnl_ops->getapp(netdev, idtype, id);
+                if (ret < 0)
+                        return ret;
+                else
+                        up = ret;
         } else {
                 struct dcb_app app = {
                                         .selector = idtype,
@@ -538,6 +542,8 @@ static int dcbnl_setapp(struct net_device *netdev, struct nlmsghdr *nlh,
 
         if (netdev->dcbnl_ops->setapp) {
                 ret = netdev->dcbnl_ops->setapp(netdev, idtype, id, up);
+                if (ret < 0)
+                        return ret;
         } else {
                 struct dcb_app app;
                 app.selector = idtype;