diff options
author | Eric Dumazet <edumazet@google.com> | 2015-05-26 11:55:28 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2015-05-26 23:21:29 -0400 |
commit | d6a4e26afb80c049e7f94e1b7b506dcda61eee88 (patch) | |
tree | 809c23a70ad711aa0f1456068cb73f9c1ac11da9 /net/core/sock.c | |
parent | 095dc8e0c3686d586a01a50abc3e1bb9ac633054 (diff) |
tcp: tcp_tso_autosize() minimum is one packet
By making sure sk->sk_gso_max_segs minimal value is one,
and sysctl_tcp_min_tso_segs minimal value is one as well,
tcp_tso_autosize() will return a non zero value.
We can then revert 843925f33fcc293d80acf2c5c8a78adf3344d49b
("tcp: Do not apply TSO segment limit to non-TSO packets")
and save few cpu cycles in fast path.
Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Neal Cardwell <ncardwell@google.com>
Cc: Herbert Xu <herbert@gondor.apana.org.au>
Acked-by: Neal Cardwell <ncardwell@google.com>
Acked-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/core/sock.c')
-rw-r--r-- | net/core/sock.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/net/core/sock.c b/net/core/sock.c index 29124fcdc42a..e72633c346b1 100644 --- a/net/core/sock.c +++ b/net/core/sock.c | |||
@@ -1581,6 +1581,8 @@ EXPORT_SYMBOL_GPL(sk_clone_lock); | |||
1581 | 1581 | ||
1582 | void sk_setup_caps(struct sock *sk, struct dst_entry *dst) | 1582 | void sk_setup_caps(struct sock *sk, struct dst_entry *dst) |
1583 | { | 1583 | { |
1584 | u32 max_segs = 1; | ||
1585 | |||
1584 | __sk_dst_set(sk, dst); | 1586 | __sk_dst_set(sk, dst); |
1585 | sk->sk_route_caps = dst->dev->features; | 1587 | sk->sk_route_caps = dst->dev->features; |
1586 | if (sk->sk_route_caps & NETIF_F_GSO) | 1588 | if (sk->sk_route_caps & NETIF_F_GSO) |
@@ -1592,9 +1594,10 @@ void sk_setup_caps(struct sock *sk, struct dst_entry *dst) | |||
1592 | } else { | 1594 | } else { |
1593 | sk->sk_route_caps |= NETIF_F_SG | NETIF_F_HW_CSUM; | 1595 | sk->sk_route_caps |= NETIF_F_SG | NETIF_F_HW_CSUM; |
1594 | sk->sk_gso_max_size = dst->dev->gso_max_size; | 1596 | sk->sk_gso_max_size = dst->dev->gso_max_size; |
1595 | sk->sk_gso_max_segs = dst->dev->gso_max_segs; | 1597 | max_segs = max_t(u32, dst->dev->gso_max_segs, 1); |
1596 | } | 1598 | } |
1597 | } | 1599 | } |
1600 | sk->sk_gso_max_segs = max_segs; | ||
1598 | } | 1601 | } |
1599 | EXPORT_SYMBOL_GPL(sk_setup_caps); | 1602 | EXPORT_SYMBOL_GPL(sk_setup_caps); |
1600 | 1603 | ||