aboutsummaryrefslogtreecommitdiffstats
path: root/net/core/dev.c
diff options
context:
space:
mode:
authorPaolo Abeni <pabeni@redhat.com>2019-03-20 06:02:04 -0400
committerDavid S. Miller <davem@davemloft.net>2019-03-20 14:18:54 -0400
commit4bd97d51a5e602ea1fbdab8c2d653513dea17115 (patch)
treee805f47e700c42818aa07cb32d8fa7d2f0922920 /net/core/dev.c
parent0b963ef20c5624c4cc6c4ef408b301a24b26b96b (diff)
net: dev: rename queue selection helpers.
With the following patches, we are going to use __netdev_pick_tx() in many modules. Rename it to netdev_pick_tx(), to make it clear is a public API. Also rename the existing netdev_pick_tx() to netdev_core_pick_tx(), to avoid name clashes. Suggested-by: Eric Dumazet <edumazet@google.com> Suggested-by: David Miller <davem@davemloft.net> Signed-off-by: Paolo Abeni <pabeni@redhat.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/core/dev.c')
-rw-r--r--net/core/dev.c18
1 files changed, 9 insertions, 9 deletions
diff --git a/net/core/dev.c b/net/core/dev.c
index 2b67f2aa59dd..5dd3e3f7dd12 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -3704,8 +3704,8 @@ u16 dev_pick_tx_cpu_id(struct net_device *dev, struct sk_buff *skb,
3704} 3704}
3705EXPORT_SYMBOL(dev_pick_tx_cpu_id); 3705EXPORT_SYMBOL(dev_pick_tx_cpu_id);
3706 3706
3707static u16 __netdev_pick_tx(struct net_device *dev, struct sk_buff *skb, 3707static u16 netdev_pick_tx(struct net_device *dev, struct sk_buff *skb,
3708 struct net_device *sb_dev) 3708 struct net_device *sb_dev)
3709{ 3709{
3710 struct sock *sk = skb->sk; 3710 struct sock *sk = skb->sk;
3711 int queue_index = sk_tx_queue_get(sk); 3711 int queue_index = sk_tx_queue_get(sk);
@@ -3730,9 +3730,9 @@ static u16 __netdev_pick_tx(struct net_device *dev, struct sk_buff *skb,
3730 return queue_index; 3730 return queue_index;
3731} 3731}
3732 3732
3733struct netdev_queue *netdev_pick_tx(struct net_device *dev, 3733struct netdev_queue *netdev_core_pick_tx(struct net_device *dev,
3734 struct sk_buff *skb, 3734 struct sk_buff *skb,
3735 struct net_device *sb_dev) 3735 struct net_device *sb_dev)
3736{ 3736{
3737 int queue_index = 0; 3737 int queue_index = 0;
3738 3738
@@ -3748,9 +3748,9 @@ struct netdev_queue *netdev_pick_tx(struct net_device *dev,
3748 3748
3749 if (ops->ndo_select_queue) 3749 if (ops->ndo_select_queue)
3750 queue_index = ops->ndo_select_queue(dev, skb, sb_dev, 3750 queue_index = ops->ndo_select_queue(dev, skb, sb_dev,
3751 __netdev_pick_tx); 3751 netdev_pick_tx);
3752 else 3752 else
3753 queue_index = __netdev_pick_tx(dev, skb, sb_dev); 3753 queue_index = netdev_pick_tx(dev, skb, sb_dev);
3754 3754
3755 queue_index = netdev_cap_txqueue(dev, queue_index); 3755 queue_index = netdev_cap_txqueue(dev, queue_index);
3756 } 3756 }
@@ -3824,7 +3824,7 @@ static int __dev_queue_xmit(struct sk_buff *skb, struct net_device *sb_dev)
3824 else 3824 else
3825 skb_dst_force(skb); 3825 skb_dst_force(skb);
3826 3826
3827 txq = netdev_pick_tx(dev, skb, sb_dev); 3827 txq = netdev_core_pick_tx(dev, skb, sb_dev);
3828 q = rcu_dereference_bh(txq->qdisc); 3828 q = rcu_dereference_bh(txq->qdisc);
3829 3829
3830 trace_net_dev_queue(skb); 3830 trace_net_dev_queue(skb);
@@ -4429,7 +4429,7 @@ void generic_xdp_tx(struct sk_buff *skb, struct bpf_prog *xdp_prog)
4429 bool free_skb = true; 4429 bool free_skb = true;
4430 int cpu, rc; 4430 int cpu, rc;
4431 4431
4432 txq = netdev_pick_tx(dev, skb, NULL); 4432 txq = netdev_core_pick_tx(dev, skb, NULL);
4433 cpu = smp_processor_id(); 4433 cpu = smp_processor_id();
4434 HARD_TX_LOCK(dev, txq, cpu); 4434 HARD_TX_LOCK(dev, txq, cpu);
4435 if (!netif_xmit_stopped(txq)) { 4435 if (!netif_xmit_stopped(txq)) {