diff options
| author | Jaganath Kanakkassery <jaganath.k.os@gmail.com> | 2017-10-25 01:28:48 -0400 |
|---|---|---|
| committer | Marcel Holtmann <marcel@holtmann.org> | 2017-10-29 09:07:10 -0400 |
| commit | f17d858ed0a48270db4368d8cf370e3839ee6f4f (patch) | |
| tree | 975b67fd9b1bf35c27320b25f11b8fa508d69a12 /net/bluetooth/hci_request.h | |
| parent | 858ff38af77fc660092e82474ecc6ac135ed29fe (diff) | |
Bluetooth: Fix potential memory leak
If command is added to req then it should be freed in case if
hdev is down or HCI_ADVERTISING flag is set.
This introduces a helper in hci_request to purge the cmd_q
to make cmd_q internal to hci_request which is used to fix
the leak.
This also replace accessing of cmd_q in hci_conn with the
new helper.
Signed-off-by: Jaganath Kanakkassery <jaganathx.kanakkassery@intel.com>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
Diffstat (limited to 'net/bluetooth/hci_request.h')
| -rw-r--r-- | net/bluetooth/hci_request.h | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/net/bluetooth/hci_request.h b/net/bluetooth/hci_request.h index dde77bd59f91..702beb140d9f 100644 --- a/net/bluetooth/hci_request.h +++ b/net/bluetooth/hci_request.h | |||
| @@ -36,6 +36,7 @@ struct hci_request { | |||
| 36 | }; | 36 | }; |
| 37 | 37 | ||
| 38 | void hci_req_init(struct hci_request *req, struct hci_dev *hdev); | 38 | void hci_req_init(struct hci_request *req, struct hci_dev *hdev); |
| 39 | void hci_req_purge(struct hci_request *req); | ||
| 39 | int hci_req_run(struct hci_request *req, hci_req_complete_t complete); | 40 | int hci_req_run(struct hci_request *req, hci_req_complete_t complete); |
| 40 | int hci_req_run_skb(struct hci_request *req, hci_req_complete_skb_t complete); | 41 | int hci_req_run_skb(struct hci_request *req, hci_req_complete_skb_t complete); |
| 41 | void hci_req_add(struct hci_request *req, u16 opcode, u32 plen, | 42 | void hci_req_add(struct hci_request *req, u16 opcode, u32 plen, |