aboutsummaryrefslogtreecommitdiffstats
path: root/mm/vmstat.c
diff options
context:
space:
mode:
authorGreg Kroah-Hartman <gregkh@linuxfoundation.org>2019-03-05 18:46:09 -0500
committerLinus Torvalds <torvalds@linux-foundation.org>2019-03-06 00:07:17 -0500
commitd9f7979c92f7b34469c1ca5d1f3add6681fd567c (patch)
treead8b342028e101065d752fe1fe18199766e289e3 /mm/vmstat.c
parent0ee930e6cafa048c1925893d0ca89918b2814f2c (diff)
mm: no need to check return value of debugfs_create functions
When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this. Link: http://lkml.kernel.org/r/20190122152151.16139-14-gregkh@linuxfoundation.org Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: Michal Hocko <mhocko@suse.com> Cc: Vlastimil Babka <vbabka@suse.cz> Cc: David Rientjes <rientjes@google.com> Cc: Laura Abbott <labbott@redhat.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'mm/vmstat.c')
-rw-r--r--mm/vmstat.c15
1 files changed, 4 insertions, 11 deletions
diff --git a/mm/vmstat.c b/mm/vmstat.c
index 83b30edc2f7f..36b56f858f0f 100644
--- a/mm/vmstat.c
+++ b/mm/vmstat.c
@@ -2121,21 +2121,14 @@ static int __init extfrag_debug_init(void)
2121 struct dentry *extfrag_debug_root; 2121 struct dentry *extfrag_debug_root;
2122 2122
2123 extfrag_debug_root = debugfs_create_dir("extfrag", NULL); 2123 extfrag_debug_root = debugfs_create_dir("extfrag", NULL);
2124 if (!extfrag_debug_root)
2125 return -ENOMEM;
2126 2124
2127 if (!debugfs_create_file("unusable_index", 0444, 2125 debugfs_create_file("unusable_index", 0444, extfrag_debug_root, NULL,
2128 extfrag_debug_root, NULL, &unusable_file_ops)) 2126 &unusable_file_ops);
2129 goto fail;
2130 2127
2131 if (!debugfs_create_file("extfrag_index", 0444, 2128 debugfs_create_file("extfrag_index", 0444, extfrag_debug_root, NULL,
2132 extfrag_debug_root, NULL, &extfrag_file_ops)) 2129 &extfrag_file_ops);
2133 goto fail;
2134 2130
2135 return 0; 2131 return 0;
2136fail:
2137 debugfs_remove_recursive(extfrag_debug_root);
2138 return -ENOMEM;
2139} 2132}
2140 2133
2141module_init(extfrag_debug_init); 2134module_init(extfrag_debug_init);