aboutsummaryrefslogtreecommitdiffstats
path: root/mm/page_alloc.c
diff options
context:
space:
mode:
authorGreg Kroah-Hartman <gregkh@linuxfoundation.org>2019-03-05 18:46:09 -0500
committerLinus Torvalds <torvalds@linux-foundation.org>2019-03-06 00:07:17 -0500
commitd9f7979c92f7b34469c1ca5d1f3add6681fd567c (patch)
treead8b342028e101065d752fe1fe18199766e289e3 /mm/page_alloc.c
parent0ee930e6cafa048c1925893d0ca89918b2814f2c (diff)
mm: no need to check return value of debugfs_create functions
When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this. Link: http://lkml.kernel.org/r/20190122152151.16139-14-gregkh@linuxfoundation.org Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: Michal Hocko <mhocko@suse.com> Cc: Vlastimil Babka <vbabka@suse.cz> Cc: David Rientjes <rientjes@google.com> Cc: Laura Abbott <labbott@redhat.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'mm/page_alloc.c')
-rw-r--r--mm/page_alloc.c22
1 files changed, 6 insertions, 16 deletions
diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index 09bf2c5f8b4b..9be9a22ebe35 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -3230,24 +3230,14 @@ static int __init fail_page_alloc_debugfs(void)
3230 3230
3231 dir = fault_create_debugfs_attr("fail_page_alloc", NULL, 3231 dir = fault_create_debugfs_attr("fail_page_alloc", NULL,
3232 &fail_page_alloc.attr); 3232 &fail_page_alloc.attr);
3233 if (IS_ERR(dir))
3234 return PTR_ERR(dir);
3235
3236 if (!debugfs_create_bool("ignore-gfp-wait", mode, dir,
3237 &fail_page_alloc.ignore_gfp_reclaim))
3238 goto fail;
3239 if (!debugfs_create_bool("ignore-gfp-highmem", mode, dir,
3240 &fail_page_alloc.ignore_gfp_highmem))
3241 goto fail;
3242 if (!debugfs_create_u32("min-order", mode, dir,
3243 &fail_page_alloc.min_order))
3244 goto fail;
3245 3233
3246 return 0; 3234 debugfs_create_bool("ignore-gfp-wait", mode, dir,
3247fail: 3235 &fail_page_alloc.ignore_gfp_reclaim);
3248 debugfs_remove_recursive(dir); 3236 debugfs_create_bool("ignore-gfp-highmem", mode, dir,
3237 &fail_page_alloc.ignore_gfp_highmem);
3238 debugfs_create_u32("min-order", mode, dir, &fail_page_alloc.min_order);
3249 3239
3250 return -ENOMEM; 3240 return 0;
3251} 3241}
3252 3242
3253late_initcall(fail_page_alloc_debugfs); 3243late_initcall(fail_page_alloc_debugfs);