diff options
author | Jens Axboe <axboe@kernel.dk> | 2017-09-28 13:28:02 -0400 |
---|---|---|
committer | Jens Axboe <axboe@kernel.dk> | 2017-10-03 10:38:17 -0400 |
commit | 0ab29fd0accf6e5b6ef5dbe2e0335da6687ce60c (patch) | |
tree | f76ff2360a128f87ff4bc4e76efe65a2d88738b8 /mm/page-writeback.c | |
parent | 595043e5f9ef1d8263bd9fda215cade489227491 (diff) |
writeback: pass in '0' for nr_pages writeback in laptop mode
Laptop mode really wants to writeback the number of dirty
pages and inodes. Instead of calculating this in the caller,
just pass in 0 and let wakeup_flusher_threads() handle it.
Use the new wakeup_flusher_threads_bdi() instead of rolling
our own.
Acked-by: Johannes Weiner <hannes@cmpxchg.org>
Tested-by: Chris Mason <clm@fb.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Reviewed-by: Jan Kara <jack@suse.cz>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'mm/page-writeback.c')
-rw-r--r-- | mm/page-writeback.c | 17 |
1 files changed, 1 insertions, 16 deletions
diff --git a/mm/page-writeback.c b/mm/page-writeback.c index dede53355123..8d1fc593bce8 100644 --- a/mm/page-writeback.c +++ b/mm/page-writeback.c | |||
@@ -1980,23 +1980,8 @@ int dirty_writeback_centisecs_handler(struct ctl_table *table, int write, | |||
1980 | void laptop_mode_timer_fn(unsigned long data) | 1980 | void laptop_mode_timer_fn(unsigned long data) |
1981 | { | 1981 | { |
1982 | struct request_queue *q = (struct request_queue *)data; | 1982 | struct request_queue *q = (struct request_queue *)data; |
1983 | int nr_pages = global_node_page_state(NR_FILE_DIRTY) + | ||
1984 | global_node_page_state(NR_UNSTABLE_NFS); | ||
1985 | struct bdi_writeback *wb; | ||
1986 | 1983 | ||
1987 | /* | 1984 | wakeup_flusher_threads_bdi(q->backing_dev_info, WB_REASON_LAPTOP_TIMER); |
1988 | * We want to write everything out, not just down to the dirty | ||
1989 | * threshold | ||
1990 | */ | ||
1991 | if (!bdi_has_dirty_io(q->backing_dev_info)) | ||
1992 | return; | ||
1993 | |||
1994 | rcu_read_lock(); | ||
1995 | list_for_each_entry_rcu(wb, &q->backing_dev_info->wb_list, bdi_node) | ||
1996 | if (wb_has_dirty_io(wb)) | ||
1997 | wb_start_writeback(wb, nr_pages, | ||
1998 | WB_REASON_LAPTOP_TIMER); | ||
1999 | rcu_read_unlock(); | ||
2000 | } | 1985 | } |
2001 | 1986 | ||
2002 | /* | 1987 | /* |