aboutsummaryrefslogtreecommitdiffstats
path: root/mm/memcontrol.c
diff options
context:
space:
mode:
authorVladimir Davydov <vdavydov@virtuozzo.com>2016-01-14 18:18:15 -0500
committerLinus Torvalds <torvalds@linux-foundation.org>2016-01-14 19:00:49 -0500
commit230e9fc2860450fbb1f33bdcf9093d92d7d91f5b (patch)
treed0cb29d821cc5c3ca49066f0ca5d9149066b157f /mm/memcontrol.c
parenta9bb7e620efdfd29b6d1c238041173e411670996 (diff)
slab: add SLAB_ACCOUNT flag
Currently, if we want to account all objects of a particular kmem cache, we have to pass __GFP_ACCOUNT to each kmem_cache_alloc call, which is inconvenient. This patch introduces SLAB_ACCOUNT flag which if passed to kmem_cache_create will force accounting for every allocation from this cache even if __GFP_ACCOUNT is not passed. This patch does not make any of the existing caches use this flag - it will be done later in the series. Note, a cache with SLAB_ACCOUNT cannot be merged with a cache w/o SLAB_ACCOUNT, because merged caches share the same kmem_cache struct and hence cannot have different sets of SLAB_* flags. Thus using this flag will probably reduce the number of merged slabs even if kmem accounting is not used (only compiled in). Signed-off-by: Vladimir Davydov <vdavydov@virtuozzo.com> Suggested-by: Tejun Heo <tj@kernel.org> Acked-by: Johannes Weiner <hannes@cmpxchg.org> Acked-by: Michal Hocko <mhocko@suse.com> Cc: Greg Thelen <gthelen@google.com> Cc: Christoph Lameter <cl@linux.com> Cc: Pekka Enberg <penberg@kernel.org> Cc: David Rientjes <rientjes@google.com> Cc: Joonsoo Kim <iamjoonsoo.kim@lge.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'mm/memcontrol.c')
-rw-r--r--mm/memcontrol.c8
1 files changed, 7 insertions, 1 deletions
diff --git a/mm/memcontrol.c b/mm/memcontrol.c
index 14cb1db4c52b..4bd6c4513393 100644
--- a/mm/memcontrol.c
+++ b/mm/memcontrol.c
@@ -2356,7 +2356,7 @@ static void memcg_schedule_kmem_cache_create(struct mem_cgroup *memcg,
2356 * Can't be called in interrupt context or from kernel threads. 2356 * Can't be called in interrupt context or from kernel threads.
2357 * This function needs to be called with rcu_read_lock() held. 2357 * This function needs to be called with rcu_read_lock() held.
2358 */ 2358 */
2359struct kmem_cache *__memcg_kmem_get_cache(struct kmem_cache *cachep) 2359struct kmem_cache *__memcg_kmem_get_cache(struct kmem_cache *cachep, gfp_t gfp)
2360{ 2360{
2361 struct mem_cgroup *memcg; 2361 struct mem_cgroup *memcg;
2362 struct kmem_cache *memcg_cachep; 2362 struct kmem_cache *memcg_cachep;
@@ -2364,6 +2364,12 @@ struct kmem_cache *__memcg_kmem_get_cache(struct kmem_cache *cachep)
2364 2364
2365 VM_BUG_ON(!is_root_cache(cachep)); 2365 VM_BUG_ON(!is_root_cache(cachep));
2366 2366
2367 if (cachep->flags & SLAB_ACCOUNT)
2368 gfp |= __GFP_ACCOUNT;
2369
2370 if (!(gfp & __GFP_ACCOUNT))
2371 return cachep;
2372
2367 if (current->memcg_kmem_skip_account) 2373 if (current->memcg_kmem_skip_account)
2368 return cachep; 2374 return cachep;
2369 2375