diff options
author | Dan Carpenter <dan.carpenter@oracle.com> | 2015-09-21 12:21:51 -0400 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2015-10-04 23:49:54 -0400 |
commit | 1f35d04a02a652f14566f875aef3a6f2af4cb77b (patch) | |
tree | d4de9f8e5f4aa03b14f4a02905126673b8279f98 /lib | |
parent | a785ce9c90bc7d73b5cae4388641b310948509cb (diff) |
devres: fix a for loop bounds check
The iomap[] array has PCIM_IOMAP_MAX (6) elements and not
DEVICE_COUNT_RESOURCE (16). This bug was found using a static checker.
It may be that the "if (!(mask & (1 << i)))" check means we never
actually go past the end of the array in real life.
Fixes: ec04b075843d ('iomap: implement pcim_iounmap_regions()')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Tejun Heo <tj@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'lib')
-rw-r--r-- | lib/devres.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/lib/devres.c b/lib/devres.c index f13a2468ff39..8c85672639d3 100644 --- a/lib/devres.c +++ b/lib/devres.c | |||
@@ -418,7 +418,7 @@ void pcim_iounmap_regions(struct pci_dev *pdev, int mask) | |||
418 | if (!iomap) | 418 | if (!iomap) |
419 | return; | 419 | return; |
420 | 420 | ||
421 | for (i = 0; i < DEVICE_COUNT_RESOURCE; i++) { | 421 | for (i = 0; i < PCIM_IOMAP_MAX; i++) { |
422 | if (!(mask & (1 << i))) | 422 | if (!(mask & (1 << i))) |
423 | continue; | 423 | continue; |
424 | 424 | ||