diff options
author | Al Viro <viro@zeniv.linux.org.uk> | 2017-06-29 21:39:54 -0400 |
---|---|---|
committer | Al Viro <viro@zeniv.linux.org.uk> | 2017-06-29 22:21:20 -0400 |
commit | 9c5f6908de03a4f52ba7364b11fcd6116225480c (patch) | |
tree | 9512430004d33389622c6535c2097a96b1b15c93 /lib/usercopy.c | |
parent | 2ea659a9ef488125eb46da6eb571de5eae5c43f6 (diff) |
copy_{from,to}_user(): move kasan checks and might_fault() out-of-line
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Diffstat (limited to 'lib/usercopy.c')
-rw-r--r-- | lib/usercopy.c | 10 |
1 files changed, 8 insertions, 2 deletions
diff --git a/lib/usercopy.c b/lib/usercopy.c index 1b6010a3beb8..f5d9f08ee032 100644 --- a/lib/usercopy.c +++ b/lib/usercopy.c | |||
@@ -6,8 +6,11 @@ | |||
6 | unsigned long _copy_from_user(void *to, const void __user *from, unsigned long n) | 6 | unsigned long _copy_from_user(void *to, const void __user *from, unsigned long n) |
7 | { | 7 | { |
8 | unsigned long res = n; | 8 | unsigned long res = n; |
9 | if (likely(access_ok(VERIFY_READ, from, n))) | 9 | might_fault(); |
10 | if (likely(access_ok(VERIFY_READ, from, n))) { | ||
11 | kasan_check_write(to, n); | ||
10 | res = raw_copy_from_user(to, from, n); | 12 | res = raw_copy_from_user(to, from, n); |
13 | } | ||
11 | if (unlikely(res)) | 14 | if (unlikely(res)) |
12 | memset(to + (n - res), 0, res); | 15 | memset(to + (n - res), 0, res); |
13 | return res; | 16 | return res; |
@@ -18,8 +21,11 @@ EXPORT_SYMBOL(_copy_from_user); | |||
18 | #ifndef INLINE_COPY_TO_USER | 21 | #ifndef INLINE_COPY_TO_USER |
19 | unsigned long _copy_to_user(void *to, const void __user *from, unsigned long n) | 22 | unsigned long _copy_to_user(void *to, const void __user *from, unsigned long n) |
20 | { | 23 | { |
21 | if (likely(access_ok(VERIFY_WRITE, to, n))) | 24 | might_fault(); |
25 | if (likely(access_ok(VERIFY_WRITE, to, n))) { | ||
26 | kasan_check_read(from, n); | ||
22 | n = raw_copy_to_user(to, from, n); | 27 | n = raw_copy_to_user(to, from, n); |
28 | } | ||
23 | return n; | 29 | return n; |
24 | } | 30 | } |
25 | EXPORT_SYMBOL(_copy_to_user); | 31 | EXPORT_SYMBOL(_copy_to_user); |