diff options
author | Solganik Alexander <sashas@lightbitslabs.com> | 2016-10-30 04:35:15 -0400 |
---|---|---|
committer | Sagi Grimberg <sagi@grimberg.me> | 2016-12-06 03:17:03 -0500 |
commit | e4fcf07cca6a3b6c4be00df16f08be894325eaa3 (patch) | |
tree | fe89e5c2ba76c318026e6b708bc73060f9c4902f /lib/parser.c | |
parent | f3116d8f1e110a5eeaac94f5d1c490e9e466a223 (diff) |
nvmet: Fix possible infinite loop triggered on hot namespace removal
When removing a namespace we delete it from the subsystem namespaces
list with list_del_init which allows us to know if it is enabled or
not.
The problem is that list_del_init initialize the list next and does
not respect the RCU list-traversal we do on the IO path for locating
a namespace. Instead we need to use list_del_rcu which is allowed to
run concurrently with the _rcu list-traversal primitives (keeps list
next intact) and guarantees concurrent nvmet_find_naespace forward
progress.
By changing that, we cannot rely on ns->dev_link for knowing if the
namspace is enabled, so add enabled indicator entry to nvmet_ns for
that.
Signed-off-by: Sagi Grimberg <sagi@grimberg.me>
Signed-off-by: Solganik Alexander <sashas@lightbitslabs.com>
Cc: <stable@vger.kernel.org> # v4.8+
Diffstat (limited to 'lib/parser.c')
0 files changed, 0 insertions, 0 deletions