aboutsummaryrefslogtreecommitdiffstats
path: root/kernel
diff options
context:
space:
mode:
authorJoe Perches <joe@perches.com>2016-03-22 17:28:09 -0400
committerLinus Torvalds <torvalds@linux-foundation.org>2016-03-22 18:36:02 -0400
commita395d6a7e3d6e3d1d316376db0c4c8b5d2995930 (patch)
treec6c980f8b63fb4159f116b498759984b2a7767a0 /kernel
parent20d7a35bc8be06dd1350de0454b0e24cca1d4354 (diff)
kernel/...: convert pr_warning to pr_warn
Use the more common logging method with the eventual goal of removing pr_warning altogether. Miscellanea: - Realign arguments - Coalesce formats - Add missing space between a few coalesced formats Signed-off-by: Joe Perches <joe@perches.com> Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> [kernel/power/suspend.c] Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'kernel')
-rw-r--r--kernel/irq/manage.c4
-rw-r--r--kernel/power/suspend.c3
-rw-r--r--kernel/time/tick-sched.c8
-rw-r--r--kernel/trace/blktrace.c4
-rw-r--r--kernel/trace/ftrace.c7
-rw-r--r--kernel/trace/trace.c40
-rw-r--r--kernel/trace/trace_functions_graph.c6
-rw-r--r--kernel/trace/trace_kprobe.c27
-rw-r--r--kernel/trace/trace_mmiotrace.c2
-rw-r--r--kernel/trace/trace_probe.c4
-rw-r--r--kernel/trace/trace_stat.c3
-rw-r--r--kernel/trace/trace_uprobe.c2
-rw-r--r--kernel/tracepoint.c2
13 files changed, 52 insertions, 60 deletions
diff --git a/kernel/irq/manage.c b/kernel/irq/manage.c
index 64731e84c982..cc1cc641d653 100644
--- a/kernel/irq/manage.c
+++ b/kernel/irq/manage.c
@@ -1322,8 +1322,8 @@ __setup_irq(unsigned int irq, struct irq_desc *desc, struct irqaction *new)
1322 1322
1323 if (nmsk != omsk) 1323 if (nmsk != omsk)
1324 /* hope the handler works with current trigger mode */ 1324 /* hope the handler works with current trigger mode */
1325 pr_warning("irq %d uses trigger mode %u; requested %u\n", 1325 pr_warn("irq %d uses trigger mode %u; requested %u\n",
1326 irq, nmsk, omsk); 1326 irq, nmsk, omsk);
1327 } 1327 }
1328 1328
1329 *old_ptr = new; 1329 *old_ptr = new;
diff --git a/kernel/power/suspend.c b/kernel/power/suspend.c
index 230a77225e2e..5b70d64b871e 100644
--- a/kernel/power/suspend.c
+++ b/kernel/power/suspend.c
@@ -473,8 +473,7 @@ static int enter_state(suspend_state_t state)
473 if (state == PM_SUSPEND_FREEZE) { 473 if (state == PM_SUSPEND_FREEZE) {
474#ifdef CONFIG_PM_DEBUG 474#ifdef CONFIG_PM_DEBUG
475 if (pm_test_level != TEST_NONE && pm_test_level <= TEST_CPUS) { 475 if (pm_test_level != TEST_NONE && pm_test_level <= TEST_CPUS) {
476 pr_warning("PM: Unsupported test mode for suspend to idle," 476 pr_warn("PM: Unsupported test mode for suspend to idle, please choose none/freezer/devices/platform.\n");
477 "please choose none/freezer/devices/platform.\n");
478 return -EAGAIN; 477 return -EAGAIN;
479 } 478 }
480#endif 479#endif
diff --git a/kernel/time/tick-sched.c b/kernel/time/tick-sched.c
index 195fe7d2caad..084b79f5917e 100644
--- a/kernel/time/tick-sched.c
+++ b/kernel/time/tick-sched.c
@@ -378,7 +378,7 @@ static int __init tick_nohz_full_setup(char *str)
378{ 378{
379 alloc_bootmem_cpumask_var(&tick_nohz_full_mask); 379 alloc_bootmem_cpumask_var(&tick_nohz_full_mask);
380 if (cpulist_parse(str, tick_nohz_full_mask) < 0) { 380 if (cpulist_parse(str, tick_nohz_full_mask) < 0) {
381 pr_warning("NOHZ: Incorrect nohz_full cpumask\n"); 381 pr_warn("NO_HZ: Incorrect nohz_full cpumask\n");
382 free_bootmem_cpumask_var(tick_nohz_full_mask); 382 free_bootmem_cpumask_var(tick_nohz_full_mask);
383 return 1; 383 return 1;
384 } 384 }
@@ -446,8 +446,7 @@ void __init tick_nohz_init(void)
446 * interrupts to avoid circular dependency on the tick 446 * interrupts to avoid circular dependency on the tick
447 */ 447 */
448 if (!arch_irq_work_has_interrupt()) { 448 if (!arch_irq_work_has_interrupt()) {
449 pr_warning("NO_HZ: Can't run full dynticks because arch doesn't " 449 pr_warn("NO_HZ: Can't run full dynticks because arch doesn't support irq work self-IPIs\n");
450 "support irq work self-IPIs\n");
451 cpumask_clear(tick_nohz_full_mask); 450 cpumask_clear(tick_nohz_full_mask);
452 cpumask_copy(housekeeping_mask, cpu_possible_mask); 451 cpumask_copy(housekeeping_mask, cpu_possible_mask);
453 tick_nohz_full_running = false; 452 tick_nohz_full_running = false;
@@ -457,7 +456,8 @@ void __init tick_nohz_init(void)
457 cpu = smp_processor_id(); 456 cpu = smp_processor_id();
458 457
459 if (cpumask_test_cpu(cpu, tick_nohz_full_mask)) { 458 if (cpumask_test_cpu(cpu, tick_nohz_full_mask)) {
460 pr_warning("NO_HZ: Clearing %d from nohz_full range for timekeeping\n", cpu); 459 pr_warn("NO_HZ: Clearing %d from nohz_full range for timekeeping\n",
460 cpu);
461 cpumask_clear_cpu(cpu, tick_nohz_full_mask); 461 cpumask_clear_cpu(cpu, tick_nohz_full_mask);
462 } 462 }
463 463
diff --git a/kernel/trace/blktrace.c b/kernel/trace/blktrace.c
index 2aeb6ffc0a1e..f94e7a21f52d 100644
--- a/kernel/trace/blktrace.c
+++ b/kernel/trace/blktrace.c
@@ -1437,12 +1437,12 @@ static struct trace_event trace_blk_event = {
1437static int __init init_blk_tracer(void) 1437static int __init init_blk_tracer(void)
1438{ 1438{
1439 if (!register_trace_event(&trace_blk_event)) { 1439 if (!register_trace_event(&trace_blk_event)) {
1440 pr_warning("Warning: could not register block events\n"); 1440 pr_warn("Warning: could not register block events\n");
1441 return 1; 1441 return 1;
1442 } 1442 }
1443 1443
1444 if (register_tracer(&blk_tracer) != 0) { 1444 if (register_tracer(&blk_tracer) != 0) {
1445 pr_warning("Warning: could not register the block tracer\n"); 1445 pr_warn("Warning: could not register the block tracer\n");
1446 unregister_trace_event(&trace_blk_event); 1446 unregister_trace_event(&trace_blk_event);
1447 return 1; 1447 return 1;
1448 } 1448 }
diff --git a/kernel/trace/ftrace.c b/kernel/trace/ftrace.c
index 57a6eea84694..2ece9f1a3e5a 100644
--- a/kernel/trace/ftrace.c
+++ b/kernel/trace/ftrace.c
@@ -1058,8 +1058,7 @@ static __init void ftrace_profile_tracefs(struct dentry *d_tracer)
1058 entry = tracefs_create_file("function_profile_enabled", 0644, 1058 entry = tracefs_create_file("function_profile_enabled", 0644,
1059 d_tracer, NULL, &ftrace_profile_fops); 1059 d_tracer, NULL, &ftrace_profile_fops);
1060 if (!entry) 1060 if (!entry)
1061 pr_warning("Could not create tracefs " 1061 pr_warn("Could not create tracefs 'function_profile_enabled' entry\n");
1062 "'function_profile_enabled' entry\n");
1063} 1062}
1064 1063
1065#else /* CONFIG_FUNCTION_PROFILER */ 1064#else /* CONFIG_FUNCTION_PROFILER */
@@ -2314,8 +2313,8 @@ unsigned long ftrace_get_addr_curr(struct dyn_ftrace *rec)
2314 if (rec->flags & FTRACE_FL_TRAMP_EN) { 2313 if (rec->flags & FTRACE_FL_TRAMP_EN) {
2315 ops = ftrace_find_tramp_ops_curr(rec); 2314 ops = ftrace_find_tramp_ops_curr(rec);
2316 if (FTRACE_WARN_ON(!ops)) { 2315 if (FTRACE_WARN_ON(!ops)) {
2317 pr_warning("Bad trampoline accounting at: %p (%pS)\n", 2316 pr_warn("Bad trampoline accounting at: %p (%pS)\n",
2318 (void *)rec->ip, (void *)rec->ip); 2317 (void *)rec->ip, (void *)rec->ip);
2319 /* Ftrace is shutting down, return anything */ 2318 /* Ftrace is shutting down, return anything */
2320 return (unsigned long)FTRACE_ADDR; 2319 return (unsigned long)FTRACE_ADDR;
2321 } 2320 }
diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
index d9293402ee68..032b388bea66 100644
--- a/kernel/trace/trace.c
+++ b/kernel/trace/trace.c
@@ -2071,20 +2071,20 @@ void trace_printk_init_buffers(void)
2071 2071
2072 /* trace_printk() is for debug use only. Don't use it in production. */ 2072 /* trace_printk() is for debug use only. Don't use it in production. */
2073 2073
2074 pr_warning("\n"); 2074 pr_warn("\n");
2075 pr_warning("**********************************************************\n"); 2075 pr_warn("**********************************************************\n");
2076 pr_warning("** NOTICE NOTICE NOTICE NOTICE NOTICE NOTICE NOTICE **\n"); 2076 pr_warn("** NOTICE NOTICE NOTICE NOTICE NOTICE NOTICE NOTICE **\n");
2077 pr_warning("** **\n"); 2077 pr_warn("** **\n");
2078 pr_warning("** trace_printk() being used. Allocating extra memory. **\n"); 2078 pr_warn("** trace_printk() being used. Allocating extra memory. **\n");
2079 pr_warning("** **\n"); 2079 pr_warn("** **\n");
2080 pr_warning("** This means that this is a DEBUG kernel and it is **\n"); 2080 pr_warn("** This means that this is a DEBUG kernel and it is **\n");
2081 pr_warning("** unsafe for production use. **\n"); 2081 pr_warn("** unsafe for production use. **\n");
2082 pr_warning("** **\n"); 2082 pr_warn("** **\n");
2083 pr_warning("** If you see this message and you are not debugging **\n"); 2083 pr_warn("** If you see this message and you are not debugging **\n");
2084 pr_warning("** the kernel, report this immediately to your vendor! **\n"); 2084 pr_warn("** the kernel, report this immediately to your vendor! **\n");
2085 pr_warning("** **\n"); 2085 pr_warn("** **\n");
2086 pr_warning("** NOTICE NOTICE NOTICE NOTICE NOTICE NOTICE NOTICE **\n"); 2086 pr_warn("** NOTICE NOTICE NOTICE NOTICE NOTICE NOTICE NOTICE **\n");
2087 pr_warning("**********************************************************\n"); 2087 pr_warn("**********************************************************\n");
2088 2088
2089 /* Expand the buffers to set size */ 2089 /* Expand the buffers to set size */
2090 tracing_update_buffers(); 2090 tracing_update_buffers();
@@ -4101,7 +4101,7 @@ trace_insert_enum_map_file(struct module *mod, struct trace_enum_map **start,
4101 */ 4101 */
4102 map_array = kmalloc(sizeof(*map_array) * (len + 2), GFP_KERNEL); 4102 map_array = kmalloc(sizeof(*map_array) * (len + 2), GFP_KERNEL);
4103 if (!map_array) { 4103 if (!map_array) {
4104 pr_warning("Unable to allocate trace enum mapping\n"); 4104 pr_warn("Unable to allocate trace enum mapping\n");
4105 return; 4105 return;
4106 } 4106 }
4107 4107
@@ -6131,7 +6131,7 @@ tracing_init_tracefs_percpu(struct trace_array *tr, long cpu)
6131 snprintf(cpu_dir, 30, "cpu%ld", cpu); 6131 snprintf(cpu_dir, 30, "cpu%ld", cpu);
6132 d_cpu = tracefs_create_dir(cpu_dir, d_percpu); 6132 d_cpu = tracefs_create_dir(cpu_dir, d_percpu);
6133 if (!d_cpu) { 6133 if (!d_cpu) {
6134 pr_warning("Could not create tracefs '%s' entry\n", cpu_dir); 6134 pr_warn("Could not create tracefs '%s' entry\n", cpu_dir);
6135 return; 6135 return;
6136 } 6136 }
6137 6137
@@ -6318,7 +6318,7 @@ struct dentry *trace_create_file(const char *name,
6318 6318
6319 ret = tracefs_create_file(name, mode, parent, data, fops); 6319 ret = tracefs_create_file(name, mode, parent, data, fops);
6320 if (!ret) 6320 if (!ret)
6321 pr_warning("Could not create tracefs '%s' entry\n", name); 6321 pr_warn("Could not create tracefs '%s' entry\n", name);
6322 6322
6323 return ret; 6323 return ret;
6324} 6324}
@@ -6337,7 +6337,7 @@ static struct dentry *trace_options_init_dentry(struct trace_array *tr)
6337 6337
6338 tr->options = tracefs_create_dir("options", d_tracer); 6338 tr->options = tracefs_create_dir("options", d_tracer);
6339 if (!tr->options) { 6339 if (!tr->options) {
6340 pr_warning("Could not create tracefs directory 'options'\n"); 6340 pr_warn("Could not create tracefs directory 'options'\n");
6341 return NULL; 6341 return NULL;
6342 } 6342 }
6343 6343
@@ -7248,8 +7248,8 @@ __init static int tracer_alloc_buffers(void)
7248 if (trace_boot_clock) { 7248 if (trace_boot_clock) {
7249 ret = tracing_set_clock(&global_trace, trace_boot_clock); 7249 ret = tracing_set_clock(&global_trace, trace_boot_clock);
7250 if (ret < 0) 7250 if (ret < 0)
7251 pr_warning("Trace clock %s not defined, going back to default\n", 7251 pr_warn("Trace clock %s not defined, going back to default\n",
7252 trace_boot_clock); 7252 trace_boot_clock);
7253 } 7253 }
7254 7254
7255 /* 7255 /*
diff --git a/kernel/trace/trace_functions_graph.c b/kernel/trace/trace_functions_graph.c
index a663cbb84107..91d6a63a2ea7 100644
--- a/kernel/trace/trace_functions_graph.c
+++ b/kernel/trace/trace_functions_graph.c
@@ -1350,7 +1350,7 @@ void graph_trace_open(struct trace_iterator *iter)
1350 out_err_free: 1350 out_err_free:
1351 kfree(data); 1351 kfree(data);
1352 out_err: 1352 out_err:
1353 pr_warning("function graph tracer: not enough memory\n"); 1353 pr_warn("function graph tracer: not enough memory\n");
1354} 1354}
1355 1355
1356void graph_trace_close(struct trace_iterator *iter) 1356void graph_trace_close(struct trace_iterator *iter)
@@ -1468,12 +1468,12 @@ static __init int init_graph_trace(void)
1468 max_bytes_for_cpu = snprintf(NULL, 0, "%d", nr_cpu_ids - 1); 1468 max_bytes_for_cpu = snprintf(NULL, 0, "%d", nr_cpu_ids - 1);
1469 1469
1470 if (!register_trace_event(&graph_trace_entry_event)) { 1470 if (!register_trace_event(&graph_trace_entry_event)) {
1471 pr_warning("Warning: could not register graph trace events\n"); 1471 pr_warn("Warning: could not register graph trace events\n");
1472 return 1; 1472 return 1;
1473 } 1473 }
1474 1474
1475 if (!register_trace_event(&graph_trace_ret_event)) { 1475 if (!register_trace_event(&graph_trace_ret_event)) {
1476 pr_warning("Warning: could not register graph trace events\n"); 1476 pr_warn("Warning: could not register graph trace events\n");
1477 return 1; 1477 return 1;
1478 } 1478 }
1479 1479
diff --git a/kernel/trace/trace_kprobe.c b/kernel/trace/trace_kprobe.c
index 21b81a41dae5..919e0ddd8fcc 100644
--- a/kernel/trace/trace_kprobe.c
+++ b/kernel/trace/trace_kprobe.c
@@ -459,16 +459,14 @@ static int __register_trace_kprobe(struct trace_kprobe *tk)
459 if (ret == 0) 459 if (ret == 0)
460 tk->tp.flags |= TP_FLAG_REGISTERED; 460 tk->tp.flags |= TP_FLAG_REGISTERED;
461 else { 461 else {
462 pr_warning("Could not insert probe at %s+%lu: %d\n", 462 pr_warn("Could not insert probe at %s+%lu: %d\n",
463 trace_kprobe_symbol(tk), trace_kprobe_offset(tk), ret); 463 trace_kprobe_symbol(tk), trace_kprobe_offset(tk), ret);
464 if (ret == -ENOENT && trace_kprobe_is_on_module(tk)) { 464 if (ret == -ENOENT && trace_kprobe_is_on_module(tk)) {
465 pr_warning("This probe might be able to register after" 465 pr_warn("This probe might be able to register after target module is loaded. Continue.\n");
466 "target module is loaded. Continue.\n");
467 ret = 0; 466 ret = 0;
468 } else if (ret == -EILSEQ) { 467 } else if (ret == -EILSEQ) {
469 pr_warning("Probing address(0x%p) is not an " 468 pr_warn("Probing address(0x%p) is not an instruction boundary.\n",
470 "instruction boundary.\n", 469 tk->rp.kp.addr);
471 tk->rp.kp.addr);
472 ret = -EINVAL; 470 ret = -EINVAL;
473 } 471 }
474 } 472 }
@@ -529,7 +527,7 @@ static int register_trace_kprobe(struct trace_kprobe *tk)
529 /* Register new event */ 527 /* Register new event */
530 ret = register_kprobe_event(tk); 528 ret = register_kprobe_event(tk);
531 if (ret) { 529 if (ret) {
532 pr_warning("Failed to register probe event(%d)\n", ret); 530 pr_warn("Failed to register probe event(%d)\n", ret);
533 goto end; 531 goto end;
534 } 532 }
535 533
@@ -564,10 +562,9 @@ static int trace_kprobe_module_callback(struct notifier_block *nb,
564 __unregister_trace_kprobe(tk); 562 __unregister_trace_kprobe(tk);
565 ret = __register_trace_kprobe(tk); 563 ret = __register_trace_kprobe(tk);
566 if (ret) 564 if (ret)
567 pr_warning("Failed to re-register probe %s on" 565 pr_warn("Failed to re-register probe %s on %s: %d\n",
568 "%s: %d\n", 566 trace_event_name(&tk->tp.call),
569 trace_event_name(&tk->tp.call), 567 mod->name, ret);
570 mod->name, ret);
571 } 568 }
572 } 569 }
573 mutex_unlock(&probe_lock); 570 mutex_unlock(&probe_lock);
@@ -1336,16 +1333,14 @@ static __init int init_kprobe_trace(void)
1336 1333
1337 /* Event list interface */ 1334 /* Event list interface */
1338 if (!entry) 1335 if (!entry)
1339 pr_warning("Could not create tracefs " 1336 pr_warn("Could not create tracefs 'kprobe_events' entry\n");
1340 "'kprobe_events' entry\n");
1341 1337
1342 /* Profile interface */ 1338 /* Profile interface */
1343 entry = tracefs_create_file("kprobe_profile", 0444, d_tracer, 1339 entry = tracefs_create_file("kprobe_profile", 0444, d_tracer,
1344 NULL, &kprobe_profile_ops); 1340 NULL, &kprobe_profile_ops);
1345 1341
1346 if (!entry) 1342 if (!entry)
1347 pr_warning("Could not create tracefs " 1343 pr_warn("Could not create tracefs 'kprobe_profile' entry\n");
1348 "'kprobe_profile' entry\n");
1349 return 0; 1344 return 0;
1350} 1345}
1351fs_initcall(init_kprobe_trace); 1346fs_initcall(init_kprobe_trace);
diff --git a/kernel/trace/trace_mmiotrace.c b/kernel/trace/trace_mmiotrace.c
index 2be8c4f2403d..68f376ca6d3f 100644
--- a/kernel/trace/trace_mmiotrace.c
+++ b/kernel/trace/trace_mmiotrace.c
@@ -146,7 +146,7 @@ static ssize_t mmio_read(struct trace_iterator *iter, struct file *filp,
146 /* XXX: This is later than where events were lost. */ 146 /* XXX: This is later than where events were lost. */
147 trace_seq_printf(s, "MARK 0.000000 Lost %lu events.\n", n); 147 trace_seq_printf(s, "MARK 0.000000 Lost %lu events.\n", n);
148 if (!overrun_detected) 148 if (!overrun_detected)
149 pr_warning("mmiotrace has lost events.\n"); 149 pr_warn("mmiotrace has lost events\n");
150 overrun_detected = true; 150 overrun_detected = true;
151 goto print_out; 151 goto print_out;
152 } 152 }
diff --git a/kernel/trace/trace_probe.c b/kernel/trace/trace_probe.c
index 1769a81da8a7..1d372fa6fefb 100644
--- a/kernel/trace/trace_probe.c
+++ b/kernel/trace/trace_probe.c
@@ -636,8 +636,8 @@ ssize_t traceprobe_probes_write(struct file *file, const char __user *buffer,
636 *tmp = '\0'; 636 *tmp = '\0';
637 size = tmp - kbuf + 1; 637 size = tmp - kbuf + 1;
638 } else if (done + size < count) { 638 } else if (done + size < count) {
639 pr_warning("Line length is too long: " 639 pr_warn("Line length is too long: Should be less than %d\n",
640 "Should be less than %d.", WRITE_BUFSIZE); 640 WRITE_BUFSIZE);
641 ret = -EINVAL; 641 ret = -EINVAL;
642 goto out; 642 goto out;
643 } 643 }
diff --git a/kernel/trace/trace_stat.c b/kernel/trace/trace_stat.c
index 6cf935316769..413ff108fbd0 100644
--- a/kernel/trace/trace_stat.c
+++ b/kernel/trace/trace_stat.c
@@ -281,8 +281,7 @@ static int tracing_stat_init(void)
281 281
282 stat_dir = tracefs_create_dir("trace_stat", d_tracing); 282 stat_dir = tracefs_create_dir("trace_stat", d_tracing);
283 if (!stat_dir) 283 if (!stat_dir)
284 pr_warning("Could not create tracefs " 284 pr_warn("Could not create tracefs 'trace_stat' entry\n");
285 "'trace_stat' entry\n");
286 return 0; 285 return 0;
287} 286}
288 287
diff --git a/kernel/trace/trace_uprobe.c b/kernel/trace/trace_uprobe.c
index d2f6d0be3503..7915142c89e4 100644
--- a/kernel/trace/trace_uprobe.c
+++ b/kernel/trace/trace_uprobe.c
@@ -334,7 +334,7 @@ static int register_trace_uprobe(struct trace_uprobe *tu)
334 334
335 ret = register_uprobe_event(tu); 335 ret = register_uprobe_event(tu);
336 if (ret) { 336 if (ret) {
337 pr_warning("Failed to register probe event(%d)\n", ret); 337 pr_warn("Failed to register probe event(%d)\n", ret);
338 goto end; 338 goto end;
339 } 339 }
340 340
diff --git a/kernel/tracepoint.c b/kernel/tracepoint.c
index ecd536de603a..d0639d917899 100644
--- a/kernel/tracepoint.c
+++ b/kernel/tracepoint.c
@@ -491,7 +491,7 @@ static __init int init_tracepoints(void)
491 491
492 ret = register_module_notifier(&tracepoint_module_nb); 492 ret = register_module_notifier(&tracepoint_module_nb);
493 if (ret) 493 if (ret)
494 pr_warning("Failed to register tracepoint module enter notifier\n"); 494 pr_warn("Failed to register tracepoint module enter notifier\n");
495 495
496 return ret; 496 return ret;
497} 497}