diff options
author | Paul E. McKenney <paulmck@linux.vnet.ibm.com> | 2018-07-02 12:04:27 -0400 |
---|---|---|
committer | Paul E. McKenney <paulmck@linux.vnet.ibm.com> | 2018-08-30 19:02:42 -0400 |
commit | 82fcecfa81855924cc69f3078113cf63dd6c2964 (patch) | |
tree | d0265b21d92811b8ae717047264573049a3a7e74 /kernel | |
parent | 65cfe3583b612a22e12fba9a7bbd2d37ca5ad941 (diff) |
rcu: Update comments and help text for no more RCU-bh updaters
This commit updates comments and help text to account for the fact that
RCU-bh update-side functions are now simple wrappers for their RCU or
RCU-sched counterparts.
Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Diffstat (limited to 'kernel')
-rw-r--r-- | kernel/rcu/Kconfig | 10 | ||||
-rw-r--r-- | kernel/rcu/tree.c | 17 | ||||
-rw-r--r-- | kernel/rcu/update.c | 2 |
3 files changed, 15 insertions, 14 deletions
diff --git a/kernel/rcu/Kconfig b/kernel/rcu/Kconfig index 9210379c0353..a0b7f0103ca9 100644 --- a/kernel/rcu/Kconfig +++ b/kernel/rcu/Kconfig | |||
@@ -229,11 +229,11 @@ config RCU_NOCB_CPU | |||
229 | CPUs specified at boot time by the rcu_nocbs parameter. | 229 | CPUs specified at boot time by the rcu_nocbs parameter. |
230 | For each such CPU, a kthread ("rcuox/N") will be created to | 230 | For each such CPU, a kthread ("rcuox/N") will be created to |
231 | invoke callbacks, where the "N" is the CPU being offloaded, | 231 | invoke callbacks, where the "N" is the CPU being offloaded, |
232 | and where the "x" is "b" for RCU-bh, "p" for RCU-preempt, and | 232 | and where the "p" for RCU-preempt and "s" for RCU-sched. |
233 | "s" for RCU-sched. Nothing prevents this kthread from running | 233 | Nothing prevents this kthread from running on the specified |
234 | on the specified CPUs, but (1) the kthreads may be preempted | 234 | CPUs, but (1) the kthreads may be preempted between each |
235 | between each callback, and (2) affinity or cgroups can be used | 235 | callback, and (2) affinity or cgroups can be used to force |
236 | to force the kthreads to run on whatever set of CPUs is desired. | 236 | the kthreads to run on whatever set of CPUs is desired. |
237 | 237 | ||
238 | Say Y here if you want to help to debug reduced OS jitter. | 238 | Say Y here if you want to help to debug reduced OS jitter. |
239 | Say N here if you are unsure. | 239 | Say N here if you are unsure. |
diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c index aedf81a0abd8..158c58d47b07 100644 --- a/kernel/rcu/tree.c +++ b/kernel/rcu/tree.c | |||
@@ -565,7 +565,8 @@ unsigned long rcu_sched_get_gp_seq(void) | |||
565 | EXPORT_SYMBOL_GPL(rcu_sched_get_gp_seq); | 565 | EXPORT_SYMBOL_GPL(rcu_sched_get_gp_seq); |
566 | 566 | ||
567 | /* | 567 | /* |
568 | * Return the number of RCU-bh GPs completed thus far for debug & stats. | 568 | * Return the number of RCU GPs completed thus far for debug & stats. |
569 | * This is a transitional API and will soon be removed. | ||
569 | */ | 570 | */ |
570 | unsigned long rcu_bh_get_gp_seq(void) | 571 | unsigned long rcu_bh_get_gp_seq(void) |
571 | { | 572 | { |
@@ -3069,13 +3070,13 @@ void kfree_call_rcu(struct rcu_head *head, | |||
3069 | EXPORT_SYMBOL_GPL(kfree_call_rcu); | 3070 | EXPORT_SYMBOL_GPL(kfree_call_rcu); |
3070 | 3071 | ||
3071 | /* | 3072 | /* |
3072 | * Because a context switch is a grace period for RCU-sched and RCU-bh, | 3073 | * Because a context switch is a grace period for RCU-sched, any blocking |
3073 | * any blocking grace-period wait automatically implies a grace period | 3074 | * grace-period wait automatically implies a grace period if there |
3074 | * if there is only one CPU online at any point time during execution | 3075 | * is only one CPU online at any point time during execution of either |
3075 | * of either synchronize_sched() or synchronize_rcu_bh(). It is OK to | 3076 | * synchronize_sched() or synchronize_rcu_bh(). It is OK to occasionally |
3076 | * occasionally incorrectly indicate that there are multiple CPUs online | 3077 | * incorrectly indicate that there are multiple CPUs online when there |
3077 | * when there was in fact only one the whole time, as this just adds | 3078 | * was in fact only one the whole time, as this just adds some overhead: |
3078 | * some overhead: RCU still operates correctly. | 3079 | * RCU still operates correctly. |
3079 | */ | 3080 | */ |
3080 | static int rcu_blocking_is_gp(void) | 3081 | static int rcu_blocking_is_gp(void) |
3081 | { | 3082 | { |
diff --git a/kernel/rcu/update.c b/kernel/rcu/update.c index 39cb23d22109..9ea87d0aa386 100644 --- a/kernel/rcu/update.c +++ b/kernel/rcu/update.c | |||
@@ -298,7 +298,7 @@ EXPORT_SYMBOL_GPL(rcu_read_lock_held); | |||
298 | * | 298 | * |
299 | * Check debug_lockdep_rcu_enabled() to prevent false positives during boot. | 299 | * Check debug_lockdep_rcu_enabled() to prevent false positives during boot. |
300 | * | 300 | * |
301 | * Note that rcu_read_lock() is disallowed if the CPU is either idle or | 301 | * Note that rcu_read_lock_bh() is disallowed if the CPU is either idle or |
302 | * offline from an RCU perspective, so check for those as well. | 302 | * offline from an RCU perspective, so check for those as well. |
303 | */ | 303 | */ |
304 | int rcu_read_lock_bh_held(void) | 304 | int rcu_read_lock_bh_held(void) |