aboutsummaryrefslogtreecommitdiffstats
path: root/kernel/trace/trace_kprobe.c
diff options
context:
space:
mode:
authorMasami Hiramatsu <masami.hiramatsu.pt@hitachi.com>2011-02-04 07:51:53 -0500
committerArnaldo Carvalho de Melo <acme@redhat.com>2011-02-07 06:13:36 -0500
commit76022db323dd6d7c6958df3d595f7dedf7a14778 (patch)
treeee109837ec2fa03dd476e60e128a59afc26fe5e7 /kernel/trace/trace_kprobe.c
parentf50c2169bd054984e976e67e8651d28f3caf6ba3 (diff)
tracing/kprobes: Cleanup strict_strtol() using code
Since strict_strtol() accepts minus digits started with '-', it doesn't need to invert after converting. Cc: 2nddept-manager@sdl.hitachi.co.jp Cc: Frederic Weisbecker <fweisbec@gmail.com> Cc: Ingo Molnar <mingo@elte.hu> Cc: Srikar Dronamraju <srikar@linux.vnet.ibm.com> Cc: Steven Rostedt <rostedt@goodmis.org> LKML-Reference: <20110204125153.9507.49335.stgit@ltc236.sdl.hitachi.co.jp> Signed-off-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Diffstat (limited to 'kernel/trace/trace_kprobe.c')
-rw-r--r--kernel/trace/trace_kprobe.c5
1 files changed, 2 insertions, 3 deletions
diff --git a/kernel/trace/trace_kprobe.c b/kernel/trace/trace_kprobe.c
index 2dec9bcde8b4..2088893c049e 100644
--- a/kernel/trace/trace_kprobe.c
+++ b/kernel/trace/trace_kprobe.c
@@ -767,16 +767,15 @@ static int __parse_probe_arg(char *arg, const struct fetch_type *t,
767 } 767 }
768 break; 768 break;
769 case '+': /* deref memory */ 769 case '+': /* deref memory */
770 arg++; /* Skip '+', because strict_strtol() rejects it. */
770 case '-': 771 case '-':
771 tmp = strchr(arg, '('); 772 tmp = strchr(arg, '(');
772 if (!tmp) 773 if (!tmp)
773 break; 774 break;
774 *tmp = '\0'; 775 *tmp = '\0';
775 ret = strict_strtol(arg + 1, 0, &offset); 776 ret = strict_strtol(arg, 0, &offset);
776 if (ret) 777 if (ret)
777 break; 778 break;
778 if (arg[0] == '-')
779 offset = -offset;
780 arg = tmp + 1; 779 arg = tmp + 1;
781 tmp = strrchr(arg, ')'); 780 tmp = strrchr(arg, ')');
782 if (tmp) { 781 if (tmp) {