diff options
author | Steven Rostedt (Red Hat) <rostedt@goodmis.org> | 2015-09-25 13:30:47 -0400 |
---|---|---|
committer | Steven Rostedt <rostedt@goodmis.org> | 2015-09-25 15:37:23 -0400 |
commit | d78a461427d752bc1cd5b87515167453a18de7e3 (patch) | |
tree | 884065664364ad86d83458f79e7db740c3fefc3c /kernel/trace/trace.c | |
parent | 46ac51822a6a0b83ee3e408ee9edcb292fb8ced0 (diff) |
tracing: Remove ftrace_trace_stack_regs()
ftrace_trace_stack_regs() is used in only one place, and because that is
such a simple function, just move its code into the location that it was
used in (trace_buffer_unlock_commit_regs()).
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
Diffstat (limited to 'kernel/trace/trace.c')
-rw-r--r-- | kernel/trace/trace.c | 24 |
1 files changed, 14 insertions, 10 deletions
diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c index 6e79408674aa..50820887dce9 100644 --- a/kernel/trace/trace.c +++ b/kernel/trace/trace.c | |||
@@ -468,6 +468,18 @@ static inline void trace_access_lock_init(void) | |||
468 | 468 | ||
469 | #endif | 469 | #endif |
470 | 470 | ||
471 | #ifdef CONFIG_STACKTRACE | ||
472 | static void __ftrace_trace_stack(struct ring_buffer *buffer, | ||
473 | unsigned long flags, | ||
474 | int skip, int pc, struct pt_regs *regs); | ||
475 | #else | ||
476 | static inline void __ftrace_trace_stack(struct ring_buffer *buffer, | ||
477 | unsigned long flags, | ||
478 | int skip, int pc, struct pt_regs *regs) | ||
479 | { | ||
480 | } | ||
481 | #endif | ||
482 | |||
471 | /* trace_flags holds trace_options default values */ | 483 | /* trace_flags holds trace_options default values */ |
472 | unsigned long trace_flags = TRACE_ITER_PRINT_PARENT | TRACE_ITER_PRINTK | | 484 | unsigned long trace_flags = TRACE_ITER_PRINT_PARENT | TRACE_ITER_PRINTK | |
473 | TRACE_ITER_ANNOTATE | TRACE_ITER_CONTEXT_INFO | TRACE_ITER_SLEEP_TIME | | 485 | TRACE_ITER_ANNOTATE | TRACE_ITER_CONTEXT_INFO | TRACE_ITER_SLEEP_TIME | |
@@ -1744,7 +1756,8 @@ void trace_buffer_unlock_commit_regs(struct ring_buffer *buffer, | |||
1744 | { | 1756 | { |
1745 | __buffer_unlock_commit(buffer, event); | 1757 | __buffer_unlock_commit(buffer, event); |
1746 | 1758 | ||
1747 | ftrace_trace_stack_regs(buffer, flags, 0, pc, regs); | 1759 | if (trace_flags & TRACE_ITER_STACKTRACE) |
1760 | __ftrace_trace_stack(buffer, flags, 0, pc, regs); | ||
1748 | ftrace_trace_userstack(buffer, flags, pc); | 1761 | ftrace_trace_userstack(buffer, flags, pc); |
1749 | } | 1762 | } |
1750 | EXPORT_SYMBOL_GPL(trace_buffer_unlock_commit_regs); | 1763 | EXPORT_SYMBOL_GPL(trace_buffer_unlock_commit_regs); |
@@ -1873,15 +1886,6 @@ static void __ftrace_trace_stack(struct ring_buffer *buffer, | |||
1873 | 1886 | ||
1874 | } | 1887 | } |
1875 | 1888 | ||
1876 | void ftrace_trace_stack_regs(struct ring_buffer *buffer, unsigned long flags, | ||
1877 | int skip, int pc, struct pt_regs *regs) | ||
1878 | { | ||
1879 | if (!(trace_flags & TRACE_ITER_STACKTRACE)) | ||
1880 | return; | ||
1881 | |||
1882 | __ftrace_trace_stack(buffer, flags, skip, pc, regs); | ||
1883 | } | ||
1884 | |||
1885 | void ftrace_trace_stack(struct ring_buffer *buffer, unsigned long flags, | 1889 | void ftrace_trace_stack(struct ring_buffer *buffer, unsigned long flags, |
1886 | int skip, int pc) | 1890 | int skip, int pc) |
1887 | { | 1891 | { |