diff options
author | Mathieu Malaterre <malat@debian.org> | 2018-03-08 15:58:43 -0500 |
---|---|---|
committer | Steven Rostedt (VMware) <rostedt@goodmis.org> | 2018-07-03 18:32:04 -0400 |
commit | 26b68dd2f48fe7699a89f0cfbb9f4a650dc1c837 (patch) | |
tree | 53ed16172da01547d9a260a92c7f88c279c2711d /kernel/trace/trace.c | |
parent | f26808ba7227a921e0e8549c7d3c52332b920085 (diff) |
tracing: Use __printf markup to silence compiler
Silence warnings (triggered at W=1) by adding relevant __printf attributes.
CC kernel/trace/trace.o
kernel/trace/trace.c: In function ‘__trace_array_vprintk’:
kernel/trace/trace.c:2979:2: warning: function might be possible candidate for ‘gnu_printf’ format attribute [-Wsuggest-attribute=format]
len = vscnprintf(tbuffer, TRACE_BUF_SIZE, fmt, args);
^~~
AR kernel/trace/built-in.o
Link: http://lkml.kernel.org/r/20180308205843.27447-1-malat@debian.org
Signed-off-by: Mathieu Malaterre <malat@debian.org>
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
Diffstat (limited to 'kernel/trace/trace.c')
-rw-r--r-- | kernel/trace/trace.c | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c index a0079b4c7a49..f054bd6a1c66 100644 --- a/kernel/trace/trace.c +++ b/kernel/trace/trace.c | |||
@@ -2953,6 +2953,7 @@ out_nobuffer: | |||
2953 | } | 2953 | } |
2954 | EXPORT_SYMBOL_GPL(trace_vbprintk); | 2954 | EXPORT_SYMBOL_GPL(trace_vbprintk); |
2955 | 2955 | ||
2956 | __printf(3, 0) | ||
2956 | static int | 2957 | static int |
2957 | __trace_array_vprintk(struct ring_buffer *buffer, | 2958 | __trace_array_vprintk(struct ring_buffer *buffer, |
2958 | unsigned long ip, const char *fmt, va_list args) | 2959 | unsigned long ip, const char *fmt, va_list args) |
@@ -3007,12 +3008,14 @@ out_nobuffer: | |||
3007 | return len; | 3008 | return len; |
3008 | } | 3009 | } |
3009 | 3010 | ||
3011 | __printf(3, 0) | ||
3010 | int trace_array_vprintk(struct trace_array *tr, | 3012 | int trace_array_vprintk(struct trace_array *tr, |
3011 | unsigned long ip, const char *fmt, va_list args) | 3013 | unsigned long ip, const char *fmt, va_list args) |
3012 | { | 3014 | { |
3013 | return __trace_array_vprintk(tr->trace_buffer.buffer, ip, fmt, args); | 3015 | return __trace_array_vprintk(tr->trace_buffer.buffer, ip, fmt, args); |
3014 | } | 3016 | } |
3015 | 3017 | ||
3018 | __printf(3, 0) | ||
3016 | int trace_array_printk(struct trace_array *tr, | 3019 | int trace_array_printk(struct trace_array *tr, |
3017 | unsigned long ip, const char *fmt, ...) | 3020 | unsigned long ip, const char *fmt, ...) |
3018 | { | 3021 | { |
@@ -3028,6 +3031,7 @@ int trace_array_printk(struct trace_array *tr, | |||
3028 | return ret; | 3031 | return ret; |
3029 | } | 3032 | } |
3030 | 3033 | ||
3034 | __printf(3, 4) | ||
3031 | int trace_array_printk_buf(struct ring_buffer *buffer, | 3035 | int trace_array_printk_buf(struct ring_buffer *buffer, |
3032 | unsigned long ip, const char *fmt, ...) | 3036 | unsigned long ip, const char *fmt, ...) |
3033 | { | 3037 | { |
@@ -3043,6 +3047,7 @@ int trace_array_printk_buf(struct ring_buffer *buffer, | |||
3043 | return ret; | 3047 | return ret; |
3044 | } | 3048 | } |
3045 | 3049 | ||
3050 | __printf(2, 0) | ||
3046 | int trace_vprintk(unsigned long ip, const char *fmt, va_list args) | 3051 | int trace_vprintk(unsigned long ip, const char *fmt, va_list args) |
3047 | { | 3052 | { |
3048 | return trace_array_vprintk(&global_trace, ip, fmt, args); | 3053 | return trace_array_vprintk(&global_trace, ip, fmt, args); |