diff options
author | Linus Torvalds <torvalds@linux-foundation.org> | 2013-11-13 01:45:43 -0500 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2013-11-13 01:45:43 -0500 |
commit | 5cbb3d216e2041700231bcfc383ee5f8b7fc8b74 (patch) | |
tree | a738fa82dbcefa9bd283c08bc67f38827be63937 /kernel/taskstats.c | |
parent | 9bc9ccd7db1c9f043f75380b5a5b94912046a60e (diff) | |
parent | 4e9b45a19241354daec281d7a785739829b52359 (diff) |
Merge branch 'akpm' (patches from Andrew Morton)
Merge first patch-bomb from Andrew Morton:
"Quite a lot of other stuff is banked up awaiting further
next->mainline merging, but this batch contains:
- Lots of random misc patches
- OCFS2
- Most of MM
- backlight updates
- lib/ updates
- printk updates
- checkpatch updates
- epoll tweaking
- rtc updates
- hfs
- hfsplus
- documentation
- procfs
- update gcov to gcc-4.7 format
- IPC"
* emailed patches from Andrew Morton <akpm@linux-foundation.org>: (269 commits)
ipc, msg: fix message length check for negative values
ipc/util.c: remove unnecessary work pending test
devpts: plug the memory leak in kill_sb
./Makefile: export initial ramdisk compression config option
init/Kconfig: add option to disable kernel compression
drivers: w1: make w1_slave::flags long to avoid memory corruption
drivers/w1/masters/ds1wm.cuse dev_get_platdata()
drivers/memstick/core/ms_block.c: fix unreachable state in h_msb_read_page()
drivers/memstick/core/mspro_block.c: fix attributes array allocation
drivers/pps/clients/pps-gpio.c: remove redundant of_match_ptr
kernel/panic.c: reduce 1 byte usage for print tainted buffer
gcov: reuse kbasename helper
kernel/gcov/fs.c: use pr_warn()
kernel/module.c: use pr_foo()
gcov: compile specific gcov implementation based on gcc version
gcov: add support for gcc 4.7 gcov format
gcov: move gcov structs definitions to a gcc version specific file
kernel/taskstats.c: return -ENOMEM when alloc memory fails in add_del_listener()
kernel/taskstats.c: add nla_nest_cancel() for failure processing between nla_nest_start() and nla_nest_end()
kernel/sysctl_binary.c: use scnprintf() instead of snprintf()
...
Diffstat (limited to 'kernel/taskstats.c')
-rw-r--r-- | kernel/taskstats.c | 16 |
1 files changed, 11 insertions, 5 deletions
diff --git a/kernel/taskstats.c b/kernel/taskstats.c index 145bb4d3bd4d..9f4618eb51c8 100644 --- a/kernel/taskstats.c +++ b/kernel/taskstats.c | |||
@@ -290,6 +290,7 @@ static int add_del_listener(pid_t pid, const struct cpumask *mask, int isadd) | |||
290 | struct listener_list *listeners; | 290 | struct listener_list *listeners; |
291 | struct listener *s, *tmp, *s2; | 291 | struct listener *s, *tmp, *s2; |
292 | unsigned int cpu; | 292 | unsigned int cpu; |
293 | int ret = 0; | ||
293 | 294 | ||
294 | if (!cpumask_subset(mask, cpu_possible_mask)) | 295 | if (!cpumask_subset(mask, cpu_possible_mask)) |
295 | return -EINVAL; | 296 | return -EINVAL; |
@@ -304,9 +305,10 @@ static int add_del_listener(pid_t pid, const struct cpumask *mask, int isadd) | |||
304 | for_each_cpu(cpu, mask) { | 305 | for_each_cpu(cpu, mask) { |
305 | s = kmalloc_node(sizeof(struct listener), | 306 | s = kmalloc_node(sizeof(struct listener), |
306 | GFP_KERNEL, cpu_to_node(cpu)); | 307 | GFP_KERNEL, cpu_to_node(cpu)); |
307 | if (!s) | 308 | if (!s) { |
309 | ret = -ENOMEM; | ||
308 | goto cleanup; | 310 | goto cleanup; |
309 | 311 | } | |
310 | s->pid = pid; | 312 | s->pid = pid; |
311 | s->valid = 1; | 313 | s->valid = 1; |
312 | 314 | ||
@@ -339,7 +341,7 @@ cleanup: | |||
339 | } | 341 | } |
340 | up_write(&listeners->sem); | 342 | up_write(&listeners->sem); |
341 | } | 343 | } |
342 | return 0; | 344 | return ret; |
343 | } | 345 | } |
344 | 346 | ||
345 | static int parse(struct nlattr *na, struct cpumask *mask) | 347 | static int parse(struct nlattr *na, struct cpumask *mask) |
@@ -404,11 +406,15 @@ static struct taskstats *mk_reply(struct sk_buff *skb, int type, u32 pid) | |||
404 | if (!na) | 406 | if (!na) |
405 | goto err; | 407 | goto err; |
406 | 408 | ||
407 | if (nla_put(skb, type, sizeof(pid), &pid) < 0) | 409 | if (nla_put(skb, type, sizeof(pid), &pid) < 0) { |
410 | nla_nest_cancel(skb, na); | ||
408 | goto err; | 411 | goto err; |
412 | } | ||
409 | ret = nla_reserve(skb, TASKSTATS_TYPE_STATS, sizeof(struct taskstats)); | 413 | ret = nla_reserve(skb, TASKSTATS_TYPE_STATS, sizeof(struct taskstats)); |
410 | if (!ret) | 414 | if (!ret) { |
415 | nla_nest_cancel(skb, na); | ||
411 | goto err; | 416 | goto err; |
417 | } | ||
412 | nla_nest_end(skb, na); | 418 | nla_nest_end(skb, na); |
413 | 419 | ||
414 | return nla_data(ret); | 420 | return nla_data(ret); |