aboutsummaryrefslogtreecommitdiffstats
path: root/kernel/sched
diff options
context:
space:
mode:
authorDietmar Eggemann <dietmar.eggemann@arm.com>2016-04-29 15:32:39 -0400
committerIngo Molnar <mingo@kernel.org>2016-05-05 03:41:10 -0400
commit885e542ce827f5f102fe9628d63c6430c8b7ab2c (patch)
tree53183b271b82647fb051aac7c317dda62ff5a0ef /kernel/sched
parent0a9b23ce46cd5d3a360fbefca8ffce441c55046e (diff)
sched/fair: Fix comment in calculate_imbalance()
The comment in calculate_imbalance() was introduced in commit: 2dd73a4f09be ("[PATCH] sched: implement smpnice") which described the logic as it was then, but a later commit: b18855500fc4 ("sched/balancing: Fix 'local->avg_load > sds->avg_load' case in calculate_imbalance()") .. complicated this logic some more so that the comment does not match anymore. Update the comment to match the code. Signed-off-by: Dietmar Eggemann <dietmar.eggemann@arm.com> Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org> Cc: Linus Torvalds <torvalds@linux-foundation.org> Cc: Mike Galbraith <efault@gmx.de> Cc: Morten Rasmussen <morten.rasmussen@arm.com> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Thomas Gleixner <tglx@linutronix.de> Link: http://lkml.kernel.org/r/1461958364-675-3-git-send-email-dietmar.eggemann@arm.com Signed-off-by: Ingo Molnar <mingo@kernel.org>
Diffstat (limited to 'kernel/sched')
-rw-r--r--kernel/sched/fair.c7
1 files changed, 4 insertions, 3 deletions
diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index 537d71ec18ab..51f7a4b62985 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -7000,9 +7000,10 @@ static inline void calculate_imbalance(struct lb_env *env, struct sd_lb_stats *s
7000 } 7000 }
7001 7001
7002 /* 7002 /*
7003 * In the presence of smp nice balancing, certain scenarios can have 7003 * Avg load of busiest sg can be less and avg load of local sg can
7004 * max load less than avg load(as we skip the groups at or below 7004 * be greater than avg load across all sgs of sd because avg load
7005 * its cpu_capacity, while calculating max_load..) 7005 * factors in sg capacity and sgs with smaller group_type are
7006 * skipped when updating the busiest sg:
7006 */ 7007 */
7007 if (busiest->avg_load <= sds->avg_load || 7008 if (busiest->avg_load <= sds->avg_load ||
7008 local->avg_load >= sds->avg_load) { 7009 local->avg_load >= sds->avg_load) {