aboutsummaryrefslogtreecommitdiffstats
path: root/kernel/rcu/tree.c
diff options
context:
space:
mode:
authorPaul E. McKenney <paulmck@linux.vnet.ibm.com>2018-05-02 16:51:57 -0400
committerPaul E. McKenney <paulmck@linux.vnet.ibm.com>2018-07-12 18:38:58 -0400
commitc50cbe535c972150c2caf923239ef77e85c5ad60 (patch)
tree126eaeb53fb463f65594e01236090bac106ab2e8 /kernel/rcu/tree.c
parent962aff03c315b508d980422db5b49b49e4382119 (diff)
rcu: Fix an obsolete ->qsmaskinit comment
Back in the old days, when grace-period initialization blocked CPU hotplug, the ->qsmaskinit mask was indeed updated at the time that a given CPU went offline. However, with the deferral of these updates until the beginning of the next grace period in commit 0aa04b055e71 ("rcu: Process offlining and onlining only at grace-period start"), it is instead ->qsmaskinitnext that gets updated at that time. This commit therefore updates the obsolete comment. It also fixes punctuation while on the topic of comments mentioning ->qsmaskinit. Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Diffstat (limited to 'kernel/rcu/tree.c')
-rw-r--r--kernel/rcu/tree.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c
index 9a5ba6db7b60..05f69b787a57 100644
--- a/kernel/rcu/tree.c
+++ b/kernel/rcu/tree.c
@@ -2438,7 +2438,7 @@ static void rcu_cleanup_dying_cpu(struct rcu_state *rsp)
2438 * This function therefore goes up the tree of rcu_node structures, 2438 * This function therefore goes up the tree of rcu_node structures,
2439 * clearing the corresponding bits in the ->qsmaskinit fields. Note that 2439 * clearing the corresponding bits in the ->qsmaskinit fields. Note that
2440 * the leaf rcu_node structure's ->qsmaskinit field has already been 2440 * the leaf rcu_node structure's ->qsmaskinit field has already been
2441 * updated 2441 * updated.
2442 * 2442 *
2443 * This function does check that the specified rcu_node structure has 2443 * This function does check that the specified rcu_node structure has
2444 * all CPUs offline and no blocked tasks, so it is OK to invoke it 2444 * all CPUs offline and no blocked tasks, so it is OK to invoke it
@@ -3709,7 +3709,7 @@ void rcu_cpu_starting(unsigned int cpu)
3709#ifdef CONFIG_HOTPLUG_CPU 3709#ifdef CONFIG_HOTPLUG_CPU
3710/* 3710/*
3711 * The CPU is exiting the idle loop into the arch_cpu_idle_dead() 3711 * The CPU is exiting the idle loop into the arch_cpu_idle_dead()
3712 * function. We now remove it from the rcu_node tree's ->qsmaskinit 3712 * function. We now remove it from the rcu_node tree's ->qsmaskinitnext
3713 * bit masks. 3713 * bit masks.
3714 */ 3714 */
3715static void rcu_cleanup_dying_idle_cpu(int cpu, struct rcu_state *rsp) 3715static void rcu_cleanup_dying_idle_cpu(int cpu, struct rcu_state *rsp)