diff options
author | Paul E. McKenney <paulmck@linux.vnet.ibm.com> | 2015-11-17 17:39:26 -0500 |
---|---|---|
committer | Paul E. McKenney <paulmck@linux.vnet.ibm.com> | 2015-12-05 20:58:26 -0500 |
commit | 6b50e119c440b7532ed749b635a58b3839f62992 (patch) | |
tree | 17dbb74f3ff6e9c4a595992f8262f757e65369d1 /kernel/rcu/tree.c | |
parent | 18aff33e7314253b9437234bd6d69ddc4827de70 (diff) |
rcutorture: Print symbolic name for ->gp_state
Currently, ->gp_state is printed as an integer, which slows debugging.
This commit therefore prints a symbolic name in addition to the integer.
Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
[ paulmck: Updated to fix relational operator called out by Dan Carpenter. ]
[ paulmck: More "const", as suggested by Josh Triplett. ]
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
Diffstat (limited to 'kernel/rcu/tree.c')
-rw-r--r-- | kernel/rcu/tree.c | 15 |
1 files changed, 13 insertions, 2 deletions
diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c index 7b78c88e19a3..316354109734 100644 --- a/kernel/rcu/tree.c +++ b/kernel/rcu/tree.c | |||
@@ -1187,6 +1187,16 @@ static void record_gp_stall_check_time(struct rcu_state *rsp) | |||
1187 | } | 1187 | } |
1188 | 1188 | ||
1189 | /* | 1189 | /* |
1190 | * Convert a ->gp_state value to a character string. | ||
1191 | */ | ||
1192 | static const char *gp_state_getname(short gs) | ||
1193 | { | ||
1194 | if (gs < 0 || gs >= ARRAY_SIZE(gp_state_names)) | ||
1195 | return "???"; | ||
1196 | return gp_state_names[gs]; | ||
1197 | } | ||
1198 | |||
1199 | /* | ||
1190 | * Complain about starvation of grace-period kthread. | 1200 | * Complain about starvation of grace-period kthread. |
1191 | */ | 1201 | */ |
1192 | static void rcu_check_gp_kthread_starvation(struct rcu_state *rsp) | 1202 | static void rcu_check_gp_kthread_starvation(struct rcu_state *rsp) |
@@ -1197,10 +1207,11 @@ static void rcu_check_gp_kthread_starvation(struct rcu_state *rsp) | |||
1197 | j = jiffies; | 1207 | j = jiffies; |
1198 | gpa = READ_ONCE(rsp->gp_activity); | 1208 | gpa = READ_ONCE(rsp->gp_activity); |
1199 | if (j - gpa > 2 * HZ) { | 1209 | if (j - gpa > 2 * HZ) { |
1200 | pr_err("%s kthread starved for %ld jiffies! g%lu c%lu f%#x s%d ->state=%#lx\n", | 1210 | pr_err("%s kthread starved for %ld jiffies! g%lu c%lu f%#x %s(%d) ->state=%#lx\n", |
1201 | rsp->name, j - gpa, | 1211 | rsp->name, j - gpa, |
1202 | rsp->gpnum, rsp->completed, | 1212 | rsp->gpnum, rsp->completed, |
1203 | rsp->gp_flags, rsp->gp_state, | 1213 | rsp->gp_flags, |
1214 | gp_state_getname(rsp->gp_state), rsp->gp_state, | ||
1204 | rsp->gp_kthread ? rsp->gp_kthread->state : ~0); | 1215 | rsp->gp_kthread ? rsp->gp_kthread->state : ~0); |
1205 | if (rsp->gp_kthread) | 1216 | if (rsp->gp_kthread) |
1206 | sched_show_task(rsp->gp_kthread); | 1217 | sched_show_task(rsp->gp_kthread); |