diff options
| author | Thomas Gleixner <tglx@linutronix.de> | 2015-04-14 17:09:15 -0400 |
|---|---|---|
| committer | Thomas Gleixner <tglx@linutronix.de> | 2015-04-22 11:06:51 -0400 |
| commit | ccdd92c17e144c8494f4c94ab85b48d297545cec (patch) | |
| tree | dd3064ecb353c4ef961f06b88a18df99e81f0709 /kernel/locking | |
| parent | 2e4b0d3fe88bc2618fd5d081ace338a70f8c23da (diff) | |
rtmutex: Remove bogus hrtimer_active() check
The check for hrtimer_active() after starting the timer is
pointless. If the timer is inactive it has expired already and
therefor the task pointer is already NULL.
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Acked-by: Peter Zijlstra <peterz@infradead.org>
Cc: Preeti U Murthy <preeti@linux.vnet.ibm.com>
Cc: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Marcelo Tosatti <mtosatti@redhat.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Link: http://lkml.kernel.org/r/20150414203503.081830481@linutronix.de
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Diffstat (limited to 'kernel/locking')
| -rw-r--r-- | kernel/locking/rtmutex.c | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/kernel/locking/rtmutex.c b/kernel/locking/rtmutex.c index b73279367087..8626437acf0c 100644 --- a/kernel/locking/rtmutex.c +++ b/kernel/locking/rtmutex.c | |||
| @@ -1180,11 +1180,8 @@ rt_mutex_slowlock(struct rt_mutex *lock, int state, | |||
| 1180 | set_current_state(state); | 1180 | set_current_state(state); |
| 1181 | 1181 | ||
| 1182 | /* Setup the timer, when timeout != NULL */ | 1182 | /* Setup the timer, when timeout != NULL */ |
| 1183 | if (unlikely(timeout)) { | 1183 | if (unlikely(timeout)) |
| 1184 | hrtimer_start_expires(&timeout->timer, HRTIMER_MODE_ABS); | 1184 | hrtimer_start_expires(&timeout->timer, HRTIMER_MODE_ABS); |
| 1185 | if (!hrtimer_active(&timeout->timer)) | ||
| 1186 | timeout->task = NULL; | ||
| 1187 | } | ||
| 1188 | 1185 | ||
| 1189 | ret = task_blocks_on_rt_mutex(lock, &waiter, current, chwalk); | 1186 | ret = task_blocks_on_rt_mutex(lock, &waiter, current, chwalk); |
| 1190 | 1187 | ||
