aboutsummaryrefslogtreecommitdiffstats
path: root/kernel/locking/rtmutex.c
diff options
context:
space:
mode:
authorMike Galbraith <efault@gmx.de>2017-04-05 04:08:27 -0400
committerThomas Gleixner <tglx@linutronix.de>2017-04-05 10:59:37 -0400
commitdef34eaae5ce04b324e48e1bfac873091d945213 (patch)
treed262afbd2361a24be327fa101c445c427c3d480d /kernel/locking/rtmutex.c
parent19830e55247cddb3f46f1bf60b8e245593491bea (diff)
rtmutex: Plug preempt count leak in rt_mutex_futex_unlock()
mark_wakeup_next_waiter() already disables preemption, doing so again leaves us with an unpaired preempt_disable(). Fixes: 2a1c60299406 ("rtmutex: Deboost before waking up the top waiter") Signed-off-by: Mike Galbraith <efault@gmx.de> Cc: Peter Zijlstra <peterz@infradead.org> Cc: xlpang@redhat.com Cc: rostedt@goodmis.org Link: http://lkml.kernel.org/r/1491379707.6538.2.camel@gmx.de Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Diffstat (limited to 'kernel/locking/rtmutex.c')
-rw-r--r--kernel/locking/rtmutex.c10
1 files changed, 5 insertions, 5 deletions
diff --git a/kernel/locking/rtmutex.c b/kernel/locking/rtmutex.c
index 0e641eb473de..b95509416909 100644
--- a/kernel/locking/rtmutex.c
+++ b/kernel/locking/rtmutex.c
@@ -1581,13 +1581,13 @@ bool __sched __rt_mutex_futex_unlock(struct rt_mutex *lock,
1581 return false; /* done */ 1581 return false; /* done */
1582 } 1582 }
1583 1583
1584 mark_wakeup_next_waiter(wake_q, lock);
1585 /* 1584 /*
1586 * We've already deboosted, retain preempt_disabled when dropping 1585 * We've already deboosted, mark_wakeup_next_waiter() will
1587 * the wait_lock to avoid inversion until the wakeup. Matched 1586 * retain preempt_disabled when we drop the wait_lock, to
1588 * by rt_mutex_postunlock(); 1587 * avoid inversion prior to the wakeup. preempt_disable()
1588 * therein pairs with rt_mutex_postunlock().
1589 */ 1589 */
1590 preempt_disable(); 1590 mark_wakeup_next_waiter(wake_q, lock);
1591 1591
1592 return true; /* call postunlock() */ 1592 return true; /* call postunlock() */
1593} 1593}