diff options
| author | Jessica Yu <jeyu@redhat.com> | 2016-08-17 20:58:28 -0400 |
|---|---|---|
| committer | Jiri Kosina <jkosina@suse.cz> | 2016-08-18 17:41:55 -0400 |
| commit | 255e732c61dbb6a0bf9e0a3d6bc45f202853c880 (patch) | |
| tree | 809fd1b54c971df21bc2e3929376ba9887eefafa /kernel/livepatch | |
| parent | 694d0d0bb2030d2e36df73e2d23d5770511dbc8d (diff) | |
livepatch: use arch_klp_init_object_loaded() to finish arch-specific tasks
Introduce arch_klp_init_object_loaded() to complete any additional
arch-specific tasks during patching. Architecture code may override this
function.
Signed-off-by: Jessica Yu <jeyu@redhat.com>
Reviewed-by: Petr Mladek <pmladek@suse.com>
Acked-by: Miroslav Benes <mbenes@suse.cz>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Diffstat (limited to 'kernel/livepatch')
| -rw-r--r-- | kernel/livepatch/core.c | 16 |
1 files changed, 13 insertions, 3 deletions
diff --git a/kernel/livepatch/core.c b/kernel/livepatch/core.c index 8bbe50704621..5fbabe022286 100644 --- a/kernel/livepatch/core.c +++ b/kernel/livepatch/core.c | |||
| @@ -274,7 +274,6 @@ static int klp_write_object_relocations(struct module *pmod, | |||
| 274 | 274 | ||
| 275 | objname = klp_is_module(obj) ? obj->name : "vmlinux"; | 275 | objname = klp_is_module(obj) ? obj->name : "vmlinux"; |
| 276 | 276 | ||
| 277 | module_disable_ro(pmod); | ||
| 278 | /* For each klp relocation section */ | 277 | /* For each klp relocation section */ |
| 279 | for (i = 1; i < pmod->klp_info->hdr.e_shnum; i++) { | 278 | for (i = 1; i < pmod->klp_info->hdr.e_shnum; i++) { |
| 280 | sec = pmod->klp_info->sechdrs + i; | 279 | sec = pmod->klp_info->sechdrs + i; |
| @@ -309,7 +308,6 @@ static int klp_write_object_relocations(struct module *pmod, | |||
| 309 | break; | 308 | break; |
| 310 | } | 309 | } |
| 311 | 310 | ||
| 312 | module_enable_ro(pmod, true); | ||
| 313 | return ret; | 311 | return ret; |
| 314 | } | 312 | } |
| 315 | 313 | ||
| @@ -763,6 +761,12 @@ static int klp_init_func(struct klp_object *obj, struct klp_func *func) | |||
| 763 | func->old_sympos ? func->old_sympos : 1); | 761 | func->old_sympos ? func->old_sympos : 1); |
| 764 | } | 762 | } |
| 765 | 763 | ||
| 764 | /* Arches may override this to finish any remaining arch-specific tasks */ | ||
| 765 | void __weak arch_klp_init_object_loaded(struct klp_patch *patch, | ||
| 766 | struct klp_object *obj) | ||
| 767 | { | ||
| 768 | } | ||
| 769 | |||
| 766 | /* parts of the initialization that is done only when the object is loaded */ | 770 | /* parts of the initialization that is done only when the object is loaded */ |
| 767 | static int klp_init_object_loaded(struct klp_patch *patch, | 771 | static int klp_init_object_loaded(struct klp_patch *patch, |
| 768 | struct klp_object *obj) | 772 | struct klp_object *obj) |
| @@ -770,9 +774,15 @@ static int klp_init_object_loaded(struct klp_patch *patch, | |||
| 770 | struct klp_func *func; | 774 | struct klp_func *func; |
| 771 | int ret; | 775 | int ret; |
| 772 | 776 | ||
| 777 | module_disable_ro(patch->mod); | ||
| 773 | ret = klp_write_object_relocations(patch->mod, obj); | 778 | ret = klp_write_object_relocations(patch->mod, obj); |
| 774 | if (ret) | 779 | if (ret) { |
| 780 | module_enable_ro(patch->mod, true); | ||
| 775 | return ret; | 781 | return ret; |
| 782 | } | ||
| 783 | |||
| 784 | arch_klp_init_object_loaded(patch, obj); | ||
| 785 | module_enable_ro(patch->mod, true); | ||
| 776 | 786 | ||
| 777 | klp_for_each_func(obj, func) { | 787 | klp_for_each_func(obj, func) { |
| 778 | ret = klp_find_object_symbol(obj->name, func->old_name, | 788 | ret = klp_find_object_symbol(obj->name, func->old_name, |
