aboutsummaryrefslogtreecommitdiffstats
path: root/kernel/livepatch/core.c
diff options
context:
space:
mode:
authorPetr Mladek <pmladek@suse.com>2019-04-24 04:55:48 -0400
committerPetr Mladek <pmladek@suse.com>2019-04-29 08:46:07 -0400
commit31adf2308f33dcae59009019675224be0978bc70 (patch)
treebbfbea22da40cfdc0f54387ef18e04a4c9890505 /kernel/livepatch/core.c
parent43bd3a95c98e1a86b8b55d97f745c224ecff02b9 (diff)
livepatch: Convert error about unsupported reliable stacktrace into a warning
The commit d0807da78e11d46f ("livepatch: Remove immediate feature") caused that any livepatch was refused when reliable stacktraces were not supported on the given architecture. The limitation is too strong. User space processes are safely migrated even when entering or leaving the kernel. Kthreads transition would need to get forced. But it is safe when: + The livepatch does not change the semantic of the code. + Callbacks do not depend on a safely finished transition. Suggested-by: Josh Poimboeuf <jpoimboe@redhat.com> Acked-by: Josh Poimboeuf <jpoimboe@redhat.com> Acked-by: Miroslav Benes <mbenes@suse.cz> Reviewed-by: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com> Signed-off-by: Petr Mladek <pmladek@suse.com>
Diffstat (limited to 'kernel/livepatch/core.c')
-rw-r--r--kernel/livepatch/core.c5
1 files changed, 2 insertions, 3 deletions
diff --git a/kernel/livepatch/core.c b/kernel/livepatch/core.c
index eb0ee10a1981..14f33ab6c583 100644
--- a/kernel/livepatch/core.c
+++ b/kernel/livepatch/core.c
@@ -1003,11 +1003,10 @@ int klp_enable_patch(struct klp_patch *patch)
1003 return -ENODEV; 1003 return -ENODEV;
1004 1004
1005 if (!klp_have_reliable_stack()) { 1005 if (!klp_have_reliable_stack()) {
1006 pr_err("This architecture doesn't have support for the livepatch consistency model.\n"); 1006 pr_warn("This architecture doesn't have support for the livepatch consistency model.\n");
1007 return -EOPNOTSUPP; 1007 pr_warn("The livepatch transition may never complete.\n");
1008 } 1008 }
1009 1009
1010
1011 mutex_lock(&klp_mutex); 1010 mutex_lock(&klp_mutex);
1012 1011
1013 ret = klp_init_patch_early(patch); 1012 ret = klp_init_patch_early(patch);