aboutsummaryrefslogtreecommitdiffstats
path: root/kernel/bpf/syscall.c
diff options
context:
space:
mode:
authorDan Carpenter <dan.carpenter@oracle.com>2017-08-18 03:27:02 -0400
committerDavid S. Miller <davem@davemloft.net>2017-08-18 13:18:20 -0400
commitae2b27b859a144f503d382580320873c0beb09c7 (patch)
tree08251cb6077167a861775b00370bfbe5fe4d2bc6 /kernel/bpf/syscall.c
parent98ee2a11374ad1dc7b69c97500f65c87f49ff911 (diff)
bpf: fix a return in sockmap_get_from_fd()
"map" is a valid pointer. We wanted to return "err" instead. Also let's return a zero literal at the end. Fixes: 174a79ff9515 ("bpf: sockmap with sk redirect support") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Acked-by: John Fastabend <john.fastabend@gmail.com> Acked-by: Daniel Borkmann <daniel@iogearbox.net> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'kernel/bpf/syscall.c')
-rw-r--r--kernel/bpf/syscall.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/kernel/bpf/syscall.c b/kernel/bpf/syscall.c
index d2f2bdf71ffa..b8cb1b3c9bfb 100644
--- a/kernel/bpf/syscall.c
+++ b/kernel/bpf/syscall.c
@@ -1125,11 +1125,11 @@ static int sockmap_get_from_fd(const union bpf_attr *attr, int ptype)
1125 fdput(f); 1125 fdput(f);
1126 bpf_prog_put(prog1); 1126 bpf_prog_put(prog1);
1127 bpf_prog_put(prog2); 1127 bpf_prog_put(prog2);
1128 return PTR_ERR(map); 1128 return err;
1129 } 1129 }
1130 1130
1131 fdput(f); 1131 fdput(f);
1132 return err; 1132 return 0;
1133} 1133}
1134 1134
1135static int bpf_prog_attach(const union bpf_attr *attr) 1135static int bpf_prog_attach(const union bpf_attr *attr)