fsnotify: Add group pointer in fsnotify_init_mark()

Currently we initialize mark->group only in fsnotify_add_mark_lock().
However we will need to access fsnotify_ops of corresponding group from
fsnotify_put_mark() so we need mark->group initialized earlier. Do that
in fsnotify_init_mark() which has a consequence that once
fsnotify_init_mark() is called on a mark, the mark has to be destroyed
by fsnotify_put_mark().

Reviewed-by: Miklos Szeredi <mszeredi@redhat.com>
Reviewed-by: Amir Goldstein <amir73il@gmail.com>
Signed-off-by: Jan Kara <jack@suse.cz>

1 files changed, 3 insertions, 2 deletions

diff --git a/kernel/audit_watch.c b/kernel/audit_watch.c
index 956fa584c239..e32efed86828 100644
--- a/kernel/audit_watch.c
+++ b/kernel/audit_watch.c
@@ -157,9 +157,10 @@ static struct audit_parent *audit_init_parent(struct path *path)
 
         INIT_LIST_HEAD(&parent->watches);
 
-        fsnotify_init_mark(&parent->mark, audit_watch_free_mark);
+        fsnotify_init_mark(&parent->mark, audit_watch_group,
+                           audit_watch_free_mark);
         parent->mark.mask = AUDIT_FS_WATCH;
-        ret = fsnotify_add_mark(&parent->mark, audit_watch_group, inode, NULL, 0);
+        ret = fsnotify_add_mark(&parent->mark, inode, NULL, 0);
         if (ret < 0) {
                 audit_free_parent(parent);
                 return ERR_PTR(ret);