aboutsummaryrefslogtreecommitdiffstats
path: root/include/trace
diff options
context:
space:
mode:
authorMike Christie <mchristi@redhat.com>2016-06-05 15:32:18 -0400
committerJens Axboe <axboe@fb.com>2016-06-07 15:41:38 -0400
commit1b9a9ab78b0ab79dc1f0ddd5fbed7833ec7de3a4 (patch)
treeada8868edd0e9c1761507b38db94b0b7cb0347fe /include/trace
parentc2df40dfb8c015211ec55f4b1dd0587f875c7b34 (diff)
blktrace: use op accessors
Have blktrace use the req/bio op accessor to get the REQ_OP. Signed-off-by: Mike Christie <mchristi@redhat.com> Reviewed-by: Christoph Hellwig <hch@lst.de> Reviewed-by: Hannes Reinecke <hare@suse.com> Signed-off-by: Jens Axboe <axboe@fb.com>
Diffstat (limited to 'include/trace')
-rw-r--r--include/trace/events/bcache.h12
-rw-r--r--include/trace/events/block.h31
2 files changed, 28 insertions, 15 deletions
diff --git a/include/trace/events/bcache.h b/include/trace/events/bcache.h
index 981acf74b14f..65673d8b81ac 100644
--- a/include/trace/events/bcache.h
+++ b/include/trace/events/bcache.h
@@ -27,7 +27,8 @@ DECLARE_EVENT_CLASS(bcache_request,
27 __entry->sector = bio->bi_iter.bi_sector; 27 __entry->sector = bio->bi_iter.bi_sector;
28 __entry->orig_sector = bio->bi_iter.bi_sector - 16; 28 __entry->orig_sector = bio->bi_iter.bi_sector - 16;
29 __entry->nr_sector = bio->bi_iter.bi_size >> 9; 29 __entry->nr_sector = bio->bi_iter.bi_size >> 9;
30 blk_fill_rwbs(__entry->rwbs, bio->bi_rw, bio->bi_iter.bi_size); 30 blk_fill_rwbs(__entry->rwbs, bio_op(bio), bio->bi_rw,
31 bio->bi_iter.bi_size);
31 ), 32 ),
32 33
33 TP_printk("%d,%d %s %llu + %u (from %d,%d @ %llu)", 34 TP_printk("%d,%d %s %llu + %u (from %d,%d @ %llu)",
@@ -101,7 +102,8 @@ DECLARE_EVENT_CLASS(bcache_bio,
101 __entry->dev = bio->bi_bdev->bd_dev; 102 __entry->dev = bio->bi_bdev->bd_dev;
102 __entry->sector = bio->bi_iter.bi_sector; 103 __entry->sector = bio->bi_iter.bi_sector;
103 __entry->nr_sector = bio->bi_iter.bi_size >> 9; 104 __entry->nr_sector = bio->bi_iter.bi_size >> 9;
104 blk_fill_rwbs(__entry->rwbs, bio->bi_rw, bio->bi_iter.bi_size); 105 blk_fill_rwbs(__entry->rwbs, bio_op(bio), bio->bi_rw,
106 bio->bi_iter.bi_size);
105 ), 107 ),
106 108
107 TP_printk("%d,%d %s %llu + %u", 109 TP_printk("%d,%d %s %llu + %u",
@@ -136,7 +138,8 @@ TRACE_EVENT(bcache_read,
136 __entry->dev = bio->bi_bdev->bd_dev; 138 __entry->dev = bio->bi_bdev->bd_dev;
137 __entry->sector = bio->bi_iter.bi_sector; 139 __entry->sector = bio->bi_iter.bi_sector;
138 __entry->nr_sector = bio->bi_iter.bi_size >> 9; 140 __entry->nr_sector = bio->bi_iter.bi_size >> 9;
139 blk_fill_rwbs(__entry->rwbs, bio->bi_rw, bio->bi_iter.bi_size); 141 blk_fill_rwbs(__entry->rwbs, bio_op(bio), bio->bi_rw,
142 bio->bi_iter.bi_size);
140 __entry->cache_hit = hit; 143 __entry->cache_hit = hit;
141 __entry->bypass = bypass; 144 __entry->bypass = bypass;
142 ), 145 ),
@@ -167,7 +170,8 @@ TRACE_EVENT(bcache_write,
167 __entry->inode = inode; 170 __entry->inode = inode;
168 __entry->sector = bio->bi_iter.bi_sector; 171 __entry->sector = bio->bi_iter.bi_sector;
169 __entry->nr_sector = bio->bi_iter.bi_size >> 9; 172 __entry->nr_sector = bio->bi_iter.bi_size >> 9;
170 blk_fill_rwbs(__entry->rwbs, bio->bi_rw, bio->bi_iter.bi_size); 173 blk_fill_rwbs(__entry->rwbs, bio_op(bio), bio->bi_rw,
174 bio->bi_iter.bi_size);
171 __entry->writeback = writeback; 175 __entry->writeback = writeback;
172 __entry->bypass = bypass; 176 __entry->bypass = bypass;
173 ), 177 ),
diff --git a/include/trace/events/block.h b/include/trace/events/block.h
index e8a5eca1dbe5..5a2a7592068f 100644
--- a/include/trace/events/block.h
+++ b/include/trace/events/block.h
@@ -84,7 +84,8 @@ DECLARE_EVENT_CLASS(block_rq_with_error,
84 0 : blk_rq_sectors(rq); 84 0 : blk_rq_sectors(rq);
85 __entry->errors = rq->errors; 85 __entry->errors = rq->errors;
86 86
87 blk_fill_rwbs(__entry->rwbs, rq->cmd_flags, blk_rq_bytes(rq)); 87 blk_fill_rwbs(__entry->rwbs, req_op(rq), rq->cmd_flags,
88 blk_rq_bytes(rq));
88 blk_dump_cmd(__get_str(cmd), rq); 89 blk_dump_cmd(__get_str(cmd), rq);
89 ), 90 ),
90 91
@@ -162,7 +163,7 @@ TRACE_EVENT(block_rq_complete,
162 __entry->nr_sector = nr_bytes >> 9; 163 __entry->nr_sector = nr_bytes >> 9;
163 __entry->errors = rq->errors; 164 __entry->errors = rq->errors;
164 165
165 blk_fill_rwbs(__entry->rwbs, rq->cmd_flags, nr_bytes); 166 blk_fill_rwbs(__entry->rwbs, req_op(rq), rq->cmd_flags, nr_bytes);
166 blk_dump_cmd(__get_str(cmd), rq); 167 blk_dump_cmd(__get_str(cmd), rq);
167 ), 168 ),
168 169
@@ -198,7 +199,8 @@ DECLARE_EVENT_CLASS(block_rq,
198 __entry->bytes = (rq->cmd_type == REQ_TYPE_BLOCK_PC) ? 199 __entry->bytes = (rq->cmd_type == REQ_TYPE_BLOCK_PC) ?
199 blk_rq_bytes(rq) : 0; 200 blk_rq_bytes(rq) : 0;
200 201
201 blk_fill_rwbs(__entry->rwbs, rq->cmd_flags, blk_rq_bytes(rq)); 202 blk_fill_rwbs(__entry->rwbs, req_op(rq), rq->cmd_flags,
203 blk_rq_bytes(rq));
202 blk_dump_cmd(__get_str(cmd), rq); 204 blk_dump_cmd(__get_str(cmd), rq);
203 memcpy(__entry->comm, current->comm, TASK_COMM_LEN); 205 memcpy(__entry->comm, current->comm, TASK_COMM_LEN);
204 ), 206 ),
@@ -272,7 +274,8 @@ TRACE_EVENT(block_bio_bounce,
272 bio->bi_bdev->bd_dev : 0; 274 bio->bi_bdev->bd_dev : 0;
273 __entry->sector = bio->bi_iter.bi_sector; 275 __entry->sector = bio->bi_iter.bi_sector;
274 __entry->nr_sector = bio_sectors(bio); 276 __entry->nr_sector = bio_sectors(bio);
275 blk_fill_rwbs(__entry->rwbs, bio->bi_rw, bio->bi_iter.bi_size); 277 blk_fill_rwbs(__entry->rwbs, bio_op(bio), bio->bi_rw,
278 bio->bi_iter.bi_size);
276 memcpy(__entry->comm, current->comm, TASK_COMM_LEN); 279 memcpy(__entry->comm, current->comm, TASK_COMM_LEN);
277 ), 280 ),
278 281
@@ -310,7 +313,8 @@ TRACE_EVENT(block_bio_complete,
310 __entry->sector = bio->bi_iter.bi_sector; 313 __entry->sector = bio->bi_iter.bi_sector;
311 __entry->nr_sector = bio_sectors(bio); 314 __entry->nr_sector = bio_sectors(bio);
312 __entry->error = error; 315 __entry->error = error;
313 blk_fill_rwbs(__entry->rwbs, bio->bi_rw, bio->bi_iter.bi_size); 316 blk_fill_rwbs(__entry->rwbs, bio_op(bio), bio->bi_rw,
317 bio->bi_iter.bi_size);
314 ), 318 ),
315 319
316 TP_printk("%d,%d %s %llu + %u [%d]", 320 TP_printk("%d,%d %s %llu + %u [%d]",
@@ -337,7 +341,8 @@ DECLARE_EVENT_CLASS(block_bio_merge,
337 __entry->dev = bio->bi_bdev->bd_dev; 341 __entry->dev = bio->bi_bdev->bd_dev;
338 __entry->sector = bio->bi_iter.bi_sector; 342 __entry->sector = bio->bi_iter.bi_sector;
339 __entry->nr_sector = bio_sectors(bio); 343 __entry->nr_sector = bio_sectors(bio);
340 blk_fill_rwbs(__entry->rwbs, bio->bi_rw, bio->bi_iter.bi_size); 344 blk_fill_rwbs(__entry->rwbs, bio_op(bio), bio->bi_rw,
345 bio->bi_iter.bi_size);
341 memcpy(__entry->comm, current->comm, TASK_COMM_LEN); 346 memcpy(__entry->comm, current->comm, TASK_COMM_LEN);
342 ), 347 ),
343 348
@@ -404,7 +409,8 @@ TRACE_EVENT(block_bio_queue,
404 __entry->dev = bio->bi_bdev->bd_dev; 409 __entry->dev = bio->bi_bdev->bd_dev;
405 __entry->sector = bio->bi_iter.bi_sector; 410 __entry->sector = bio->bi_iter.bi_sector;
406 __entry->nr_sector = bio_sectors(bio); 411 __entry->nr_sector = bio_sectors(bio);
407 blk_fill_rwbs(__entry->rwbs, bio->bi_rw, bio->bi_iter.bi_size); 412 blk_fill_rwbs(__entry->rwbs, bio_op(bio), bio->bi_rw,
413 bio->bi_iter.bi_size);
408 memcpy(__entry->comm, current->comm, TASK_COMM_LEN); 414 memcpy(__entry->comm, current->comm, TASK_COMM_LEN);
409 ), 415 ),
410 416
@@ -432,7 +438,7 @@ DECLARE_EVENT_CLASS(block_get_rq,
432 __entry->dev = bio ? bio->bi_bdev->bd_dev : 0; 438 __entry->dev = bio ? bio->bi_bdev->bd_dev : 0;
433 __entry->sector = bio ? bio->bi_iter.bi_sector : 0; 439 __entry->sector = bio ? bio->bi_iter.bi_sector : 0;
434 __entry->nr_sector = bio ? bio_sectors(bio) : 0; 440 __entry->nr_sector = bio ? bio_sectors(bio) : 0;
435 blk_fill_rwbs(__entry->rwbs, 441 blk_fill_rwbs(__entry->rwbs, bio ? bio_op(bio) : 0,
436 bio ? bio->bi_rw : 0, __entry->nr_sector); 442 bio ? bio->bi_rw : 0, __entry->nr_sector);
437 memcpy(__entry->comm, current->comm, TASK_COMM_LEN); 443 memcpy(__entry->comm, current->comm, TASK_COMM_LEN);
438 ), 444 ),
@@ -567,7 +573,8 @@ TRACE_EVENT(block_split,
567 __entry->dev = bio->bi_bdev->bd_dev; 573 __entry->dev = bio->bi_bdev->bd_dev;
568 __entry->sector = bio->bi_iter.bi_sector; 574 __entry->sector = bio->bi_iter.bi_sector;
569 __entry->new_sector = new_sector; 575 __entry->new_sector = new_sector;
570 blk_fill_rwbs(__entry->rwbs, bio->bi_rw, bio->bi_iter.bi_size); 576 blk_fill_rwbs(__entry->rwbs, bio_op(bio), bio->bi_rw,
577 bio->bi_iter.bi_size);
571 memcpy(__entry->comm, current->comm, TASK_COMM_LEN); 578 memcpy(__entry->comm, current->comm, TASK_COMM_LEN);
572 ), 579 ),
573 580
@@ -610,7 +617,8 @@ TRACE_EVENT(block_bio_remap,
610 __entry->nr_sector = bio_sectors(bio); 617 __entry->nr_sector = bio_sectors(bio);
611 __entry->old_dev = dev; 618 __entry->old_dev = dev;
612 __entry->old_sector = from; 619 __entry->old_sector = from;
613 blk_fill_rwbs(__entry->rwbs, bio->bi_rw, bio->bi_iter.bi_size); 620 blk_fill_rwbs(__entry->rwbs, bio_op(bio), bio->bi_rw,
621 bio->bi_iter.bi_size);
614 ), 622 ),
615 623
616 TP_printk("%d,%d %s %llu + %u <- (%d,%d) %llu", 624 TP_printk("%d,%d %s %llu + %u <- (%d,%d) %llu",
@@ -656,7 +664,8 @@ TRACE_EVENT(block_rq_remap,
656 __entry->old_dev = dev; 664 __entry->old_dev = dev;
657 __entry->old_sector = from; 665 __entry->old_sector = from;
658 __entry->nr_bios = blk_rq_count_bios(rq); 666 __entry->nr_bios = blk_rq_count_bios(rq);
659 blk_fill_rwbs(__entry->rwbs, rq->cmd_flags, blk_rq_bytes(rq)); 667 blk_fill_rwbs(__entry->rwbs, req_op(rq), rq->cmd_flags,
668 blk_rq_bytes(rq));
660 ), 669 ),
661 670
662 TP_printk("%d,%d %s %llu + %u <- (%d,%d) %llu %u", 671 TP_printk("%d,%d %s %llu + %u <- (%d,%d) %llu %u",