diff options
| author | Bart Van Assche <bart.vanassche@wdc.com> | 2018-08-10 16:28:07 -0400 |
|---|---|---|
| committer | Jens Axboe <axboe@kernel.dk> | 2018-08-11 17:41:25 -0400 |
| commit | b86d865cb1cae1e61527ea0b8977078bbf694328 (patch) | |
| tree | e78dcb385ae1f412bea1930a77171a5a39ab1f50 /include/linux | |
| parent | 46451874c7c9afaa4e014aea0f0970f886444e0d (diff) | |
blkcg: Make blkg_root_lookup() work for queues in bypass mode
For legacy queues the only call of blkg_root_lookup() happens after
bypass mode has been enabled. Since blkg_lookup() returns NULL for
queues in bypass mode, modify the blkg_root_lookup() such that it
no longer depends on bypass mode. Rename the function into
blk_queue_root_blkg() as suggested by Tejun.
Suggested-by: Tejun Heo <tj@kernel.org>
Fixes: 6bad9b210a22 ("blkcg: Introduce blkg_root_lookup()")
Signed-off-by: Bart Van Assche <bart.vanassche@wdc.com>
Cc: Tejun Heo <tj@kernel.org>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'include/linux')
| -rw-r--r-- | include/linux/blk-cgroup.h | 15 |
1 files changed, 5 insertions, 10 deletions
diff --git a/include/linux/blk-cgroup.h b/include/linux/blk-cgroup.h index 1361cfc9b878..34aec30e06c7 100644 --- a/include/linux/blk-cgroup.h +++ b/include/linux/blk-cgroup.h | |||
| @@ -342,20 +342,14 @@ static inline struct blkcg_gq *blkg_lookup(struct blkcg *blkcg, | |||
| 342 | } | 342 | } |
| 343 | 343 | ||
| 344 | /** | 344 | /** |
| 345 | * blkg_lookup - look up blkg for the specified request queue | 345 | * blk_queue_root_blkg - return blkg for the (blkcg_root, @q) pair |
| 346 | * @q: request_queue of interest | 346 | * @q: request_queue of interest |
| 347 | * | 347 | * |
| 348 | * Lookup blkg for @q at the root level. See also blkg_lookup(). | 348 | * Lookup blkg for @q at the root level. See also blkg_lookup(). |
| 349 | */ | 349 | */ |
| 350 | static inline struct blkcg_gq *blkg_root_lookup(struct request_queue *q) | 350 | static inline struct blkcg_gq *blk_queue_root_blkg(struct request_queue *q) |
| 351 | { | 351 | { |
| 352 | struct blkcg_gq *blkg; | 352 | return q->root_blkg; |
| 353 | |||
| 354 | rcu_read_lock(); | ||
| 355 | blkg = blkg_lookup(&blkcg_root, q); | ||
| 356 | rcu_read_unlock(); | ||
| 357 | |||
| 358 | return blkg; | ||
| 359 | } | 353 | } |
| 360 | 354 | ||
| 361 | /** | 355 | /** |
| @@ -881,7 +875,8 @@ static inline bool blk_cgroup_congested(void) { return false; } | |||
| 881 | static inline void blkcg_schedule_throttle(struct request_queue *q, bool use_memdelay) { } | 875 | static inline void blkcg_schedule_throttle(struct request_queue *q, bool use_memdelay) { } |
| 882 | 876 | ||
| 883 | static inline struct blkcg_gq *blkg_lookup(struct blkcg *blkcg, void *key) { return NULL; } | 877 | static inline struct blkcg_gq *blkg_lookup(struct blkcg *blkcg, void *key) { return NULL; } |
| 884 | static inline struct blkcg_gq *blkg_root_lookup(struct request_queue *q) { return NULL; } | 878 | static inline struct blkcg_gq *blk_queue_root_blkg(struct request_queue *q) |
| 879 | { return NULL; } | ||
| 885 | static inline int blkcg_init_queue(struct request_queue *q) { return 0; } | 880 | static inline int blkcg_init_queue(struct request_queue *q) { return 0; } |
| 886 | static inline void blkcg_drain_queue(struct request_queue *q) { } | 881 | static inline void blkcg_drain_queue(struct request_queue *q) { } |
| 887 | static inline void blkcg_exit_queue(struct request_queue *q) { } | 882 | static inline void blkcg_exit_queue(struct request_queue *q) { } |
