diff options
author | Oleg Nesterov <oleg@redhat.com> | 2013-09-11 17:20:06 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2013-09-11 18:56:56 -0400 |
commit | e1403b8edf669ff49bbdf602cc97fefa2760cb15 (patch) | |
tree | ab4c68709afca445b444577e9b29b53ed72eee17 /include/linux/sched.h | |
parent | 28e8be31803b19d0d8f76216cb11b480b8a98bec (diff) |
include/linux/sched.h: don't use task->pid/tgid in same_thread_group/has_group_leader_pid
task_struct->pid/tgid should go away.
1. Change same_thread_group() to use task->signal for comparison.
2. Change has_group_leader_pid(task) to compare task_pid(task) with
signal->leader_pid.
Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Cc: Michal Hocko <mhocko@suse.cz>
Cc: Sergey Dyasly <dserrg@gmail.com>
Reviewed-by: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'include/linux/sched.h')
-rw-r--r-- | include/linux/sched.h | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/include/linux/sched.h b/include/linux/sched.h index ce1e1c0aaa33..45f254dddafc 100644 --- a/include/linux/sched.h +++ b/include/linux/sched.h | |||
@@ -2169,15 +2169,15 @@ static inline bool thread_group_leader(struct task_struct *p) | |||
2169 | * all we care about is that we have a task with the appropriate | 2169 | * all we care about is that we have a task with the appropriate |
2170 | * pid, we don't actually care if we have the right task. | 2170 | * pid, we don't actually care if we have the right task. |
2171 | */ | 2171 | */ |
2172 | static inline int has_group_leader_pid(struct task_struct *p) | 2172 | static inline bool has_group_leader_pid(struct task_struct *p) |
2173 | { | 2173 | { |
2174 | return p->pid == p->tgid; | 2174 | return task_pid(p) == p->signal->leader_pid; |
2175 | } | 2175 | } |
2176 | 2176 | ||
2177 | static inline | 2177 | static inline |
2178 | int same_thread_group(struct task_struct *p1, struct task_struct *p2) | 2178 | bool same_thread_group(struct task_struct *p1, struct task_struct *p2) |
2179 | { | 2179 | { |
2180 | return p1->tgid == p2->tgid; | 2180 | return p1->signal == p2->signal; |
2181 | } | 2181 | } |
2182 | 2182 | ||
2183 | static inline struct task_struct *next_thread(const struct task_struct *p) | 2183 | static inline struct task_struct *next_thread(const struct task_struct *p) |