net: make ndo_get_stats64 a void function

The network device operation for reading statistics is only called
in one place, and it ignores the return value. Having a structure
return value is potentially confusing because some future driver could
incorrectly assume that the return value was used.

Fix all drivers with ndo_get_stats64 to have a void function.

Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

1 files changed, 4 insertions, 4 deletions

diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
index ecd78b3c9aba..b14ad9c139d7 100644
--- a/include/linux/netdevice.h
+++ b/include/linux/netdevice.h
@@ -913,8 +913,8 @@ struct netdev_xdp {
  *      Callback used when the transmitter has not made any progress
  *      for dev->watchdog ticks.
  *
- * struct rtnl_link_stats64* (*ndo_get_stats64)(struct net_device *dev,
- *                      struct rtnl_link_stats64 *storage);
+ * void (*ndo_get_stats64)(struct net_device *dev,
+ *                         struct rtnl_link_stats64 *storage);
  * struct net_device_stats* (*ndo_get_stats)(struct net_device *dev);
  *      Called when a user wants to get the network device usage
  *      statistics. Drivers must do one of the following:
@@ -1165,8 +1165,8 @@ struct net_device_ops {
                                                    struct neigh_parms *);
         void                    (*ndo_tx_timeout) (struct net_device *dev);
 
-        struct rtnl_link_stats64* (*ndo_get_stats64)(struct net_device *dev,
-                                                     struct rtnl_link_stats64 *storage);
+        void                    (*ndo_get_stats64)(struct net_device *dev,
+                                                   struct rtnl_link_stats64 *storage);
         bool                    (*ndo_has_offload_stats)(const struct net_device *dev, int attr_id);
         int                     (*ndo_get_offload_stats)(int attr_id,
                                                          const struct net_device *dev,