diff options
author | Nathan Chancellor <natechancellor@gmail.com> | 2018-12-20 11:23:43 -0500 |
---|---|---|
committer | Jens Axboe <axboe@kernel.dk> | 2018-12-20 11:51:31 -0500 |
commit | a52c5a16cf19d8a85831bb1b915a221dd4ffae3c (patch) | |
tree | 97e32c8a66ef4eade4223663db16bcd68fe69e40 /include/linux/genl_magic_struct.h | |
parent | f31e583aa2c20892aca3add26957dee6ab80a534 (diff) |
drbd: Avoid Clang warning about pointless switch statment
There are several warnings from Clang about no case statement matching
the constant 0:
In file included from drivers/block/drbd/drbd_receiver.c:48:
In file included from drivers/block/drbd/drbd_int.h:48:
In file included from ./include/linux/drbd_genl_api.h:54:
In file included from ./include/linux/genl_magic_struct.h:236:
./include/linux/drbd_genl.h:321:1: warning: no case matching constant
switch condition '0'
GENL_struct(DRBD_NLA_HELPER, 24, drbd_helper_info,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
./include/linux/genl_magic_struct.h:220:10: note: expanded from macro
'GENL_struct'
switch (0) {
^
Silence this warning by adding a 'case 0:' statement. Additionally,
adjust the alignment of the statements in the ct_assert_unique macro to
avoid a checkpatch warning.
This solution was originally sent by Arnd Bergmann with a default case
statement: https://lore.kernel.org/patchwork/patch/756723/
Link: https://github.com/ClangBuiltLinux/linux/issues/43
Suggested-by: Lars Ellenberg <lars.ellenberg@linbit.com>
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'include/linux/genl_magic_struct.h')
-rw-r--r-- | include/linux/genl_magic_struct.h | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/include/linux/genl_magic_struct.h b/include/linux/genl_magic_struct.h index 5972e4969197..eeae59d3ceb7 100644 --- a/include/linux/genl_magic_struct.h +++ b/include/linux/genl_magic_struct.h | |||
@@ -191,6 +191,7 @@ static inline void ct_assert_unique_operations(void) | |||
191 | { | 191 | { |
192 | switch (0) { | 192 | switch (0) { |
193 | #include GENL_MAGIC_INCLUDE_FILE | 193 | #include GENL_MAGIC_INCLUDE_FILE |
194 | case 0: | ||
194 | ; | 195 | ; |
195 | } | 196 | } |
196 | } | 197 | } |
@@ -209,6 +210,7 @@ static inline void ct_assert_unique_top_level_attributes(void) | |||
209 | { | 210 | { |
210 | switch (0) { | 211 | switch (0) { |
211 | #include GENL_MAGIC_INCLUDE_FILE | 212 | #include GENL_MAGIC_INCLUDE_FILE |
213 | case 0: | ||
212 | ; | 214 | ; |
213 | } | 215 | } |
214 | } | 216 | } |
@@ -218,7 +220,8 @@ static inline void ct_assert_unique_top_level_attributes(void) | |||
218 | static inline void ct_assert_unique_ ## s_name ## _attributes(void) \ | 220 | static inline void ct_assert_unique_ ## s_name ## _attributes(void) \ |
219 | { \ | 221 | { \ |
220 | switch (0) { \ | 222 | switch (0) { \ |
221 | s_fields \ | 223 | s_fields \ |
224 | case 0: \ | ||
222 | ; \ | 225 | ; \ |
223 | } \ | 226 | } \ |
224 | } | 227 | } |