diff options
author | Jan Kara <jack@suse.cz> | 2019-02-07 05:55:39 -0500 |
---|---|---|
committer | Jens Axboe <axboe@kernel.dk> | 2019-02-07 14:57:17 -0500 |
commit | 0803de78049fe1b0baf44bcddc727b036fb9139b (patch) | |
tree | ffaa5b77647c61a2a92cd054e1fbe81283213f29 /include/linux/blktrace_api.h | |
parent | 43636c804df0126da669c261fc820fb22f62bfc2 (diff) |
blktrace: Show requests without sector
Currently, blktrace will not show requests that don't have any data as
rq->__sector is initialized to -1 which is out of device range and thus
discarded by act_log_check(). This is most notably the case for cache
flush requests sent to the device. Fix the problem by making
blk_rq_trace_sector() return 0 for requests without initialized sector.
Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
Signed-off-by: Jan Kara <jack@suse.cz>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'include/linux/blktrace_api.h')
-rw-r--r-- | include/linux/blktrace_api.h | 8 |
1 files changed, 7 insertions, 1 deletions
diff --git a/include/linux/blktrace_api.h b/include/linux/blktrace_api.h index 8804753805ac..7bb2d8de9f30 100644 --- a/include/linux/blktrace_api.h +++ b/include/linux/blktrace_api.h | |||
@@ -116,7 +116,13 @@ extern void blk_fill_rwbs(char *rwbs, unsigned int op, int bytes); | |||
116 | 116 | ||
117 | static inline sector_t blk_rq_trace_sector(struct request *rq) | 117 | static inline sector_t blk_rq_trace_sector(struct request *rq) |
118 | { | 118 | { |
119 | return blk_rq_is_passthrough(rq) ? 0 : blk_rq_pos(rq); | 119 | /* |
120 | * Tracing should ignore starting sector for passthrough requests and | ||
121 | * requests where starting sector didn't get set. | ||
122 | */ | ||
123 | if (blk_rq_is_passthrough(rq) || blk_rq_pos(rq) == (sector_t)-1) | ||
124 | return 0; | ||
125 | return blk_rq_pos(rq); | ||
120 | } | 126 | } |
121 | 127 | ||
122 | static inline unsigned int blk_rq_trace_nr_sectors(struct request *rq) | 128 | static inline unsigned int blk_rq_trace_nr_sectors(struct request *rq) |