diff options
| author | Linus Torvalds <torvalds@linux-foundation.org> | 2017-06-17 04:34:41 -0400 |
|---|---|---|
| committer | Linus Torvalds <torvalds@linux-foundation.org> | 2017-06-17 04:34:41 -0400 |
| commit | adc311034c356e884d180df25deb046cef3e8c75 (patch) | |
| tree | 01c21bf6c26c47f30f710528d494c001379525c9 /fs | |
| parent | c8636b90a091331beb0a26c455a0c87b93aa774a (diff) | |
| parent | 95989c46d2a156365867b1d795fdefce71bce378 (diff) | |
Merge tag 'xfs-4.12-fixes-4' of git://git.kernel.org/pub/scm/fs/xfs/xfs-linux
Pull xfs fix from Darrick Wong:
"One more bugfix for you for 4.12-rc6 to fix something that came up in
an earlier rc:
- Fix some bogus ASSERT failures on CONFIG_SMP=n and CONFIG_XFS_DEBUG=y"
* tag 'xfs-4.12-fixes-4' of git://git.kernel.org/pub/scm/fs/xfs/xfs-linux:
xfs: fix spurious spin_is_locked() assert failures on non-smp kernels
Diffstat (limited to 'fs')
| -rw-r--r-- | fs/xfs/xfs_buf.c | 2 | ||||
| -rw-r--r-- | fs/xfs/xfs_icache.c | 5 |
2 files changed, 3 insertions, 4 deletions
diff --git a/fs/xfs/xfs_buf.c b/fs/xfs/xfs_buf.c index 07b77b73b024..16d6a578fc16 100644 --- a/fs/xfs/xfs_buf.c +++ b/fs/xfs/xfs_buf.c | |||
| @@ -117,7 +117,7 @@ static inline void | |||
| 117 | __xfs_buf_ioacct_dec( | 117 | __xfs_buf_ioacct_dec( |
| 118 | struct xfs_buf *bp) | 118 | struct xfs_buf *bp) |
| 119 | { | 119 | { |
| 120 | ASSERT(spin_is_locked(&bp->b_lock)); | 120 | lockdep_assert_held(&bp->b_lock); |
| 121 | 121 | ||
| 122 | if (bp->b_state & XFS_BSTATE_IN_FLIGHT) { | 122 | if (bp->b_state & XFS_BSTATE_IN_FLIGHT) { |
| 123 | bp->b_state &= ~XFS_BSTATE_IN_FLIGHT; | 123 | bp->b_state &= ~XFS_BSTATE_IN_FLIGHT; |
diff --git a/fs/xfs/xfs_icache.c b/fs/xfs/xfs_icache.c index f61c84f8e31a..990210fcb9c3 100644 --- a/fs/xfs/xfs_icache.c +++ b/fs/xfs/xfs_icache.c | |||
| @@ -66,7 +66,6 @@ xfs_inode_alloc( | |||
| 66 | 66 | ||
| 67 | XFS_STATS_INC(mp, vn_active); | 67 | XFS_STATS_INC(mp, vn_active); |
| 68 | ASSERT(atomic_read(&ip->i_pincount) == 0); | 68 | ASSERT(atomic_read(&ip->i_pincount) == 0); |
| 69 | ASSERT(!spin_is_locked(&ip->i_flags_lock)); | ||
| 70 | ASSERT(!xfs_isiflocked(ip)); | 69 | ASSERT(!xfs_isiflocked(ip)); |
| 71 | ASSERT(ip->i_ino == 0); | 70 | ASSERT(ip->i_ino == 0); |
| 72 | 71 | ||
| @@ -190,7 +189,7 @@ xfs_perag_set_reclaim_tag( | |||
| 190 | { | 189 | { |
| 191 | struct xfs_mount *mp = pag->pag_mount; | 190 | struct xfs_mount *mp = pag->pag_mount; |
| 192 | 191 | ||
| 193 | ASSERT(spin_is_locked(&pag->pag_ici_lock)); | 192 | lockdep_assert_held(&pag->pag_ici_lock); |
| 194 | if (pag->pag_ici_reclaimable++) | 193 | if (pag->pag_ici_reclaimable++) |
| 195 | return; | 194 | return; |
| 196 | 195 | ||
| @@ -212,7 +211,7 @@ xfs_perag_clear_reclaim_tag( | |||
| 212 | { | 211 | { |
| 213 | struct xfs_mount *mp = pag->pag_mount; | 212 | struct xfs_mount *mp = pag->pag_mount; |
| 214 | 213 | ||
| 215 | ASSERT(spin_is_locked(&pag->pag_ici_lock)); | 214 | lockdep_assert_held(&pag->pag_ici_lock); |
| 216 | if (--pag->pag_ici_reclaimable) | 215 | if (--pag->pag_ici_reclaimable) |
| 217 | return; | 216 | return; |
| 218 | 217 | ||
